Skip to content

Commit d7244aa

Browse files
committed
Remove setting metastore SerDe name
1 parent cf414c8 commit d7244aa

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftMetastoreUtil.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public static io.trino.hive.thrift.metastore.Table toMetastoreApiTable(Table tab
192192
result.setTableType(table.getTableType());
193193
result.setParameters(table.getParameters());
194194
result.setPartitionKeys(table.getPartitionColumns().stream().map(ThriftMetastoreUtil::toMetastoreApiFieldSchema).collect(toImmutableList()));
195-
result.setSd(makeStorageDescriptor(table.getTableName(), table.getDataColumns(), table.getStorage()));
195+
result.setSd(makeStorageDescriptor(table.getDataColumns(), table.getStorage()));
196196
result.setViewOriginalText(table.getViewOriginalText().orElse(null));
197197
result.setViewExpandedText(table.getViewExpandedText().orElse(null));
198198
table.getWriteId().ifPresent(result::setWriteId);
@@ -350,7 +350,7 @@ public static io.trino.hive.thrift.metastore.Partition toMetastoreApiPartition(P
350350
result.setDbName(partition.getDatabaseName());
351351
result.setTableName(partition.getTableName());
352352
result.setValues(partition.getValues());
353-
result.setSd(makeStorageDescriptor(partition.getTableName(), partition.getColumns(), partition.getStorage()));
353+
result.setSd(makeStorageDescriptor(partition.getColumns(), partition.getStorage()));
354354
result.setParameters(partition.getParameters());
355355
writeId.ifPresent(result::setWriteId);
356356
return result;
@@ -679,10 +679,9 @@ private static void fromMetastoreApiStorageDescriptor(
679679
.setSerdeParameters(serdeInfo.getParameters() == null ? ImmutableMap.of() : serdeInfo.getParameters());
680680
}
681681

682-
private static StorageDescriptor makeStorageDescriptor(String tableName, List<Column> columns, Storage storage)
682+
private static StorageDescriptor makeStorageDescriptor(List<Column> columns, Storage storage)
683683
{
684684
SerDeInfo serdeInfo = new SerDeInfo();
685-
serdeInfo.setName(tableName);
686685
serdeInfo.setSerializationLib(storage.getStorageFormat().getSerDeNullable());
687686
serdeInfo.setParameters(storage.getSerdeParameters());
688687

plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/TestThriftMetastoreUtil.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public class TestThriftMetastoreUtil
9797
"com.facebook.hive.orc.OrcOutputFormat",
9898
false,
9999
100,
100-
new SerDeInfo("table_name", "com.facebook.hive.orc.OrcSerde", ImmutableMap.of("sdk1", "sdv1", "sdk2", "sdv2")),
100+
new SerDeInfo(null, "com.facebook.hive.orc.OrcSerde", ImmutableMap.of("sdk1", "sdv1", "sdk2", "sdv2")),
101101
ImmutableList.of("col2", "col3"),
102102
ImmutableList.of(new Order("col2", 1)),
103103
ImmutableMap.of());
@@ -136,7 +136,7 @@ public class TestThriftMetastoreUtil
136136
"com.facebook.hive.orc.OrcOutputFormat",
137137
false,
138138
100,
139-
new SerDeInfo("table_name", "com.facebook.hive.orc.OrcSerde", ImmutableMap.of("sdk1", "sdv1", "sdk2", "sdv2")),
139+
new SerDeInfo(null, "com.facebook.hive.orc.OrcSerde", ImmutableMap.of("sdk1", "sdv1", "sdk2", "sdv2")),
140140
ImmutableList.of("col2", "col3"),
141141
ImmutableList.of(new Order("col2", 0), new Order("col3", 1)),
142142
ImmutableMap.of("sk1", "sv1"));

0 commit comments

Comments
 (0)