Skip to content

Add 2D compressible Euler with internal energy as prognostic variable#172

Merged
ranocha merged 21 commits intomainfrom
ma/internal_energy_2d
Mar 30, 2026
Merged

Add 2D compressible Euler with internal energy as prognostic variable#172
ranocha merged 21 commits intomainfrom
ma/internal_energy_2d

Conversation

@MarcoArtiano
Copy link
Copy Markdown
Collaborator

@MarcoArtiano MarcoArtiano commented Mar 28, 2026

The entropy stable and entropy conserving, total energy conserving and KEP schemes are derived in https://arxiv.org/abs/2603.18978.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

❌ Patch coverage is 98.44961% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.12%. Comparing base (fa8e2d5) to head (fcfec49).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pressible_euler_internal_energy_with_gravity_2d.jl 98.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   97.09%   97.12%   +0.03%     
==========================================
  Files          37       38       +1     
  Lines        5021     5150     +129     
==========================================
+ Hits         4875     5002     +127     
- Misses        146      148       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcoArtiano MarcoArtiano marked this pull request as ready for review March 29, 2026 10:12
@MarcoArtiano MarcoArtiano requested review from amrueda and ranocha March 29, 2026 10:12
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! My main comment is on the naming scheme: Would it make sense to adopt the same naming scheme that you used for the potential temperature equations, e.g., flux_etec (or flux_etec_kep or something like this) and flux_es? The nonconservative parts could get analogous names like flux_nonconservative_es etc.

MarcoArtiano and others added 4 commits March 29, 2026 15:40
…2d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@MarcoArtiano
Copy link
Copy Markdown
Collaborator Author

Thanks a lot! My main comment is on the naming scheme: Would it make sense to adopt the same naming scheme that you used for the potential temperature equations, e.g., flux_etec (or flux_etec_kep or something like this) and flux_es? The nonconservative parts could get analogous names like flux_nonconservative_es etc.

Thanks! I agree, it would actually make more sense, so that their properties are immediately clear.

Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few last comments. I think you also need to update the export statements.

I would also like to see convergence results for the test you added.

Would it make sense to add the baroclinic instability example as well?

MarcoArtiano and others added 4 commits March 29, 2026 16:14
@MarcoArtiano
Copy link
Copy Markdown
Collaborator Author

MarcoArtiano commented Mar 29, 2026

Thanks! Just a few last comments. I think you also need to update the export statements.

I would also like to see convergence results for the test you added.

Would it make sense to add the baroclinic instability example as well?

The convergence rates match the one in https://arxiv.org/pdf/2509.10311. Here I reported in order pressure, density and vertical velocity perturbations.
pp_L2_convergence
rhop_L2_convergence
wp_L2_convergence

We do not support a 2D baroclinic test case yet, therefore we have to wait for the next PR with the 3D equations.

@ranocha ranocha enabled auto-merge (squash) March 30, 2026 14:57
@ranocha ranocha merged commit 06a8485 into main Mar 30, 2026
10 checks passed
@ranocha ranocha deleted the ma/internal_energy_2d branch March 30, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants