Add 2D compressible Euler with internal energy as prognostic variable#172
Add 2D compressible Euler with internal energy as prognostic variable#172
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 97.09% 97.12% +0.03%
==========================================
Files 37 38 +1
Lines 5021 5150 +129
==========================================
+ Hits 4875 5002 +127
- Misses 146 148 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ranocha
left a comment
There was a problem hiding this comment.
Thanks a lot! My main comment is on the naming scheme: Would it make sense to adopt the same naming scheme that you used for the potential temperature equations, e.g., flux_etec (or flux_etec_kep or something like this) and flux_es? The nonconservative parts could get analogous names like flux_nonconservative_es etc.
examples/euler/dry_air/buoyancy/elixir_internal_energy_inertia_gravity_waves.jl
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
…2d.jl Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Thanks! I agree, it would actually make more sense, so that their properties are immediately clear. |
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
src/equations/compressible_euler_internal_energy_with_gravity_2d.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
The convergence rates match the one in https://arxiv.org/pdf/2509.10311. Here I reported in order pressure, density and vertical velocity perturbations. We do not support a 2D baroclinic test case yet, therefore we have to wait for the next PR with the 3D equations. |



The entropy stable and entropy conserving, total energy conserving and KEP schemes are derived in https://arxiv.org/abs/2603.18978.