Skip to content

Commit b29d40d

Browse files
committed
Revert "Reduce allocations using MathOptInterface.jl (#87) (#93)"
This reverts commit bfcc6f3.
1 parent 933cac3 commit b29d40d

11 files changed

Lines changed: 91 additions & 238 deletions

NEWS.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@ for human readability.
99

1010
#### Added
1111

12-
- Added shape preserving splines and interpolation using [MathOptInterface.jl](https://github.com/jump-dev/MathOptInterface.jl) and [HiGHS.jl](https://github.com/jump-dev/HiGHS.jl) [#83, #93]
12+
- Added shape preserving splines and interpolation using [JuMP.jl](https://github.com/jump-dev/JuMP.jl) and [HiGHS.jl](https://github.com/jump-dev/HiGHS.jl) [#83]
1313
- Added scattered radial basis function interpolation using [KernelInterpolation.jl](https://github.com/JoshuaLampert/KernelInterpolation.jl) [#73]
1414
- Implementation of visualization routines `plot_topography` and `plot_topography_with_interpolation_knots`
1515

1616
#### Changed
1717

18-
- Replaced [JuMP.jl](https://github.com/jump-dev/JuMP.jl) with [MathOptInterface.jl](https://github.com/jump-dev/MathOptInterface.jl) for Lavery splines to reduce allocations [#93]
1918
- The required Julia version is updated to v1.10.
2019
- Visualization routines rely on Makie.jl instead of PyPlot.jl [#52]
2120

Project.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,22 @@ StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
1111

1212
[weakdeps]
1313
HiGHS = "87dc4568-4c63-4d18-b0c0-bb2238e4078b"
14+
JuMP = "4076af6c-e467-56ae-b986-b466b2749572"
1415
KernelInterpolation = "95686e15-3c94-4443-8f08-76d06d509f7b"
1516
Makie = "ee78f7c6-11fb-53f2-987a-cfe4a2b5a57a"
16-
MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
1717

1818
[extensions]
19+
JuMPHiGHSExt = ["JuMP", "HiGHS"]
1920
KernelInterpolationExt = "KernelInterpolation"
2021
MakieExt = "Makie"
21-
MathOptInterfaceHiGHSExt = ["HiGHS", "MathOptInterface"]
2222

2323
[compat]
2424
Downloads = "1.6"
2525
HiGHS = "1.0"
26+
JuMP = "1.0"
2627
KernelInterpolation = "0.3.5"
2728
LinearAlgebra = "1"
2829
Makie = "0.21, 0.22, 0.24"
29-
MathOptInterface = "1.0"
3030
SparseArrays = "1"
3131
StaticArrays = "1.9"
3232
julia = "1.10"

docs/Project.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ CairoMakie = "13f3f980-e62b-5c42-98c6-ff1f3baf88f0"
33
Changelog = "5217a498-cd5d-4ec6-b8c2-9b85a09b6e3e"
44
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
55
HiGHS = "87dc4568-4c63-4d18-b0c0-bb2238e4078b"
6+
JuMP = "4076af6c-e467-56ae-b986-b466b2749572"
67
KernelInterpolation = "95686e15-3c94-4443-8f08-76d06d509f7b"
7-
MathOptInterface = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
88
OrdinaryDiffEqLowStorageRK = "b0944070-b475-4768-8dec-fb6eb410534d"
99
Trixi = "a7f1ee26-1774-49b1-8366-f1abc58fbfcb"
1010
TrixiBottomTopography = "86af9953-43df-404b-8eaa-d20d82623a82"
@@ -18,8 +18,8 @@ CairoMakie = "0.13, 0.15"
1818
Changelog = "1.1"
1919
Documenter = "1.3"
2020
HiGHS = "1.0"
21+
JuMP = "1.0"
2122
KernelInterpolation = "0.3.5"
22-
MathOptInterface = "1.0"
2323
OrdinaryDiffEqLowStorageRK = "1.3"
2424
Trixi = "0.12, 0.13, 0.14, 0.15, 0.16"
2525
TrixiShallowWater = "0.2"

docs/make.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ using Changelog: Changelog
55
# To load the extensions
66
import CairoMakie
77
import KernelInterpolation
8-
import MathOptInterface
8+
import JuMP
99
import HiGHS
1010

1111
# Copy list of authors to not need to synchronize it manually.
@@ -97,7 +97,7 @@ makedocs(;
9797
modules = [TrixiBottomTopography,
9898
Base.get_extension(TrixiBottomTopography, :MakieExt),
9999
Base.get_extension(TrixiBottomTopography, :KernelInterpolationExt),
100-
Base.get_extension(TrixiBottomTopography, :MathOptInterfaceHiGHSExt)],
100+
Base.get_extension(TrixiBottomTopography, :JuMPHiGHSExt)],
101101
authors = "Andrew R. Winters <andrew.ross.winters@liu.se>, Michael Schlottke-Lakemper <michael@sloede.com>",
102102
sitename = "TrixiBottomTopography.jl",
103103
format = Documenter.HTML(;

docs/src/reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ TrixiBottomTopography.RBFInterpolation1D
2424
TrixiBottomTopography.RBFInterpolation2D
2525
```
2626

27-
## MathOptInterfaceHiGHS.jl extension
27+
## JuMPHiGHS.jl extension
2828
```@docs
2929
TrixiBottomTopography.LaverySpline1D(::Vector{T}, ::Vector{T}) where {T<:Real}
3030
TrixiBottomTopography.LaverySpline1D(::String)

examples/lavery_spline_1d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
# Include packages
77
using TrixiBottomTopography
8-
using MathOptInterface
8+
using JuMP
99
using HiGHS
1010

1111
# Load in data from one of the examples from Eriksson and Jemsson thesis

examples/lavery_spline_2d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
# Include packages
77
using TrixiBottomTopography
8-
using MathOptInterface
8+
using JuMP
99
using HiGHS
1010

1111
# Load in data from one of the examples from Eriksson and Jemsson thesis

0 commit comments

Comments
 (0)