Refactor update_systems and update_systems_and_nhs functions to disable unnecessary updates

Author: svchb

src/callbacks/split_integration.jl

@@ -218,10 +218,7 @@ function update_systems_split!(semi, v_ode, u_ode, t)
     # a lot of the speedup that we can gain with split integration.
     # We assume that the TLSPH particles move so little during the substeps
     # that the extrapolated pressure/density values can be treated as constant.
-    update_systems!(v_ode, u_ode, semi, t;
-                    update_nhs=false,
-                    update_boundary_interpolation=false,
-                    update_inter_system=false)
+    update_systems!(v_ode, u_ode, semi, t)
 end
 
 function system_interaction_split!(dv_ode_split, v_ode, u_ode, semi,

src/general/semidiscretization.jl

@@ -492,9 +492,9 @@ end
 
 # Update the systems for a simulation before calling `interact!` to compute forces.
 function update_systems!(v_ode, u_ode, semi, t;
-                         update_nhs=true,
-                         update_boundary_interpolation=true,
-                         update_inter_system=true)
+                         update_nhs=false,
+                         update_boundary_interpolation=false,
+                         update_inter_system=false)
     # First update step before updating the NHS
     # (for example for writing the current coordinates in the TLSPH system)
     foreach_system_wrapped(semi, v_ode, u_ode) do system, v, u
@@ -540,7 +540,10 @@ end
 # Update the systems and neighborhood searches (NHS) for a simulation
 # before calling `interact!` to compute forces.
 function update_systems_and_nhs(v_ode, u_ode, semi, t)
-    update_systems!(v_ode, u_ode, semi, t)
+    update_systems!(v_ode, u_ode, semi, t;
+                    update_nhs=true,
+                    update_boundary_interpolation=true,
+                    update_inter_system=true)
 end
 
 # The `SplitIntegrationCallback` overwrites `semi_wrap` to use a different