Skip to content

Move check config to the corresponding systems and clearer error messages#1053

Merged
svchb merged 18 commits intotrixi-framework:mainfrom
svchb:more_semi_cleanup
Mar 2, 2026
Merged

Move check config to the corresponding systems and clearer error messages#1053
svchb merged 18 commits intotrixi-framework:mainfrom
svchb:more_semi_cleanup

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented Jan 19, 2026

based on #1052

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.24%. Comparing base (56dfe41) to head (97995f9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/general/semidiscretization.jl 76.47% 4 Missing ⚠️
src/schemes/boundary/open_boundary/system.jl 77.77% 2 Missing ⚠️
...chemes/fluid/implicit_incompressible_sph/system.jl 81.81% 2 Missing ⚠️
src/schemes/boundary/wall_boundary/system.jl 87.50% 1 Missing ⚠️
src/schemes/fluid/fluid.jl 80.00% 1 Missing ⚠️
...c/schemes/structure/total_lagrangian_sph/system.jl 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   89.28%   89.24%   -0.04%     
==========================================
  Files         121      121              
  Lines        8920     8930      +10     
==========================================
+ Hits         7964     7970       +6     
- Misses        956      960       +4     
Flag Coverage Δ
total 89.24% <82.53%> (-0.04%) ⬇️
unit 65.35% <68.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb changed the title More semi cleanup Move check config to the corresponding systems and clearer error messages Feb 20, 2026
@svchb svchb requested a review from efaulhaber February 20, 2026 13:50
@svchb svchb added the enhancement New feature or request label Feb 20, 2026
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 20, 2026

/run-gpu-tests

svchb and others added 4 commits February 24, 2026 14:18
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
@svchb svchb requested a review from efaulhaber February 24, 2026 13:44
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 24, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 25, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 1, 2026

/run-gpu-tests

@svchb svchb merged commit 6ee1995 into trixi-framework:main Mar 2, 2026
16 of 18 checks passed
@svchb svchb deleted the more_semi_cleanup branch March 2, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants