CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#1134
CompatHelper: bump compat for SciMLBase to 3, (keep existing compat)#1134github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
ee3c4ac to
ef14ed7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 88.72% 88.71% -0.02%
==========================================
Files 128 128
Lines 9745 9745
==========================================
- Hits 8646 8645 -1
- Misses 1099 1100 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looking at the changelog https://github.com/SciML/SciMLBase.jl/releases/tag/v3.0.0 there are several changes that actually require fixing for v3 Test only pass because there is a version conflict with something else and we don't get V3 in the test runs. |
|
Courtesy note from the SciMLBase v3 ecosystem sweep: this compat bump has a non-trivial v3 surface area to check before merging. 14
SciMLBase v3 renamed Suggested pattern (matches SciML/DiffEqCallbacks.jl#300): @static if isdefined(SciMLBase, :derivative_discontinuity!)
using SciMLBase: derivative_discontinuity!
else
const derivative_discontinuity! = SciMLBase.u_modified!
endThat replaces the direct Resolution caveat: CI will currently fail at Other v3 flags in src/test came up clean: no |
This pull request changes the compat entry for the
SciMLBasepackage from2to2, 3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.