RFC: odoo-venv update?

[nilshamerlinck]

• option 1: adding a new command $ odoo-venv update
  • but would be very redundant with the create command: same arguments/flags
  • except if we store original arguments in the venv's pyvenv.cfg
• option 2: adding flags on command create:
  --update-if-exists (default: False); should refuse to update if the venv was not created by uv (old venv)
  --recreate-if-exists (default: False)
• for both options, we could:
  • have a --backup flag to keep a backup of the venv in case things go wrong on update/recreation
  • show a list of the changes to inform user

[nilshamerlinck]

thoughts welcome @hailangvn @trisdoan
still pondering pros/cons...

[trisdoan]

Hi anh @nilshamerlinck , my understanding of what we're doing here is to

• (1) re-sync packages
• (2) or fully recreate a venv without manually deleting + re-running create (like the 1st run fails and 2nd create is impossible, need --replace)
  • it happens since uv 0.10 :(

correct?

option 1: $ odoo-venv update

• looks similar to uv sync, right?
• as we have stage mechanism like after_*, the command handles it too or just adding/upgrading packages
• pyvenv.cfg might be not sufficient, i think we should have .venv/.odoo-venv.toml

option 2:

• create --update-if-exists is semantically awkward, imo.

So, for (1) feature, i think option 1 is better. For (2) issue, we can add a --force, align with uv

[nilshamerlinck]

• goal: update venv after updating codebase

• examples for different contexts (different --preset):

  • project:
    1. new dependency added to /requirements.txt
    2. odoo codebase synced with upstream, with a change impacting requirements.txt
  • local/dev/demo/ci:
    1. new repo added to --addons-path with new requirements, or new requirement in existing repo/module

• I like the .venv/.odoo-venv.toml idea instead of getting constrained by pyvenv.cfg indeed

• given the stage mechanism and given the great uv caching, it's tempting not to actually touch the existing venv and create a new one with $ odoo-venv update $venv being just a wrapper over these atomic steps:

  1. $ odoo-venv create --from $venv/.odoo-venv.toml --venv-dir=$venv.tmp
  2. then if successful:
     • $ odoo-venv compare $venv $venv.tmp
     • $ mv $venv $venv.bak (if --backup, rm if not)
     • $ mv $venv.tmp $venv

[trisdoan]

implemented in #60