Skip to content

Treat issue closure as denial #199

@chadlwilson

Description

@chadlwilson
  • I have searched through the current feature requests and did not find any that were related.

Is your feature request related to a problem? Please describe.

When you use this infrequently it's sometimes easy to forget the "denial" words.

It's also sometimes convenient to just close the issue created, e.g in some cases I merge a number of PRs from dependabot for different pieces, and this action will open a number of issues. I usually want to close them all and proceed with only one.

Commenting on them individually is mildly inconvenient, but bulk closing is pretty easy.

Describe the solution you'd like

Suggest that the plugin should treat closure of the issue (without any matching comment words) as denial, e.g assuming default words

  • Comment "approve" > proceed (AS-IS)
  • Comment "approve" and close > proceed (AS-IS)
  • Comment "deny" > dont-proceed (AS-IS)
  • Close issue > dont-proceed (currently just stays there)

Describe alternatives you've considered

Continuing with the existing flow. :-)

Additional context

If one wanted to be even more certain of user intent, one could require closure to be of "not planned" or "duplicate" type; but I'd suggest that issue closure without approval suggests denial.

Thx for the useful workflow!

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions