Merge pull request #3 from truehazker/feature/logger-improvement

feat: 🎨 improve logging and error handling

Author: truehazker

CHANGELOG.md

@@ -5,6 +5,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Changed
+
+- Updated logger integration to use plugin-based approach at root app level
+- Improved app initialization and launch process with proper signal handling (SIGINT/SIGTERM)
+- Enhanced error logging with structured HTTP request context
+- Improved error handling in the users module
+
 ## [0.2.4] - 2025-11-20
 
 ### Fixed

README.md

@@ -134,6 +134,20 @@ src/
 └── main.ts               # Application entry point
 ```
 
+### Important Notes on Logger Usage
+
+The logger is initialized in the root application (`src/main.ts`) using `.use(log.into({...}))`. To avoid duplicate logs, submodules should import and use the logger directly from `src/common/logger` rather than relying on Elysia's context. Using the logger from context in submodules will result in duplicate log entries.
+
+**Example:**
+
+```typescript
+// ✅ Correct: Import logger directly
+import { log } from 'src/common/logger';
+
+// ❌ Incorrect: Using logger from Elysia context in submodules
+// This will cause duplicate logs
+```
+
 ## Configuration
 
 The application uses [Envalid](https://github.com/af/envalid) for type-safe environment variable validation. All configuration is centralized in `src/common/config.ts`.

bun.lock

@@ -13,6 +13,7 @@
         "elysia": "^1.4.16",
         "envalid": "^8.1.1",
         "pg": "^8.16.3",
+        "pino": "^10.1.0",
       },
       "devDependencies": {
         "@biomejs/biome": "2.3.6",
@@ -115,24 +116,20 @@
 
     "@tokenizer/token": ["@tokenizer/[email protected]", "", {}, "sha512-OvjF+z51L3ov0OyAU0duzsYuvO01PH7x4t6DJx+guahgTnBHkhJdG7soQeTSFLWN3efnHyibZ4Z8l2EuWwJN3A=="],
 
-    "@types/bun": ["@types/[email protected].2", "", { "dependencies": { "bun-types": "1.3.2" } }, "sha512-t15P7k5UIgHKkxwnMNkJbWlh/617rkDGEdSsDbu+qNHTaz9SKf7aC8fiIlUdD5RPpH6GEkP0cK7WlvmrEBRtWg=="],
+    "@types/bun": ["@types/[email protected].3", "", { "dependencies": { "bun-types": "1.3.3" } }, "sha512-ogrKbJ2X5N0kWLLFKeytG0eHDleBYtngtlbu9cyBKFtNL3cnpDZkNdQj8flVf6WTZUX5ulI9AY1oa7ljhSrp+g=="],
 
     "@types/node": ["@types/[email protected]", "", { "dependencies": { "undici-types": "~7.16.0" } }, "sha512-GNWcUTRBgIRJD5zj+Tq0fKOJ5XZajIiBroOF0yvj2bSU1WvNdYS/dn9UxwsujGW4JX06dnHyjV2y9rRaybH0iQ=="],
 
-    "@types/react": ["@types/[email protected]", "", { "dependencies": { "csstype": "^3.2.2" } }, "sha512-p/jUvulfgU7oKtj6Xpk8cA2Y1xKTtICGpJYeJXz2YVO2UcvjQgeRMLDGfDeqeRW2Ta+0QNFwcc8X3GH8SxZz6w=="],
-
     "atomic-sleep": ["[email protected]", "", {}, "sha512-kNOjDqAh7px0XWNI+4QbzoiR/nTkHAWNud2uvnJquD1/x5a7EQZMJT0AczqK0Qn67oY/TTQ1LbUKajZpp3I9tQ=="],
 
     "buffer-from": ["[email protected]", "", {}, "sha512-E+XQCRwSbaaiChtv6k6Dwgc+bx+Bs6vuKJHHl5kox/BaKbhiXzqQOwK4cO22yElGp2OCmjwVhT3HmxgyPGnJfQ=="],
 
-    "bun-types": ["[email protected].2", "", { "dependencies": { "@types/node": "*" }, "peerDependencies": { "@types/react": "^19" } }, "sha512-i/Gln4tbzKNuxP70OWhJRZz1MRfvqExowP7U6JKoI8cntFrtxg7RJK3jvz7wQW54UuvNC8tbKHHri5fy74FVqg=="],
+    "bun-types": ["[email protected].3", "", { "dependencies": { "@types/node": "*" } }, "sha512-z3Xwlg7j2l9JY27x5Qn3Wlyos8YAp0kKRlrePAOjgjMGS5IG6E7Jnlx736vH9UVI4wUICwwhC9anYL++XeOgTQ=="],
 
     "colorette": ["[email protected]", "", {}, "sha512-IfEDxwoWIjkeXL1eXcDiow4UbKjhLdq6/EuSVR9GMN7KVH3r9gQ83e73hsz1Nd1T3ijd5xv1wcWRYO+D6kCI2w=="],
 
     "cookie": ["[email protected]", "", {}, "sha512-9Kr/j4O16ISv8zBBhJoi4bXOYNTkFLOqSL3UDB0njXxCXNezjeyVrJyGOWtgfs/q2km1gwBcfH8q1yEGoMYunA=="],
 
-    "csstype": ["[email protected]", "", {}, "sha512-z1HGKcYy2xA8AGQfwrn0PAy+PB7X/GSj3UVJW9qKyn43xWa+gl5nXmU4qqLMRzWVLFC8KusUX8T/0kCiOYpAIQ=="],
-
     "dateformat": ["[email protected]", "", {}, "sha512-2P0p0pFGzHS5EMnhdxQi7aJN+iMheud0UhG4dlE1DLAlvL8JHjJJTX/CSm4JXwV0Ka5nGk3zC5mcb5bUQUxxMA=="],
 
     "debug": ["[email protected]", "", { "dependencies": { "ms": "^2.1.3" } }, "sha512-RGwwWnwQvkVfavKVt22FGLw+xYSdzARwm0ru6DhTVA3umU5hZc28V3kO4stgYryrTlLpuvgI9GiijltAjNbcqA=="],

package.json

@@ -21,11 +21,12 @@
     "drizzle-typebox": "^0.3.3",
     "elysia": "^1.4.16",
     "envalid": "^8.1.1",
-    "pg": "^8.16.3"
+    "pg": "^8.16.3",
+    "pino": "^10.1.0"
   },
   "devDependencies": {
     "@biomejs/biome": "2.3.6",
-    "@types/bun": "^1.3.2",
+    "@types/bun": "^1.3.3",
     "drizzle-kit": "^0.31.7",
     "pino-pretty": "^13.1.2"
   }

src/main.ts

@@ -14,8 +14,22 @@ const app = new Elysia()
       autoLogging: false,
     }),
   )
-  .onError((ctx) => {
-    log.error(ctx.error);
+  .onError(({ code, error, request }) => {
+    log.error(
+      {
+        code,
+        err: error,
+        http: request
+          ? {
+              method: request.method,
+              url: request.url,
+              referrer: request.headers.get('referer') ?? undefined,
+            }
+          : undefined,
+      },
+      'Unhandled request error',
+    );
+    return error;
   })
   .use(
     openapi({
@@ -34,12 +48,13 @@ const app = new Elysia()
       },
     }),
   )
-  .use(users)
-  .listen(config.SERVER_PORT, ({ development, hostname, port }) => {
-    log.info(
-      `🦊 Elysia is running at ${hostname}:${port} ${development ? '🚧 in development mode!🚧' : ''}`,
-    );
-  });
+  .use(users);
+
+app.listen(config.SERVER_PORT, ({ development, hostname, port }) => {
+  log.info(
+    `🦊 Elysia is running at ${hostname}:${port} ${development ? '🚧 in development mode!🚧' : ''}`,
+  );
+});
 
 process.once('SIGINT', () => {
   log.info('SIGINT received, shutting down...');

src/modules/users/index.ts

@@ -1,17 +1,22 @@
-import { Elysia } from 'elysia';
-import { log } from '../../common/logger';
+import { Elysia, status } from 'elysia';
+import { log } from 'src/common/logger';
 import { type UsersModel, usersModelPlugin } from './model';
 import { UsersService } from './service';
 
 export const users = new Elysia({ prefix: '/users', tags: ['Users'] })
-  .use(log.into())
   .use(usersModelPlugin)
   .post(
     '/',
-    async ({ log, body }): Promise<UsersModel.createResponse> => {
-      const user = await UsersService.create(body);
-      log.info(`Created user ${user.name}`);
-      return user;
+    async ({ body }): Promise<UsersModel.createResponse> => {
+      try {
+        const user = await UsersService.create(body);
+        log.info(`Created user ${user.name}`);
+        return user;
+      } catch {
+        throw status(422, {
+          message: 'Failed to create user' satisfies UsersModel.createError,
+        });
+      }
     },
     {
       body: 'users.createRequest',
@@ -28,8 +33,15 @@ export const users = new Elysia({ prefix: '/users', tags: ['Users'] })
   .get(
     '/',
     async ({ query }): Promise<UsersModel.getResponse> => {
-      const users = await UsersService.get(query);
-      return users;
+      try {
+        const users = await UsersService.get(query);
+        log.info(`Got users ${users.total}`);
+        return users;
+      } catch {
+        throw status(422, {
+          message: 'Failed to get users' satisfies UsersModel.getError,
+        });
+      }
     },
     {
       query: 'users.getQuery',