NAS-135539 / 25.04.1 / Incorrect endpoint is used to check for updates (by undsoft) (#11936)

* NAS-135539: Incorrect endpoint is used to check for updates

---------

Co-authored-by: Evgeny Stepanovych <[email protected]>

Author: bugclerk

src/app/pages/dashboard/services/widget-resources.service.spec.ts

@@ -16,6 +16,7 @@ import { App } from 'app/interfaces/app.interface';
 import { CloudSyncTask } from 'app/interfaces/cloud-sync-task.interface';
 import { NetworkInterface } from 'app/interfaces/network-interface.interface';
 import { Pool } from 'app/interfaces/pool.interface';
+import { SystemUpdateChange } from 'app/interfaces/system-update.interface';
 import { WidgetResourcesService } from 'app/pages/dashboard/services/widget-resources.service';
 
 const pools = [
@@ -214,7 +215,9 @@ describe('WidgetResourcesService', () => {
         mockCall('webui.main.dashboard.sys_info'),
         mockCall('app.query', apps),
         mockCall('pool.query', pools),
-        mockCall('update.check_available'),
+        mockCall('update.get_pending', [
+          {} as SystemUpdateChange,
+        ]),
         mockCall('reporting.netdata_get_data', [interfaceEth0]),
       ]),
     ],
@@ -252,6 +255,12 @@ describe('WidgetResourcesService', () => {
     expect(await firstValueFrom(spectator.service.installedApps$)).toEqual(apps);
   });
 
+  describe('updateAvailable$', () => {
+    it('returns true when api knows about available updates', async () => {
+      expect(await firstValueFrom(spectator.service.updateAvailable$)).toBe(true);
+    });
+  });
+
   describe('networkInterfaceLastHourStats', () => {
     it('returns network interface stats for the last hour', async () => {
       expect(

src/app/pages/dashboard/services/widget-resources.service.ts

@@ -7,7 +7,6 @@ import {
   filter,
   forkJoin, map, of, repeat, shareReplay, startWith, switchMap, throttleTime, timer,
 } from 'rxjs';
-import { SystemUpdateStatus } from 'app/enums/system-update.enum';
 import { LoadingState, toLoadingState } from 'app/helpers/operators/to-loading-state.helper';
 import { ApiEvent } from 'app/interfaces/api-message.interface';
 import { App, AppStartQueryParams, AppStats } from 'app/interfaces/app.interface';
@@ -100,8 +99,8 @@ export class WidgetResourcesService {
     map((datasets) => this.parseVolumeData(datasets)),
   );
 
-  readonly updateAvailable$ = this.api.call('update.check_available').pipe(
-    map((update) => update.status === SystemUpdateStatus.Available),
+  readonly updateAvailable$ = this.api.call('update.get_pending').pipe(
+    map((updates) => Boolean(updates.length)),
     catchError(() => of(false)),
     shareReplay({ refCount: false, bufferSize: 1 }),
   );