resolved ahrav comments

Author: kashifkhan0771

pkg/analyzer/analyzers/launchdarkly/launchdarkly.go

@@ -129,17 +129,16 @@ func secretInfoResourceToAnalyzerResource(resource Resource) *analyzers.Resource
 
 // getPermissionType return what type of permission is assigned to token
 func getPermissionType(token Token) string {
-	permission := ""
-
-	if token.Role != "" {
-		permission = token.Role
-	} else if token.hasInlineRole() {
-		permission = "Inline Policy"
-	} else if token.hasCustomRoles() {
-		permission = "Custom Roles"
+	switch {
+	case token.Role != "":
+		return token.Role
+	case token.hasInlineRole():
+		return "Inline Policy"
+	case token.hasCustomRoles():
+		return "Custom Roles"
+	default:
+		return ""
 	}
-
-	return permission
 }
 
 // printUser print User information from secret info to cli

pkg/analyzer/analyzers/launchdarkly/models.go

@@ -23,9 +23,9 @@ var (
 type SecretInfo struct {
 	User        User
 	Permissions []string
-	Resources   []Resource
-	// to concurrently read and write
-	mu sync.RWMutex
+
+	mu        sync.RWMutex
+	Resources []Resource
 }
 
 // User is the information about the user to whom the token belongs
@@ -60,16 +60,7 @@ type CustomRole struct {
 	AssignedToTeams   int
 }
 
-/*
-policy is a set of statements
-
-Jargon:
-  - Resource: List of resources
-  - NotResources: Except this list of resources
-  - Actions: List of actions
-  - NotActions: Except this list of actions
-  - Effect: Allowed or Denied
-*/
+// policy is a set of statements
 type Policy struct {
 	Resources    []string
 	NotResources []string