Skip to content

Commit fcfbb5f

Browse files
committed
add datadogapikey detector to defaults.go
1 parent 0fa069c commit fcfbb5f

3 files changed

Lines changed: 17 additions & 12 deletions

File tree

pkg/detectors/datadogapikey/datadogapikey_integration_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ func TestDataDogApiKey_FromChunk(t *testing.T) {
7272
DetectorType: detector_typepb.DetectorType_DatadogApikey,
7373
Verified: false,
7474
Raw: []byte(invalidApiKey),
75+
SecretParts: map[string]string{
76+
"api_key": invalidApiKey,
77+
},
7578
},
7679
},
7780
wantErr: false,

pkg/engine/defaults/defaults.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ import (
5656
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atera"
5757
atlassianv1 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassian/v1"
5858
atlassianv2 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassian/v2"
59+
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/bitbucketdatacenter"
60+
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/confluencedatacenter"
61+
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/jiradatacenterpat"
5962
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/audd"
6063
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/auth0managementapitoken"
6164
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/auth0oauth"
@@ -96,7 +99,6 @@ import (
9699
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/billomat"
97100
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bingsubscriptionkey"
98101
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitbar"
99-
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/bitbucketdatacenter"
100102
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitbucketapppassword"
101103
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitcoinaverage"
102104
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/bitfinex"
@@ -188,7 +190,6 @@ import (
188190
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/commercejs"
189191
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/commodities"
190192
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/companyhub"
191-
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/confluencedatacenter"
192193
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/confluent"
193194
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/contentfulpersonalaccesstoken"
194195
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/conversiontools"
@@ -215,6 +216,7 @@ import (
215216
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/dareboost"
216217
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/databox"
217218
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/databrickstoken"
219+
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/datadogapikey"
218220
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/datadogtoken"
219221
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/datagov"
220222
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/deepai"
@@ -402,7 +404,6 @@ import (
402404
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/ipquality"
403405
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/ipstack"
404406
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jdbc"
405-
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/atlassiandatacenter/jiradatacenterpat"
406407
jiratokenv1 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jiratoken/v1"
407408
jiratokenv2 "github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jiratoken/v2"
408409
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors/jotform"
@@ -1094,6 +1095,7 @@ func buildDetectorList() []detectors.Detector {
10941095
&dareboost.Scanner{},
10951096
&databox.Scanner{},
10961097
&databrickstoken.Scanner{},
1098+
&datadogapikey.Scanner{},
10971099
&datadogtoken.Scanner{},
10981100
&datagov.Scanner{},
10991101
// &debounce.Scanner{},

pkg/engine/defaults/defaults_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,21 +111,21 @@ func TestAllDetectorTypesAreInDefaultList(t *testing.T) {
111111
//
112112
// TODO: audit this list periodically — entries in the "mistakenly missed" group
113113
// should be removed once the corresponding detector is added to defaults.go.
114+
//
114115
//nolint:staticcheck // SA1019: intentionally references deprecated DetectorType values to keep them excluded.
115116
var excludedFromDefaultList = map[detector_typepb.DetectorType]struct{}{
116117
// TODO: these detectors have implementations but were mistakenly never added
117118
// to buildDetectorList() — discovered by TestAllDetectorTypesAreInDefaultList.
118119
// They are not added immediately out of caution for the impact on customers/users.
119120
// Remove each entry once its detector has been carefully added.
120-
detector_typepb.DetectorType_DatadogApikey: {},
121-
detector_typepb.DetectorType_Guru: {},
122-
detector_typepb.DetectorType_IPInfo: {},
123-
detector_typepb.DetectorType_Lob: {},
124-
detector_typepb.DetectorType_Rev: {},
125-
detector_typepb.DetectorType_TLy: {},
126-
detector_typepb.DetectorType_Tru: {},
127-
detector_typepb.DetectorType_User: {},
128-
detector_typepb.DetectorType_Wit: {},
121+
detector_typepb.DetectorType_Guru: {},
122+
detector_typepb.DetectorType_IPInfo: {},
123+
detector_typepb.DetectorType_Lob: {},
124+
detector_typepb.DetectorType_Rev: {},
125+
detector_typepb.DetectorType_TLy: {},
126+
detector_typepb.DetectorType_Tru: {},
127+
detector_typepb.DetectorType_User: {},
128+
detector_typepb.DetectorType_Wit: {},
129129

130130
// Reserved / special types.
131131
detector_typepb.DetectorType_CustomRegex: {}, // added dynamically via engine config, not via buildDetectorList()

0 commit comments

Comments
 (0)