trufflesuite
diff --git a/‎.eslintingore ‎.eslintignore
+3 b/‎.eslintingore ‎.eslintignore
+3
diff --git a/‎.eslintrc.js
+42-114 b/‎.eslintrc.js
+42-114
diff --git a/‎.gitattributes
+1 b/‎.gitattributes
+1
diff --git a/‎.github/workflows/changelog.yml
+59 b/‎.github/workflows/changelog.yml
+59
diff --git a/‎.github/workflows/core-ci-checks.yml
+29 b/‎.github/workflows/core-ci-checks.yml
+29
diff --git a/‎.github/workflows/main.yml
+6-109 b/‎.github/workflows/main.yml
+6-109
@@ -36,3 +36,6 @@ jspm_packages/
 resources/drizzle/
 
 ui-test/
+
+### We ignore the config file to stop issues.
+#  .eslintrc.js
@@ -1,125 +1,53 @@
-/*
-👋 Hi! This file was autogenerated by tslint-to-eslint-config.
-https://github.com/typescript-eslint/tslint-to-eslint-config
-
-It represents the closest reasonable ESLint configuration to this
-project's original TSLint configuration.
-
-We recommend eventually switching this configuration to extend from
-the recommended rulesets in typescript-eslint.
-https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md
-
-Happy linting! 💖
-
- TODO: remove this eventually...
-✨ 119 rules replaced with their ESLint equivalents. ✨
-
-❗ 7 ESLint rules behave differently from their TSLint counterparts ❗
-  Check ./tslint-to-eslint-config.log for details.
-
-❓ 3 rules are not known by tslint-to-eslint-config to have ESLint equivalents. ❓
-  The "@typescript-eslint/tslint/config" section of ./.eslintrc.js configures eslint-plugin-tslint to run them in TSLint within ESLint.
-  Check ./tslint-to-eslint-config.log for details.
-
-⚡ 1 new package is required for this ESLint configuration. ⚡
-  yarn add eslint-config-prettier --dev
-
-♻ Consider using --comments to replace TSLint comment directives in your source files. ♻
-
-✅ All is well! ✅
-
-*/
 module.exports = {
   env: {
     browser: true,
-    es6: true,
+    es2021: true,
     node: true,
     mocha: true,
   },
-  parser: "@typescript-eslint/parser",
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    // Adding this in future would be good but its problematic.
+    // "plugin:@typescript-eslint/recommended-requiring-type-checking",
+    'prettier',
+  ],
+  ignorePatterns: ['ui-test/**/*.ts', '.eslintrc.js', 'webpack*.js'],
+  parser: '@typescript-eslint/parser',
   parserOptions: {
-    project: ["./tsconfig.json"],
+    ecmaVersion: 'latest',
+    sourceType: 'module',
+    project: ['./tsconfig.json'],
   },
-  overrides: [
-    {
-      files: ["*.ts"],
-      parserOptions: {
-        project: ["./tsconfig.json"],
-      },
-    },
-  ],
-  extends: ["plugin:@typescript-eslint/recommended", "eslint:recommended", "prettier"],
-  plugins: ["prettier", "@typescript-eslint"],
-  ignorePatterns: ["ui-test/**/*.ts"],
+  plugins: ['@typescript-eslint'],
   rules: {
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/ban-ts-comment": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/ban-types": [
-      "off",
-      {
-        types: {
-          Object: {
-            message: "Avoid using the `Object` type. Did you mean `object`?",
-          },
-          Function: {
-            message: "Avoid using the `Function` type. Prefer a specific function type, like `() => void`.",
-          },
-          Boolean: {
-            message: "Avoid using the `Boolean` type. Did you mean `boolean`?",
-          },
-          Number: {
-            message: "Avoid using the `Number` type. Did you mean `number`?",
-          },
-          String: {
-            message: "Avoid using the `String` type. Did you mean `string`?",
-          },
-          Symbol: {
-            message: "Avoid using the `Symbol` type. Did you mean `symbol`?",
-          },
-        },
-      },
-    ],
-    "@typescript-eslint/dot-notation": "warn",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/no-empty-interface": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/no-explicit-any": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/no-inferrable-types": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/no-namespace": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/no-non-null-assertion": "off",
-    "@typescript-eslint/no-unused-vars": "off",
-    "@typescript-eslint/no-use-before-define": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/no-var-requires": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "@typescript-eslint/prefer-namespace-keyword": "off",
-    "@typescript-eslint/triple-slash-reference": [
-      "warn",
-      {
-        path: "always",
-        types: "prefer-import",
-        lib: "always",
-      },
-    ],
-    "dot-notation": "warn",
-
-    "no-constant-condition": ["error", { checkLoops: false }],
-    // FIXME: tech-debt.
-    "no-extra-boolean-cast": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "no-inner-declarations": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "no-prototype-builtins": "off",
-    // FIXME: This needs removed. Tech-Debt
-    "no-undef": "off",
-    "no-unused-vars": "off",
-    "no-useless-escape": "off",
-    "no-use-before-define": "off",
-    // FIXME: rework this eventually. Tech-debt
-    "no-var": "off",
+    'dot-notation': 'off',
+    '@typescript-eslint/dot-notation': ['error'],
+
+    // We can ignore vars in overridden methods with this rule.
+    'no-unused-vars': 'off',
+    '@typescript-eslint/no-unused-vars': ['error', {argsIgnorePattern: '^_'}],
+
+    // need this as we have a few while(true) loops.
+    'no-constant-condition': ['error', {checkLoops: false}],
+
+    // FIXME: rework this eventually. Tech-debt - 200+ warnings right now.
+    '@typescript-eslint/no-explicit-any': 'off',
+
+    // FIXME: rework this eventually. Tech-debt - 24 Issues. Prob quite complex rework.
+    '@typescript-eslint/no-namespace': 'off',
+
+    // FIXME: rework this eventually. Tech-debt  - 70 Warnings
+    '@typescript-eslint/no-non-null-assertion': 'off',
+    // FIXME: rework this eventually. Tech-debt - cant enable this - some require code/voodoo hacks.
+    '@typescript-eslint/no-var-requires': 'off',
+    // FIXME: rework this eventually. Tech-debt - 55 Errors
+    'no-inner-declarations': 'off',
+    // FIXME: rework this eventually. Tech-debt - 4 hasOwnProperty Errors
+    'no-prototype-builtins': 'off',
+    // FIXME: This needs removed. Tech-Debt - 1 error for web3 in a voodoo JS script.
+    'no-undef': 'off',
+    // FIXME: rework this eventually. Tech-debt - 8 Errors right now. Needs investigation.
+    // '@typescript-eslint/ban-ts-comment': 'off',
   },
 };
@@ -0,0 +1 @@
+* text=auto eol=lf
@@ -0,0 +1,59 @@
+name: Changelog Test
+
+on:
+  workflow_dispatch:
+
+jobs:
+  build:
+    name: '✏️ Changelog generation'
+    runs-on: ubuntu-18.04
+    steps:
+      - name: '📥 Check-out'
+        uses: actions/checkout@v2
+        # explicitly specify ${{ github.head_ref }} in the checkout Action.
+        # This is required in order to work with the pull_request event (or any other non-push event).
+        with:
+          ref: ${{ github.head_ref }}
+
+      - name: '✏️ Generate full changelog'
+        id: generate-full-changelog
+        # https://github.com/heinrichreimer/action-github-changelog-generator
+        uses: heinrichreimer/[email protected]
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          headerLabel: '# 📑 Changelog'
+          breakingLabel: '### 💥 Breaking'
+          enhancementLabel: '### 🚀 Enhancements'
+          bugsLabel: '### 🐛 Bug fixes'
+          deprecatedLabel: '### ⚠️ Deprecations'
+          removedLabel: '### 🔥 Removals'
+          securityLabel: '### 🛡️ Security'
+          issuesLabel: '### 📁 Other issues'
+          prLabel: '### 📁 Other pull requests'
+          addSections: '{"documentation":{"prefix":"### 📖 Documentation","labels":["documentation"]},"tests":{"prefix":"### ✅ Testing","labels":["tests"]}}'
+          issues: true
+          issuesWoLabels: true
+          pullRequests: true
+          prWoLabels: true
+          author: true
+          unreleased: true
+          compareLink: true
+          stripGeneratorNotice: true
+          verbose: true
+      - name: '🖨️ Print changelog to console'
+        run: cat CHANGELOG.md
+
+      # TODO - look at using autocommit here:
+      #      - name: Commit updated CHANGELOG
+      #        uses: stefanzweifel/git-auto-commit-action@v4
+      #        with:
+      #          branch: ${{ github.event.release.target_commitish }}
+      #          commit_message: Update CHANGELOG
+      #          commit_options: '--no-verify'
+      #          file_pattern: CHANGELOG.md
+
+      - name: '📤 Upload changelog'
+        uses: actions/[email protected]
+        with:
+          name: 'Changelog'
+          path: CHANGELOG.md
@@ -0,0 +1,29 @@
+name: Core CI Checks
+
+on:
+  workflow_call:
+
+jobs:
+  core-checks:
+    runs-on: windows-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Node
+        uses: actions/setup-node@v2
+        with:
+          node-version: lts/*
+          cache: 'yarn'
+
+      - name: Clean install dependencies. Fail on lockfile Changes.
+        run: yarn install --immutable --immutable-cache --check-cache --non-interactive
+
+      - name: Prettier
+        run: yarn prettier
+
+      - name: ESLint
+        run: yarn eslint
+
+      - name: Tests
+        run: yarn test
@@ -1,118 +1,15 @@
-name: CI
+name: Main Branch Checks
 
 on:
   push:
     branches:
       - develop
       - master
     paths-ignore: # dont run when changes made to these folders
-      - ".vscode/**"
+      - '.vscode/**'
 
 jobs:
-  cicd:
-    name: cicd
-    runs-on: windows-latest
-    env:
-      VSCE_FLAGS: ''
-    steps:
-      - name: checkout repo
-        uses: actions/checkout@v2
-
-      - name: fetch all history and tags from all branches for gitversion
-        run: git fetch --prune --unshallow
-
-      - name: install gitversion tool
-        uses: gittools/actions/gitversion/[email protected]
-        with:
-          versionSpec: "5.x"
-
-      - name: execute gitversion
-        id: gitversion # step id used as reference for output values
-        uses: gittools/actions/gitversion/[email protected]
-
-      - name: getPackageName
-        id: packageJson
-        uses: myrotvorets/[email protected]
-
-      - name: print Details
-        run: |
-          echo "::Major: ${{ steps.gitversion.outputs.major }}::"
-          echo "::Minor: ${{ steps.gitversion.outputs.minor }}::"
-          echo "::Patch: ${{ steps.gitversion.outputs.patch }}::"
-          echo "::MajorMinorPatch: ${{ steps.gitversion.outputs.majorMinorPatch }}::"
-          echo "::PreRelease: ${{ steps.gitversion.outputs.preReleaseTag }}::"
-          echo "::SemVer: ${{ steps.gitversion.outputs.semVer }}::"
-          echo "::PackageName: ${{steps.packageJson.outputs.packageName}} ::"
-
-      - name: setup node
-        uses: actions/setup-node@v2
-        with:
-          node-version: "16.4.x"
-          cache: "yarn"
-
-      - name: clean install dependencies. Fail on lockfile Changes.
-        run: yarn install --immutable --immutable-cache --check-cache
-
-      - name: run tests
-        run: yarn test
-
-      - name: update metadata in package.json
-        uses: onlyutkarsh/[email protected]
-        with:
-          files: "${{github.workspace}}/package.json"
-          patch-syntax: |
-            = /version => "${{ steps.gitversion.outputs.majorMinorPatch }}"
-            = /aiKey => "${{ secrets.AIKEY }}"
-
-      - name: add version in CHANGELOG.md
-        uses: cschleiden/[email protected]
-        with:
-          files: "${{github.workspace}}/CHANGELOG.md"
-        env:
-          VERSION: "${{ steps.gitversion.outputs.majorMinorPatch }}"
-
-      - name: configure package flags
-        id: package_flags
-        if: ${{ steps.gitversion.outputs.preReleaseTag != '' }}
-        run: |
-           echo "VSCE_FLAGS=--pre-release --yarn " | Out-File -FilePath $env:GITHUB_ENV -Append
-           echo "flags_set=true" | Out-File -FilePath $env:GITHUB_ENV -Append
-
-      - name: compile and create vsix MASTER Release
-        if: github.ref == 'refs/heads/master'
-        run: |
-          echo ":: Packaging VSIX VSCE_FLAGS=${{ env.VSCE_FLAGS }}, ${{ env.flags_set }} ::"
-          yarn package
-          echo "vsix_path=${{steps.packageJson.outputs.packageName}}-${{steps.gitversion.outputs.majorMinorPatch}}" | Out-File -FilePath $env:GITHUB_ENV -Append
-          echo "vsix_type=-RELEASE" | Out-File -FilePath $env:GITHUB_ENV -Append
-
-      - name: compile and create vsix Develop PreRelease
-        if: github.ref == 'refs/heads/develop'
-        run: |
-          echo ":: Packaging VSIX VSCE_FLAGS=${{ env.VSCE_FLAGS }}, ${{ env.flags_set }} :: $GITHUB_ENV"
-          yarn package ${{ env.VSCE_FLAGS }}
-          echo "vsix_path=${{steps.packageJson.outputs.packageName}}-${{steps.gitversion.outputs.majorMinorPatch}}" | Out-File -FilePath $env:GITHUB_ENV -Append
-          echo "vsix_type=-PRE_RELEASE" | Out-File -FilePath $env:GITHUB_ENV -Append
-
-      - name: print vsix path
-        run: |
-          echo "::VSIX Path: ${{ env.vsix_path }}:: TYPE: ${{ env.vsix_type }}"
-
-      - name: upload vsix as artifact
-        uses: actions/upload-artifact@v1
-        with:
-          path: ${{ github.workspace }}/${{ env.vsix_path }}.vsix
-          name: ${{ env.vsix_path }}${{ env.vsix_type }}.vsix
-
-#      - name: publish to marketplace
-#        if: github.ref == 'refs/heads/master'
-#        run: npm run deploy ${{ env.PAT }}
-#
-#      - name: create a release
-#        if: github.ref == 'refs/heads/master'
-#        uses: actions/create-release@v1
-#        env:
-#          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
-#        with:
-#          tag_name: v${{ steps.gitversion.outputs.semVer }}
-#          release_name: v${{ steps.gitversion.outputs.semVer }}
+  checks:
+    name: Core Checks - Workflow Call
+    uses: ./.github/workflows/core-ci-checks.yml
+    secrets: inherit