Skip to content

Commit 246079d

Browse files
authored
Fix clang-tidy issue URLs (#529)
We don't have a good way to transform issue URLs for the specific subset that are broken, so just redirect all to the list view. Fixes #518
1 parent cabbee1 commit 246079d

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

linters/clang-tidy/plugin.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ lint:
5050
environment:
5151
- name: PATH
5252
list: ["${linter}/bin"]
53-
issue_url_format: https://clang.llvm.org/extra/clang-tidy/checks/{}.html
53+
issue_url_format: https://clang.llvm.org/extra/clang-tidy/checks/list.html
5454
known_good_version: 16.0.3
5555
version_command:
5656
parse_regex: ${semver}

linters/clang-tidy/test_data/clang_tidy_v16.0.3_default_config.check.shot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ exports[`Testing linter clang-tidy test default_config 1`] = `
1818
"code": "readability-convert-member-functions-to-static",
1919
"column": "15",
2020
"file": "test.hh",
21-
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-convert-member-functions-to-static.html",
21+
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
2222
"level": "LEVEL_MEDIUM",
2323
"line": "2",
2424
"linter": "clang-tidy",

linters/clang-tidy/test_data/clang_tidy_v16.0.3_test_config.check.shot

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ exports[`Testing linter clang-tidy test test_config 1`] = `
1919
"code": "readability-identifier-naming",
2020
"column": "30",
2121
"file": "basic.cc",
22-
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html",
22+
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
2323
"level": "LEVEL_MEDIUM",
2424
"line": "1",
2525
"linter": "clang-tidy",
@@ -42,7 +42,7 @@ exports[`Testing linter clang-tidy test test_config 1`] = `
4242
"code": "readability-identifier-naming",
4343
"column": "7",
4444
"file": "invalid_case_style.hh",
45-
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html",
45+
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
4646
"level": "LEVEL_MEDIUM",
4747
"line": "3",
4848
"linter": "clang-tidy",
@@ -64,7 +64,7 @@ exports[`Testing linter clang-tidy test test_config 1`] = `
6464
"code": "readability-convert-member-functions-to-static",
6565
"column": "15",
6666
"file": "test.hh",
67-
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-convert-member-functions-to-static.html",
67+
"issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
6868
"level": "LEVEL_MEDIUM",
6969
"line": "2",
7070
"linter": "clang-tidy",

0 commit comments

Comments
 (0)