(Chore): Streamline repo tests (#963)

- Fix snyk test to run in CI
- Fix biome snapshots
- Fix hadolint snapshots
- Fix ansible-lint snapshots and update recommended usage for inverse
ignores
- Remove windows test workflows
- Upgrade the CLI (required fixing some of the above snapshots)

Author: TylerJang27

.github/workflows/nightly.yaml

@@ -28,14 +28,14 @@ jobs:
   # This job is used to diagnose plugin config health in advance of a release
   linter_tests_main:
     name: Plugin Tests Main
-    # runs-on: [self-hosted, "${{ matrix.os }}"] TODO(Tyler): Set after Windows self-hosted are established.
     runs-on: ${{ matrix.os }}
     timeout-minutes: 120
     strategy:
       fail-fast: false
       matrix:
         linter-version: [Snapshots, Latest]
-        os: [ubuntu-latest, macOS, windows-latest]
+        # TODO(Tyler): Re-add Windows runners.
+        os: [ubuntu-latest, macOS]
     steps:
       - name: Checkout
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -213,21 +213,21 @@ jobs:
   # Run tool tests only on main
   tool_tests_main:
     name: Tool Tests Main
-    # runs-on: [self-hosted, "${{ matrix.os }}"] TODO(Tyler): Set after Windows self-hosted are established.
     runs-on: ${{ matrix.os }}
     timeout-minutes: 120
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, macOS, windows-latest]
+        # TODO(Tyler): Re-add Windows runners.
+        os: [ubuntu-latest, macOS]
         include:
           # Normalize the filenames as inputs for ease of parsing
           - os: ubuntu-latest
             results-file: ubuntu-latest
           - os: macOS
             results-file: macos-latest
-          - os: windows-latest
-            results-file: windows-latest
+          # - os: windows-latest
+          #   results-file: windows-latest
     steps:
       - name: Checkout
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

.github/workflows/pr.yaml

@@ -241,12 +241,12 @@ jobs:
           TRUNK_GITHUB_CHECK_RUN_TITLE: Trunk Check
 
   # Run Windows tests for modified linters and tools
-  # TODO(Tyler): When this is more stabilized and we want to gate on it, we can make it part of the matrix above.
   windows_linter_tests:
     name: Windows Linter Tests
     runs-on: windows-latest
     needs: detect_changes
-    if: needs.detect_changes.outputs.linters == 'true'
+    # TODO(Tyler): Re-add Windows runners.
+    if: needs.detect_changes.outputs.linters == 'true' && false
     timeout-minutes: 90
     steps:
       - name: Checkout
@@ -271,11 +271,12 @@ jobs:
           trunk-staging-token: ${{ secrets.TRUNK_DEBUGGER_TOKEN }}
           trunk-prod-token: ${{ secrets.TRUNK_ORG_PROD_TOKEN }}
 
+  # TODO(Tyler): Re-add Windows runners.
   windows_tool_tests:
     name: Windows Tool Tests
     runs-on: windows-latest
     needs: detect_changes
-    if: needs.detect_changes.outputs.tools == 'true'
+    if: needs.detect_changes.outputs.tools == 'true' && false
     timeout-minutes: 60
     steps:
       - name: Checkout

.github/workflows/upload_results.reusable.yaml

@@ -76,12 +76,13 @@ jobs:
         with:
           name: ${{ inputs.results-prefix }}macos-latest-test-results
 
-      - name: Retrieve Test Outputs Windows
-        id: download-windows
-        uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-        continue-on-error: true
-        with:
-          name: ${{ inputs.results-prefix }}windows-latest-test-results
+      # TODO(Tyler): Re-add Windows runners.
+      # - name: Retrieve Test Outputs Windows
+      #   id: download-windows
+      #   uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      #   continue-on-error: true
+      #   with:
+      #     name: ${{ inputs.results-prefix }}windows-latest-test-results
 
       - name: Print Test Outputs
         continue-on-error: true
@@ -95,15 +96,15 @@ jobs:
           cat "macos-latest-res.json" || echo "missing"
           echo "::endgroup::"
 
-          echo "::group::Windows results"
-          cat "windows-latest-res.json" || echo "missing"
-          echo "::endgroup::"
+          # echo "::group::Windows results"
+          # cat "windows-latest-res.json" || echo "missing"
+          # echo "::endgroup::"
 
       - name: Slack Notification For Missing Artifacts
         uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
         if:
-          steps.download-ubuntu.outcome == 'failure' || steps.download-macos.outcome == 'failure' ||
-          steps.download-windows.outcome == 'failure'
+          steps.download-ubuntu.outcome == 'failure' || steps.download-macos.outcome == 'failure'
+          # || steps.download-windows.outcome == 'failure'
         with:
           method: chat.postMessage
           token: ${{ secrets.TRUNKBOT_SLACK_BOT_TOKEN }}
@@ -114,7 +115,7 @@ jobs:
               - type: section
                 text:
                   type: mrkdwn
-                  text: "Failure: <https://github.com/trunk-io/plugins/actions/runs/${{ github.run_id }}| Unable to download some ${{ inputs.results-prefix }}test result artifacts (ubuntu: ${{ steps.download-ubuntu.outcome }}, macos: ${{ steps.download-macos.outcome }}, windows: ${{ steps.download-windows.outcome }}) >"
+                  text: "Failure: <https://github.com/trunk-io/plugins/actions/runs/${{ github.run_id }}| Unable to download some ${{ inputs.results-prefix }}test result artifacts (ubuntu: ${{ steps.download-ubuntu.outcome }}, macos: ${{ steps.download-macos.outcome }} >"
 
       - name: Setup Node
         uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0

linters/ansible-lint/README.md

@@ -2,10 +2,32 @@
 
 ## Usage
 
-[Ansible-lint](https://github.com/ansible/ansible-lint) is used to check ansible playbooks. In order
-to integrate well with trunk, ansible is usually run using triggers. The trigger system allows file
-changes to trigger lint runs. An example of an ansible-lint trigger is included below, but more
-information can be found in our [docs](https://docs.trunk.io/check/configuration#trigger-rules).
+### New Recommendation
+
+We now recommend using
+[inverse ignores](https://docs.trunk.io/code-quality/linters/ignoring-issues-and-files#ignoring-multiple-files)
+to run ansible-lint. For backwards compatibility, you will need to specify filetypes yourself and
+then a list of ignores.
+
+```yaml
+lint:
+  definitions:
+    - name: ansible-lint
+      files: [yaml]
+  enabled:
+    - ansible-lint@5.3.2
+  ignore:
+    - linters: [ansible-lint]
+      paths:
+        - "**"
+        - "!test_data/jboss-standalone"
+```
+
+### Legacy Mode
+
+[Ansible-lint](https://github.com/ansible/ansible-lint) is used to check ansible playbooks.
+Historically, in order to integrate well with trunk, you would invoke ansible-lint with
+[triggers](https://docs.trunk.io/check/configuration#trigger-rules).
 
 ```yaml
 lint:

linters/ansible-lint/ansible_lint.test.ts

@@ -9,16 +9,14 @@ const preCheck =
   (driver: TrunkLintDriver) => {
     const trunkYamlPath = ".trunk/trunk.yaml";
     const currentContents = driver.readFile(trunkYamlPath);
-    const newContents = currentContents.concat(`  triggers:
-  # Run these linters
-    - linters:
-        - ansible-lint
-      # If any files matching these change
+    const newContents = currentContents.concat(`  definitions:
+    - name: ansible-lint
+      files: [yaml]
+  ignore:
+    - linters: [ansible-lint]
       paths:
         - "**"
-      # On this target (A directory in this case)
-      targets:
-        - jboss-standalone
+        - "!jboss-standalone"
 `);
     driver.writeFile(trunkYamlPath, newContents);
 

linters/ansible-lint/plugin.yaml

@@ -19,18 +19,20 @@ lint:
           version: ">=6.1.0"
           # sarif support was added in version 6.1.0
           output: sarif
-          run: ansible-lint -f sarif
+          run: ansible-lint -f sarif ${target}
           # ansible-lint >=6.15.0 return exit code 5 when no files matched
           success_codes: [0, 2, 5]
-          run_from: ${target_directory}
+          run_from: ${parent}
+          batch: true
         - name: lint
           version: ">=5.1.3"
           # Custom parser type defined in the trunk cli to handle ansible-lint's output.
           output: ansible_lint
           # parseable-severity was removed after 5.4.0
-          run: ansible-lint --parseable-severity
+          run: ansible-lint --parseable-severity ${target}
           success_codes: [0, 2]
-          run_from: ${target_directory}
+          run_from: ${parent}
+          batch: true
       tools: [ansible-lint]
       suggest_if: never
       direct_configs: [.ansible-lint]