Skip to content

Commit d688c9c

Browse files
committed
Set continue-on-error on composite-action test steps
Move continue-on-error from steps inside the composite actions to the calling job steps in pr.yaml. continue-on-error inside a composite is only respected for the inner step's own conclusion; upload-step failures (e.g. analytics-uploader's setFailed on junit test failures) still bubble up and mark the composite — and the job — as failed. Applying continue-on-error at the job-step level reliably keeps the job green while junit is still uploaded to trunk analytics for flake tracking.
1 parent c12d978 commit d688c9c

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/pr.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ jobs:
147147

148148
- name: Linter Tests
149149
# Run tests using KnownGoodVersion with any modified linters and conditionally all linters
150+
continue-on-error: true
150151
uses: ./.github/actions/linter_tests
151152
with:
152153
linter-version: KnownGoodVersion
@@ -164,6 +165,7 @@ jobs:
164165
if:
165166
(failure() || success()) && needs.detect_changes.outputs.linters == 'true' &&
166167
needs.detect_changes.outputs.linters-files != ''
168+
continue-on-error: true
167169
uses: ./.github/actions/linter_tests
168170
with:
169171
linter-version: Latest
@@ -193,6 +195,7 @@ jobs:
193195
- name: Tool Tests
194196
# Run tests using KnownGoodVersion with any modified tools and conditionally all tools. Don't run when cancelled.
195197
# TODO(Tyler): Wire up Latest tests and ReleaseVersionService
198+
continue-on-error: true
196199
uses: ./.github/actions/tool_tests
197200
with:
198201
append-args:
@@ -214,6 +217,10 @@ jobs:
214217
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
215218

216219
- name: Action Tests
220+
# continue-on-error at the job step level reliably ignores failures
221+
# inside the composite action; analytics uploader still reports the
222+
# junit so flakes are tracked.
223+
continue-on-error: true
217224
uses: ./.github/actions/action_tests
218225
with:
219226
append-args:

0 commit comments

Comments
 (0)