Commit d688c9c
committed
Set continue-on-error on composite-action test steps
Move continue-on-error from steps inside the composite actions to the
calling job steps in pr.yaml. continue-on-error inside a composite is
only respected for the inner step's own conclusion; upload-step
failures (e.g. analytics-uploader's setFailed on junit test failures)
still bubble up and mark the composite — and the job — as failed.
Applying continue-on-error at the job-step level reliably keeps the
job green while junit is still uploaded to trunk analytics for flake
tracking.1 parent c12d978 commit d688c9c
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| |||
164 | 165 | | |
165 | 166 | | |
166 | 167 | | |
| 168 | + | |
167 | 169 | | |
168 | 170 | | |
169 | 171 | | |
| |||
193 | 195 | | |
194 | 196 | | |
195 | 197 | | |
| 198 | + | |
196 | 199 | | |
197 | 200 | | |
198 | 201 | | |
| |||
214 | 217 | | |
215 | 218 | | |
216 | 219 | | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
217 | 224 | | |
218 | 225 | | |
219 | 226 | | |
| |||
0 commit comments