Merge pull request #376 from trussworks/rp/fix-builds

Fixing build errors

Author: esacteksab

.markdownlintrc

@@ -7,9 +7,11 @@
   "MD014": false,
   "MD025": false,
   "MD033": false,
+  "MD034": false,
   "MD040": false,
   "MD041": false,
   "MD042": false,
   "MD046": false,
-  "MD051": false
+  "MD051": false,
+  "MD059": false
 }

.node-version

@@ -1 +1 @@
-18.19.1
+22.21.0

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 ---
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v6.0.0
     hooks:
       - id: check-merge-conflict
       - id: check-yaml
@@ -10,24 +10,19 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/igorshubovych/markdownlint-cli
-    rev: v0.33.0
+    rev: v0.45.0
     hooks:
       - id: markdownlint
 
   - repo: https://github.com/executablebooks/mdformat
-    rev: 0.7.22
+    rev: 0.7.22 # we can't adopt 1.0.0 because the dependencies don't support it yet
     hooks:
       - id: mdformat
         additional_dependencies:
           - mdformat-gfm
           - mdformat-toc
           - mdformat-frontmatter
 
-  - repo: https://github.com/trussworks/pre-commit-hooks
-    rev: v1.1.1
-    hooks:
-      - id: circleci-validate
-
   - repo: local
     hooks:
       - id: no-mdformat-toc

docs/developing/code-reviews/README.md

@@ -7,7 +7,7 @@ gaining valuable feedback from peers, ensuring that quality standards are upheld
 throughout a project, and defects are caught as early as possible.
 
 We recognize code reviews can be a vulnerable exercise and should be approached
-with care and deliberate intention.  We've collected some of the best practices
+with care and deliberate intention. We've collected some of the best practices
 for projects to systematize the code review process and lay out expectations for
 the creator of the pull request as well as the role of the reviewer.
 

docs/developing/command-line-tools/docker.md

@@ -3,7 +3,7 @@
 ## Overview
 
 Docker is useful because it allows you to both package and run
-software with all its dependencies and configuration in isolation.  It
+software with all its dependencies and configuration in isolation. It
 also allows you (in theory) to have the same environment in
 development as in CI and production.
 
@@ -18,9 +18,9 @@ brew cask install docker
 ### Configuration of Shared Folders
 
 Anecdata suggests that removing some of the default shared folders can
-decrease CPU usage.  Usually you only need to share volumes under your
-home directory.  Open the docker for mac preferences, then select
-"File Sharing" and then remove `/Volumes` and `/private`.  You may
+decrease CPU usage. Usually you only need to share volumes under your
+home directory. Open the docker for mac preferences, then select
+"File Sharing" and then remove `/Volumes` and `/private`. You may
 also find improvements removing `/Users` and replacing it with
 `/Users/YOUR_USERNAME_GOES_HERE`.
 
@@ -36,13 +36,13 @@ Storage Driver: overlay2
 
 If you don't see overlay2, upgrading to the latest version will add
 that support, but you would need to recreate all of your docker data
-to utilize it.  The `Reset` bomb should do it.
+to utilize it. The `Reset` bomb should do it.
 
 ### Configuration of Disk Image
 
 If you've been running Docker for Mac for some time, make sure you are
-using the `raw` disk image format and not `qcow2`.  Open Docker for
-Mac preferences and select `Disk`.  Make sure the image ends with
+using the `raw` disk image format and not `qcow2`. Open Docker for
+Mac preferences and select `Disk`. Make sure the image ends with
 `Docker.raw`.
 
 ### Configuration of Resources
@@ -59,7 +59,7 @@ by the docker developers.
 ## Volume Mount Performance
 
 Synchronizing the data between the host (your Mac) and the container
-can be resource intensive and/or slow.  Read about the [performance
+can be resource intensive and/or slow. Read about the [performance
 tuning options](https://docs.docker.com/docker-for-mac/osxfs-caching/)
 to see if they might apply to the conditions in your project.
 

docs/developing/eid/README.md

@@ -38,14 +38,14 @@ List of editors that Truss engineers use (sorted alphabetically):
 
 ##### Plugins
 
-- [vim-ale](https://github.com:w0rp/ale) - Asynchronous code linter
+- [vim-ale](https://github.com/w0rp/ale) - Asynchronous code linter
 - [editorconfig](https://github.com/editorconfig/editorconfig-vim)
-- [vim-fugitive](https://github.com:tpope/vim-fugitive) - A Git wrapper so awesome, it should be illegal
-- [vim-go](https://github:fatih/vim-go) - golang development plugin for vim
+- [vim-fugitive](https://github.com/tpope/vim-fugitive) - A Git wrapper so awesome, it should be illegal
+- [vim-go](https://github.com/fatih/vim-go) - golang development plugin for vim
 - [vim-javascript](https://github.com/pangloss/vim-javascript)
-- [vim-plug](https://github.com:junegunn/vim-plug) - Minimalist plugin manager
-- [vim-prettier](https://github.com:prettier/vim-prettier)
-- [Recover](https://github.com:chrisbra/Recover.vim) - Displays a diff before recovering a swap file
+- [vim-plug](https://github.com/junegunn/vim-plug) - Minimalist plugin manager
+- [vim-prettier](https://github.com/prettier/vim-prettier)
+- [Recover](https://github.com/chrisbra/Recover.vim) - Displays a diff before recovering a swap file
 
 #### VS Code
 

docs/developing/growth/README.md

@@ -13,7 +13,7 @@ speeding up tests) and the client getting the benefit of learning that
 happened elsewhere. Allowing time for growth ensures consistent, high
 quality work which benefits everyone.
 
-Mentoring is an important part of growth.  Truss has [shared some
+Mentoring is an important part of growth. Truss has [shared some
 techniques for
 mentoring](https://truss.works/blog/2016/8/12/theres-a-method-to-the-mentoring-advice-from-a-teacher-turned-developer).
 
@@ -23,6 +23,6 @@ restrict exploration and "just get the ticket done", but that should
 happen infrequently.
 
 If someone is interested in a topic that is not related to their
-client work, a separate plan will need to be made.  That might involve
+client work, a separate plan will need to be made. That might involve
 changing client teams, changing client projects, or joining Truss
 Reserve.

docs/developing/vcs/tools.md

@@ -48,7 +48,7 @@ for merge conflicts or mistakenly adding secret keys in our code. See
 pre-commit config file from one of our projects.
 
 Since git does not distribute hooks when a repository is cloned, you will
-have to install pre-commit in each cloned repo manually using `pre-commit install --install-hooks` or pre-commit will not run in that repo.  To assist
+have to install pre-commit in each cloned repo manually using `pre-commit install --install-hooks` or pre-commit will not run in that repo. To assist
 with automating this step, pre-commit has a [feature] to exploit the
 [template directory] setting in git:
 

docs/incident-response/on-call.md

@@ -87,7 +87,7 @@ you are expected to fulfill.
   have this covered.
 - If you know you will be away for an extended period during an on-call
   shift, it is *your* responsibility to find someone to cover your shift.
-  If you are unable to, talk to your lead and see if they can help.  If
+  If you are unable to, talk to your lead and see if they can help. If
   you will be gone for more than a day or two, it may be easiest to swap
   the entire shift with someone. PagerDuty allows you to schedule these
   with [overrides](https://community.pagerduty.com/t/creating-a-schedule-override/850).

docs/incident-response/security-incidents.md

@@ -10,4 +10,4 @@ to navigate. This document will outline how to approach security
 incidents in general; individual projects will likely have additional
 reporting requirements based on client needs.
 
-\[This is a stub and needs to be expanded.\]
+[This is a stub and needs to be expanded.]