Skip to content

Commit 1518dbf

Browse files
TPRobotsEgidijus Bartkus
authored and
Egidijus Bartkus
committed
Refact: Rename stack tag (#2)
1 parent fbd6754 commit 1518dbf

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

docs/details.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
This connector can sync multiple DynamoDB tables at the same time and it does so without requiring explicit configuration for each one. On start and at regular time intervals (by default 60s) after, it queries AWS api for DynamoDB tables which match following criteria and starts Kafka Connect task for each of them:
77
* ingestion TAG key set
8-
* stack(environment) TAG key and value set
8+
* environment TAG key and value set
99
* DynamoDB streams enabled (in `new_image` or `new_and_old_image` mode)
1010

1111

@@ -40,7 +40,7 @@ Since we are using two different frameworks/libraries together there are two dif
4040
4141
### `DISCOVERY` state and task configuration
4242

43-
Connector uses AWS resource group API to receive a list of DynamoDB tables which have ingestion TAG defined. Then it iterates over this list and checks if stack TAG is matched and streams are actually enabled. Connect task is started for each table which meats all requirements.
43+
Connector uses AWS resource group API to receive a list of DynamoDB tables which have ingestion TAG defined. Then it iterates over this list and checks if environment TAG is matched and streams are actually enabled. Connect task is started for each table which meats all requirements.
4444

4545
`discovery` phase is executed on start and every 60 seconds(default config value) after initial start.
4646

docs/getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ These instructions will get you up and running this connector on your own machin
1818
* Create `test-dynamodb-connector` DynamoDB table (or use any other name you choose)
1919
* Enable DynamoDB streams with mode `new image` or `new and old image`
2020
* Set TAG's:
21-
* `stack=dev`
21+
* `environment=dev`
2222
* `datalake-ingest=`
2323
* Put some random test data into it
2424

docs/options.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"aws.access.key.id": "",
2222
"aws.secret.key": "",
2323

24-
"dynamodb.table.env.tag.key": "stack",
24+
"dynamodb.table.env.tag.key": "environment",
2525
"dynamodb.table.env.tag.value": "dev",
2626
"dynamodb.table.ingestion.tag.key": "datalake-ingest",
2727

@@ -32,9 +32,9 @@
3232
"connect.dynamodb.rediscovery.period": "60000"
3333
}
3434
```
35-
`dynamodb.table.env.tag.key` - tag key used to define environment(stack). Useful if you have `staging` and `production` under same AWS account. Or if you want to use different Kafka Connect clusters to sync different tables.
35+
`dynamodb.table.env.tag.key` - tag key used to define environment. Useful if you have `staging` and `production` under same AWS account. Or if you want to use different Kafka Connect clusters to sync different tables.
3636

37-
`dynamodb.table.env.tag.value` - defines from which environment or stack to ingest tables. For e.g. 'staging' or 'production'...
37+
`dynamodb.table.env.tag.value` - defines from which environment to ingest tables. For e.g. 'staging' or 'production'...
3838

3939
`dynamodb.table.ingestion.tag.key` - only tables marked with this tag key will be ingested.
4040

source/src/main/java/com/trustpilot/connector/dynamodb/DynamoDBSourceConnectorConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class DynamoDBSourceConnectorConfig extends AbstractConfig {
3737
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_KEY_CONFIG = "dynamodb.table.env.tag.key";
3838
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_KEY_DOC = "Define DynamoDB tables environment tag name. Only tables with dynamodb.table.env.tag.value value in this key will be ingested.";
3939
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_KEY_DISPLAY = "Environment tag key";
40-
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_KEY_DEFAULT = "stack";
40+
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_KEY_DEFAULT = "environment";
4141

4242
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_VALUE_CONFIG = "dynamodb.table.env.tag.value";
4343
public static final String SRC_DYNAMODB_TABLE_ENV_TAG_VALUE_DOC = "Define environment name which must be present in dynamodb.table.env.tag.key.";

0 commit comments

Comments
 (0)