fix(xrp): Fix Ripple.proto Kotlin compatibility (#4299)

Some parameters were changed from int64 to uint32 during the recent XRP Rust migration. However `protoc` generates Kotlin bindings with using signed integers only, so overflow happens on Kotlin side

* Ripple.OperationPayment.destinationTag is now uint64
* Ripple.OperationEscrowCreate.destinationTag is now uint64
* Ripple.OperationEscrowCreate.cancelAfter is now uint64
* Ripple.OperationEscrowCreate.finishAfter is now uint64
* Ripple.SigningInput.flags is now uint64
* Ripple.SigningInput.sourceTag is now uint64

Author: satoshiotomakan

rust/chains/tw_ripple/src/modules/protobuf_builder.rs

@@ -152,7 +152,9 @@ impl<'a> ProtobufBuilder<'a> {
             .to_classic_address()
             .into_tw()
             .context("Error converting 'Payment.destination' to a Classic address")?;
-        let destination_tag = payment.destination_tag.zero_or_some();
+        let destination_tag = payment
+            .destination_tag
+            .try_into_u32_optional("destinationTag")?;
 
         self.prepare_builder()?
             .payment(amount, destination, destination_tag)
@@ -200,9 +202,15 @@ impl<'a> ProtobufBuilder<'a> {
             .escrow_create(
                 native_amount,
                 destination,
-                escrow_create.destination_tag.zero_or_some(),
-                escrow_create.cancel_after.zero_or_some(),
-                escrow_create.finish_after.zero_or_some(),
+                escrow_create
+                    .destination_tag
+                    .try_into_u32_optional("destinationTag")?,
+                escrow_create
+                    .cancel_after
+                    .try_into_u32_optional("cancelAfter")?,
+                escrow_create
+                    .finish_after
+                    .try_into_u32_optional("finishAfter")?,
                 condition,
             )
             .map(TransactionType::EscrowCreate)
@@ -323,13 +331,13 @@ impl<'a> ProtobufBuilder<'a> {
         let mut builder = TransactionBuilder::default();
         builder
             .fee(fee)
-            .flags(self.input.flags)
+            .flags(self.input.flags.try_into_u32("inputFlags")?)
             .sequence(self.input.sequence)
             .last_ledger_sequence(self.input.last_ledger_sequence)
             .account_str(self.input.account.as_ref())?
             .signing_pub_key(&signing_public_key);
         if self.input.source_tag != 0 {
-            builder.source_tag(self.input.source_tag);
+            builder.source_tag(self.input.source_tag.try_into_u32("sourceTag")?);
         }
         Ok(builder)
     }
@@ -369,3 +377,19 @@ impl<'a> ProtobufBuilder<'a> {
         })
     }
 }
+
+trait AsUint32: TryInto<u32> {
+    fn try_into_u32(self, param: &str) -> SigningResult<u32> {
+        self.try_into()
+            .map_err(|_| SigningError::new(SigningErrorType::Error_invalid_params))
+            .with_context(|| format!("'{param}' must fit u32"))
+    }
+
+    /// Tries to convert `self` as `u32`.
+    /// Returns error if `self` doesn't fit `u32` type, or returns `None` if `self` is 0.
+    fn try_into_u32_optional(self, param: &str) -> SigningResult<Option<u32>> {
+        self.try_into_u32(param).map(u32::zero_or_some)
+    }
+}
+
+impl<T> AsUint32 for T where T: TryInto<u32> {}

rust/tw_tests/tests/chains/ripple/ripple_sign.rs

@@ -10,7 +10,7 @@ use tw_proto::Ripple::Proto;
 use tw_proto::Ripple::Proto::mod_OperationPayment::OneOfamount_oneof as AmountType;
 use tw_proto::Ripple::Proto::mod_SigningInput::OneOfoperation_oneof as OperationType;
 
-const SELL_NFTOKEN_FLAG: u32 = 0x00000001;
+const SELL_NFTOKEN_FLAG: u64 = 0x00000001;
 
 #[test]
 fn test_ripple_sign_xrp_payment_0() {

src/proto/Ripple.proto

@@ -37,7 +37,8 @@ message OperationPayment {
     string destination = 3;
 
     // A Destination Tag
-    uint32 destination_tag = 4;
+    // It must fit uint32
+    uint64 destination_tag = 4;
 }
 
 // https://xrpl.org/escrowcreate.html
@@ -49,13 +50,16 @@ message OperationEscrowCreate {
     string destination = 2;
 
     // Destination Tag
-    uint32 destination_tag = 3;
+    // It must fit uint32
+    uint64 destination_tag = 3;
 
     // Escrow expire time
-    uint32 cancel_after = 4;
+    // It must fit uint32
+    uint64 cancel_after = 4;
 
     // Escrow release time
-    uint32 finish_after = 5;
+    // It must fit uint32
+    uint64 finish_after = 5;
 
     // Hex-encoded crypto condition
     // https://datatracker.ietf.org/doc/html/draft-thomas-crypto-conditions-02#section-8.1
@@ -86,13 +90,13 @@ message OperationEscrowFinish {
     string fulfillment = 4;
 }
 
-// https://xrpl.org/nftokenburn.html 
+// https://xrpl.org/nftokenburn.html
 message OperationNFTokenBurn {
     // Hex-encoded H256 NFTokenId
     string nftoken_id = 1;
 }
 
-// https://xrpl.org/nftokencreateoffer.html 
+// https://xrpl.org/nftokencreateoffer.html
 message OperationNFTokenCreateOffer {
     // Hex-encoded Hash256 NFTokenId
     string nftoken_id = 1;
@@ -101,13 +105,13 @@ message OperationNFTokenCreateOffer {
     string destination = 2;
 }
 
-// https://xrpl.org/nftokenacceptoffer.html 
+// https://xrpl.org/nftokenacceptoffer.html
 message OperationNFTokenAcceptOffer {
     // Hex-encoded Hash256 NFTokenOffer
     string sell_offer = 1;
 }
 
-// https://xrpl.org/nftokencanceloffer.html 
+// https://xrpl.org/nftokencanceloffer.html
 message OperationNFTokenCancelOffer {
     // Hex-encoded Vector256 NFTokenOffers
     repeated string token_offers = 1;
@@ -128,7 +132,8 @@ message SigningInput {
     string account = 4;
 
     // Transaction flags, optional
-    uint32 flags = 5;
+    // It must fit uint32
+    uint64 flags = 5;
 
     // The secret private key used for signing (32 bytes).
     bytes private_key = 6;
@@ -167,7 +172,8 @@ message SigningInput {
 
     // Arbitrary integer used to identify the reason for this payment, or a sender on whose behalf this transaction is made.
     // Conventionally, a refund should specify the initial payment's SourceTag as the refund payment's DestinationTag.
-    uint32 source_tag = 25;
+    // It must fit uint32.
+    uint64 source_tag = 25;
 }
 
 // Result containing the signed and encoded transaction.