-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Description
Is your feature request related to a problem? Please describe.
In order for apps using wallet-core to be included in F-Droid, wallet-core needs to be published to a maven repository which F-Droid trusts, one option being mavenCentral. I did some testing using the artifacts from GitHub and found that the .pom files are missing some metadata required by mavenCentral.
Describe the solution you'd like
After the packaging and before the dependency tag add something like the following in the generated .pom file:
<name>Trust Wallet Core</name>
<description>Cross-platform, cross-blockchain wallet library.</description>
<url>https://developer.trustwallet.com/wallet-core</url>
<licenses>
<license>
<name>Apache License, Version 2.0</name>
<url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<name>FILL_OUT_NAME</name>
<email>FILL_OUT_EMAIL</email>
<organization>Trust Wallet</organization>
<organizationUrl>https://trustwallet.com</organizationUrl>
</developer>
</developers>
<scm>
<url>https://github.com/trustwallet/wallet-core</url>
</scm>
Describe alternatives you've considered
None.
Checklist
- Choose which name and email address to use
- Add the additional metadata to all .pom artifacts maven produces
- com.trustwallet.wallet-core
- com.trustwallet.wallet-core-proto
- com.trustwallet.wallet-core-kotlin
- com.trustwallet.wallet-core-kotlin-android
- com.trustwallet.wallet-core-js
- com.trustwallet.wallet-core-kotlin-jvm
- com.trustwallet.wallet-core-kotlin-iosarm64
- com.trustwallet.wallet-core-kotlin-iossimulatorarm64
- com.trustwallet.wallet-core-kotlin-iosx64
Resources
https://github.com/trustwallet/wallet-core/packages/700258
https://github.com/trustwallet/wallet-core/packages/1838567
https://github.com/trustwallet/wallet-core/packages/1784044
https://github.com/trustwallet/wallet-core/packages/1784039
https://github.com/trustwallet/wallet-core/packages/1784043
https://github.com/trustwallet/wallet-core/packages/1937616
Additional context
The email address provided in the metadata needs to have an OpenPGP key published on:
This key is needed for signing the artifacts as described in #4614