From bee0a3e5e51ea5f53ae880d987c08f75e91f36b5 Mon Sep 17 00:00:00 2001 From: Diego Maniloff Date: Tue, 24 Feb 2026 12:28:58 -0500 Subject: [PATCH 1/2] Add unregister_benchmark method to RagasEvaluatorBase for dynamic benchmark management --- src/llama_stack_provider_ragas/base.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/llama_stack_provider_ragas/base.py b/src/llama_stack_provider_ragas/base.py index d1008b22..dd31e691 100644 --- a/src/llama_stack_provider_ragas/base.py +++ b/src/llama_stack_provider_ragas/base.py @@ -121,3 +121,8 @@ async def register_benchmark(self, task_def: Benchmark) -> None: """Register a benchmark for evaluation.""" self.benchmarks[task_def.identifier] = task_def logger.info(f"Registered benchmark: {task_def.identifier}") + + async def unregister_benchmark(self, benchmark_id: str) -> None: + """Unregister a benchmark.""" + self.benchmarks.pop(benchmark_id, None) + logger.info(f"Unregistered benchmark: {benchmark_id}") From 0585ead8bdfa10b5aeb292a9d9b63681123e9610 Mon Sep 17 00:00:00 2001 From: Diego Maniloff Date: Tue, 24 Feb 2026 12:32:26 -0500 Subject: [PATCH 2/2] Enhance unregister_benchmark method in RagasEvaluatorBase to log when a benchmark is not found, improving feedback during benchmark management. --- src/llama_stack_provider_ragas/base.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/llama_stack_provider_ragas/base.py b/src/llama_stack_provider_ragas/base.py index dd31e691..f1737eaa 100644 --- a/src/llama_stack_provider_ragas/base.py +++ b/src/llama_stack_provider_ragas/base.py @@ -124,5 +124,8 @@ async def register_benchmark(self, task_def: Benchmark) -> None: async def unregister_benchmark(self, benchmark_id: str) -> None: """Unregister a benchmark.""" - self.benchmarks.pop(benchmark_id, None) - logger.info(f"Unregistered benchmark: {benchmark_id}") + removed = self.benchmarks.pop(benchmark_id, None) + if removed is not None: + logger.info(f"Unregistered benchmark: {benchmark_id}") + else: + logger.info(f"Benchmark not found (nothing to unregister): {benchmark_id}")