Skip to content

Commit 21b98e4

Browse files
sheltoncyrilclaude
andcommitted
fix(tas): correct Knative deployment mode constant casing
KServe v0.17 uses "Knative" (lowercase n), not "KNative". The incorrect casing would cause Knative deployments to fall through to the default switch case and be skipped. Signed-off-by: Shelton Cyril <sheltoncyril@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 83fdeb0 commit 21b98e4

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

controllers/tas/inference_services.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const (
2020
DEPLOYMENT_MODE_RAW = "RawDeployment"
2121
DEPLOYMENT_MODE_STANDARD = "Standard"
2222
DEPLOYMENT_MODE_SERVERLESS = "Serverless"
23-
DEPLOYMENT_MODE_KNATIVE = "KNative"
23+
DEPLOYMENT_MODE_KNATIVE = "Knative"
2424
)
2525

2626
// GetDeploymentsByLabel returns a list of Deployments that match a label key-value pair
@@ -255,7 +255,7 @@ func (r *TrustyAIServiceReconciler) handleInferenceServices(ctx context.Context,
255255
continue
256256

257257
case DEPLOYMENT_MODE_SERVERLESS, DEPLOYMENT_MODE_KNATIVE:
258-
// Handle KServe Serverless/KNative deployments (KServe v0.17+ renamed Serverless to KNative)
258+
// Handle KServe Serverless/Knative deployments (KServe v0.17+ renamed Serverless to Knative)
259259
if kServeServerlessEnabled {
260260
err := r.patchKServe(ctx, instance, infService, namespace, crName, remove, false)
261261
if err != nil {

0 commit comments

Comments
 (0)