Skip to content

Commit 982675d

Browse files
kpunwatkkpunwatk
committed
refactor(tas): migrate controller to reconcile v1 as hub version
Change TrustyAIService controller to reconcile v1.TrustyAIService instead of v1alpha1.TrustyAIService. The conversion webhook now handles automatic conversion from v1alpha1 to v1. This aligns with the EvalHub pattern and eliminates the need for dual controller versions. All v1alpha1 CRs will be automatically converted to v1 by the webhook before reaching the controller. Changes: - Update all TAS controller imports from v1alpha1 to v1 - Update all function signatures to use v1.TrustyAIService - Fix test imports to use common.Condition from v1 API - Update SetupWithManager comment to reflect webhook-based conversion
1 parent 5f6b10f commit 982675d

25 files changed

Lines changed: 141 additions & 140 deletions

‎controllers/tas/certificates.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package tas
33
import (
44
"context"
55

6-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
6+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
77
corev1 "k8s.io/api/core/v1"
88
"sigs.k8s.io/controller-runtime/pkg/client"
99
"sigs.k8s.io/controller-runtime/pkg/log"
@@ -20,7 +20,7 @@ type TLSCertVolumes struct {
2020
}
2121

2222
// createFor creates the required volumes and volume mount for the TLS certificates for a specific Kubernetes secret
23-
func (cert *TLSCertVolumes) createFor(instance *trustyaiopendatahubiov1alpha1.TrustyAIService) {
23+
func (cert *TLSCertVolumes) createFor(instance *trustyaiopendatahubiov1.TrustyAIService) {
2424
volume := corev1.Volume{
2525
Name: instance.Name + "-internal",
2626
VolumeSource: corev1.VolumeSource{
@@ -39,7 +39,7 @@ func (cert *TLSCertVolumes) createFor(instance *trustyaiopendatahubiov1alpha1.Tr
3939
cert.volumeMount = volumeMount
4040
}
4141

42-
func (r *TrustyAIServiceReconciler) GetCustomCertificatesBundle(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService) CustomCertificatesBundle {
42+
func (r *TrustyAIServiceReconciler) GetCustomCertificatesBundle(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService) CustomCertificatesBundle {
4343

4444
var customCertificatesBundle CustomCertificatesBundle
4545
// Check for custom certificate bundle config map presence

‎controllers/tas/database.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ import (
44
"context"
55
"strings"
66

7-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
7+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
88
appsv1 "k8s.io/api/apps/v1"
99
corev1 "k8s.io/api/core/v1"
1010
"k8s.io/apimachinery/pkg/api/errors"
1111
"k8s.io/apimachinery/pkg/types"
1212
"sigs.k8s.io/controller-runtime/pkg/client"
1313
)
1414

15-
func (r *TrustyAIServiceReconciler) checkDatabaseAccessible(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService) (bool, error) {
15+
func (r *TrustyAIServiceReconciler) checkDatabaseAccessible(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService) (bool, error) {
1616
deployment := &appsv1.Deployment{}
1717
err := r.Get(ctx, types.NamespacedName{Name: instance.Name, Namespace: instance.Namespace}, deployment)
1818
if err != nil {

‎controllers/tas/deployment.go‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"reflect"
77
"strconv"
88

9-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
9+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
1010
"github.com/trustyai-explainability/trustyai-service-operator/controllers/constants"
1111
templateParser "github.com/trustyai-explainability/trustyai-service-operator/controllers/tas/templates"
1212
appsv1 "k8s.io/api/apps/v1"
@@ -32,7 +32,7 @@ type CustomCertificatesBundle struct {
3232
}
3333

3434
type DeploymentConfig struct {
35-
Instance *trustyaiopendatahubiov1alpha1.TrustyAIService
35+
Instance *trustyaiopendatahubiov1.TrustyAIService
3636
ServiceImage string
3737
KubeRBACProxyImage string
3838
Schedule string
@@ -45,7 +45,7 @@ type DeploymentConfig struct {
4545
}
4646

4747
// createDeploymentObject returns a Deployment for the TrustyAI Service instance
48-
func (r *TrustyAIServiceReconciler) createDeploymentObject(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, serviceImage string, caBunble CustomCertificatesBundle) (*appsv1.Deployment, error) {
48+
func (r *TrustyAIServiceReconciler) createDeploymentObject(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService, serviceImage string, caBunble CustomCertificatesBundle) (*appsv1.Deployment, error) {
4949

5050
var batchSize int
5151
// If no batch size is provided, assume the default one
@@ -99,7 +99,7 @@ func (r *TrustyAIServiceReconciler) createDeploymentObject(ctx context.Context,
9999
}
100100

101101
// reconcileDeployment returns a Deployment object with the same name/namespace as the cr
102-
func (r *TrustyAIServiceReconciler) createDeployment(ctx context.Context, cr *trustyaiopendatahubiov1alpha1.TrustyAIService, imageName string, caBundle CustomCertificatesBundle) error {
102+
func (r *TrustyAIServiceReconciler) createDeployment(ctx context.Context, cr *trustyaiopendatahubiov1.TrustyAIService, imageName string, caBundle CustomCertificatesBundle) error {
103103

104104
if !cr.Spec.Storage.IsDatabaseConfigurationsSet() {
105105

@@ -136,7 +136,7 @@ func (r *TrustyAIServiceReconciler) createDeployment(ctx context.Context, cr *tr
136136
}
137137

138138
// updateDeployment returns a Deployment object with the same name/namespace as the cr
139-
func (r *TrustyAIServiceReconciler) updateDeployment(ctx context.Context, cr *trustyaiopendatahubiov1alpha1.TrustyAIService, imageName string, caBundle CustomCertificatesBundle) error {
139+
func (r *TrustyAIServiceReconciler) updateDeployment(ctx context.Context, cr *trustyaiopendatahubiov1.TrustyAIService, imageName string, caBundle CustomCertificatesBundle) error {
140140

141141
if !cr.Spec.Storage.IsDatabaseConfigurationsSet() {
142142

@@ -172,7 +172,7 @@ func (r *TrustyAIServiceReconciler) updateDeployment(ctx context.Context, cr *tr
172172

173173
}
174174

175-
func (r *TrustyAIServiceReconciler) ensureDeployment(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, caBundle CustomCertificatesBundle, migration bool) error {
175+
func (r *TrustyAIServiceReconciler) ensureDeployment(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService, caBundle CustomCertificatesBundle, migration bool) error {
176176

177177
// Get image and tag from ConfigMap
178178
// If there's a ConfigMap with custom images, it is only applied when the operator is first deployed
@@ -205,7 +205,7 @@ func (r *TrustyAIServiceReconciler) ensureDeployment(ctx context.Context, instan
205205
}
206206

207207
// checkDeploymentReady verifies that a TrustyAI service deployment is ready
208-
func (r *TrustyAIServiceReconciler) checkDeploymentReady(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService) (bool, error) {
208+
func (r *TrustyAIServiceReconciler) checkDeploymentReady(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService) (bool, error) {
209209
deployment := &appsv1.Deployment{}
210210

211211
err := r.Get(ctx, types.NamespacedName{Name: instance.Name, Namespace: instance.Namespace}, deployment)

‎controllers/tas/deployment_test.go‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
. "github.com/onsi/ginkgo/v2"
1111
. "github.com/onsi/gomega"
12-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
12+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
1313
"github.com/trustyai-explainability/trustyai-service-operator/controllers/constants"
1414
appsv1 "k8s.io/api/apps/v1"
1515
corev1 "k8s.io/api/core/v1"
@@ -30,7 +30,7 @@ func printKubeObject(obj interface{}) {
3030
}
3131
}
3232

33-
func setupAndTestDeploymentDefault(instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string) {
33+
func setupAndTestDeploymentDefault(instance *trustyaiopendatahubiov1.TrustyAIService, namespace string) {
3434
Expect(createNamespace(ctx, k8sClient, namespace)).To(Succeed())
3535
caBundle := reconciler.GetCustomCertificatesBundle(ctx, instance)
3636

@@ -92,7 +92,7 @@ func setupAndTestDeploymentDefault(instance *trustyaiopendatahubiov1alpha1.Trust
9292

9393
}
9494

95-
func setupAndTestDeploymentConfigMap(instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string) {
95+
func setupAndTestDeploymentConfigMap(instance *trustyaiopendatahubiov1.TrustyAIService, namespace string) {
9696
serviceImage := "custom-service-image:foo"
9797
kubeRBACProxyImage := "custom-kube-rbac-proxy:bar"
9898
Expect(createNamespace(ctx, k8sClient, namespace)).To(Succeed())
@@ -165,7 +165,7 @@ func setupAndTestDeploymentConfigMap(instance *trustyaiopendatahubiov1alpha1.Tru
165165

166166
}
167167

168-
func setupAndTestDeploymentNoCustomCABundle(instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string) {
168+
func setupAndTestDeploymentNoCustomCABundle(instance *trustyaiopendatahubiov1.TrustyAIService, namespace string) {
169169
Expect(createNamespace(ctx, k8sClient, namespace)).To(Succeed())
170170

171171
caBundle := reconciler.GetCustomCertificatesBundle(ctx, instance)
@@ -198,7 +198,7 @@ func setupAndTestDeploymentNoCustomCABundle(instance *trustyaiopendatahubiov1alp
198198

199199
}
200200

201-
func setupAndTestDeploymentCustomCABundle(instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string) {
201+
func setupAndTestDeploymentCustomCABundle(instance *trustyaiopendatahubiov1.TrustyAIService, namespace string) {
202202
caBundleConfigMap := createTrustedCABundleConfigMap(namespace)
203203
Expect(createNamespace(ctx, k8sClient, namespace)).To(Succeed())
204204
Expect(k8sClient.Create(ctx, caBundleConfigMap)).To(Succeed())
@@ -233,7 +233,7 @@ func setupAndTestDeploymentCustomCABundle(instance *trustyaiopendatahubiov1alpha
233233

234234
}
235235

236-
func setupAndTestDeploymentServiceAccount(instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string, mode string) {
236+
func setupAndTestDeploymentServiceAccount(instance *trustyaiopendatahubiov1.TrustyAIService, namespace string, mode string) {
237237
Expect(createNamespace(ctx, k8sClient, namespace)).To(Succeed())
238238

239239
caBundle := reconciler.GetCustomCertificatesBundle(ctx, instance)
@@ -253,7 +253,7 @@ func setupAndTestDeploymentServiceAccount(instance *trustyaiopendatahubiov1alpha
253253
Expect(deployment.Spec.Template.Spec.ServiceAccountName).To(Equal(instance.Name + "-proxy"))
254254
}
255255

256-
func setupAndTestDeploymentInferenceService(instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string, mode string) {
256+
func setupAndTestDeploymentInferenceService(instance *trustyaiopendatahubiov1.TrustyAIService, namespace string, mode string) {
257257
WaitFor(func() error {
258258
return createNamespace(ctx, k8sClient, namespace)
259259
}, "failed to create namespace")
@@ -346,7 +346,7 @@ var _ = Describe("TrustyAI operator", func() {
346346
})
347347

348348
Context("When deploying with default settings without an InferenceService", func() {
349-
var instance *trustyaiopendatahubiov1alpha1.TrustyAIService
349+
var instance *trustyaiopendatahubiov1.TrustyAIService
350350
It("Creates a deployment and a service with the default configuration in PVC-mode", func() {
351351
namespace := "trusty-ns-a-1-pvc"
352352
instance = createDefaultPVCCustomResource(namespace)
@@ -374,7 +374,7 @@ var _ = Describe("TrustyAI operator", func() {
374374
})
375375

376376
Context("When deploying with a ConfigMap and without an InferenceService", func() {
377-
var instance *trustyaiopendatahubiov1alpha1.TrustyAIService
377+
var instance *trustyaiopendatahubiov1.TrustyAIService
378378

379379
It("Creates a deployment and a service with the ConfigMap configuration in PVC-mode", func() {
380380
namespace := "trusty-ns-a-1-cm-pvc"
@@ -390,7 +390,7 @@ var _ = Describe("TrustyAI operator", func() {
390390
})
391391

392392
Context("When deploying with default settings without an InferenceService", func() {
393-
var instance *trustyaiopendatahubiov1alpha1.TrustyAIService
393+
var instance *trustyaiopendatahubiov1.TrustyAIService
394394

395395
It("should set environment variables correctly in PVC mode", func() {
396396

@@ -715,7 +715,7 @@ var _ = Describe("TrustyAI operator", func() {
715715
})
716716

717717
Context("When deploying with no custom CA bundle ConfigMap", func() {
718-
var instance *trustyaiopendatahubiov1alpha1.TrustyAIService
718+
var instance *trustyaiopendatahubiov1.TrustyAIService
719719

720720
It("should use the correct service account and not include CustomCertificatesBundle in PVC-mode", func() {
721721

@@ -739,7 +739,7 @@ var _ = Describe("TrustyAI operator", func() {
739739
})
740740

741741
Context("When deploying with a custom CA bundle ConfigMap", func() {
742-
var instance *trustyaiopendatahubiov1alpha1.TrustyAIService
742+
var instance *trustyaiopendatahubiov1.TrustyAIService
743743

744744
It("should use the correct service account and include CustomCertificatesBundle in PVC-mode", func() {
745745

@@ -762,7 +762,7 @@ var _ = Describe("TrustyAI operator", func() {
762762
})
763763

764764
Context("When deploying with default settings without an InferenceService", func() {
765-
var instance *trustyaiopendatahubiov1alpha1.TrustyAIService
765+
var instance *trustyaiopendatahubiov1.TrustyAIService
766766

767767
It("should use the correct service account in PVC-mode", func() {
768768

@@ -843,11 +843,11 @@ var _ = Describe("TrustyAI operator", func() {
843843
})
844844

845845
Context("Across multiple namespaces", func() {
846-
var instances []*trustyaiopendatahubiov1alpha1.TrustyAIService
846+
var instances []*trustyaiopendatahubiov1.TrustyAIService
847847

848848
var namespaces = []string{"namespace1", "namespace2", "namespace3"}
849849

850-
instances = make([]*trustyaiopendatahubiov1alpha1.TrustyAIService, len(namespaces))
850+
instances = make([]*trustyaiopendatahubiov1.TrustyAIService, len(namespaces))
851851

852852
It("Deploys services with defaults in each specified namespace", func() {
853853
for i, namespace := range namespaces {

‎controllers/tas/destination_rule.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"fmt"
66
"reflect"
77

8-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
8+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
99
templateParser "github.com/trustyai-explainability/trustyai-service-operator/controllers/tas/templates"
1010
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
1111
"k8s.io/apimachinery/pkg/api/errors"
@@ -44,7 +44,7 @@ func (r *TrustyAIServiceReconciler) isDestinationRuleCRDPresent(ctx context.Cont
4444
return true, nil
4545
}
4646

47-
func (r *TrustyAIServiceReconciler) ensureDestinationRule(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService) error {
47+
func (r *TrustyAIServiceReconciler) ensureDestinationRule(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService) error {
4848

4949
destinationRuleName := instance.Name + "-internal"
5050

‎controllers/tas/events.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
package tas
22

33
import (
4-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
4+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
55
corev1 "k8s.io/api/core/v1"
66
)
77

8-
func (r *TrustyAIServiceReconciler) eventModelMeshConfigured(instance *trustyaiopendatahubiov1alpha1.TrustyAIService) {
8+
func (r *TrustyAIServiceReconciler) eventModelMeshConfigured(instance *trustyaiopendatahubiov1.TrustyAIService) {
99
r.EventRecorder.Event(instance, corev1.EventTypeNormal, EventReasonInferenceServiceConfigured, "ModelMesh InferenceService configured")
1010
}
1111

12-
func (r *TrustyAIServiceReconciler) eventKServeConfigured(instance *trustyaiopendatahubiov1alpha1.TrustyAIService) {
12+
func (r *TrustyAIServiceReconciler) eventKServeConfigured(instance *trustyaiopendatahubiov1.TrustyAIService) {
1313
r.EventRecorder.Event(instance, corev1.EventTypeNormal, EventReasonInferenceServiceConfigured, "KServe InferenceService configured")
1414
}
1515

16-
func (r *TrustyAIServiceReconciler) eventPVCCreated(instance *trustyaiopendatahubiov1alpha1.TrustyAIService) {
16+
func (r *TrustyAIServiceReconciler) eventPVCCreated(instance *trustyaiopendatahubiov1.TrustyAIService) {
1717
r.EventRecorder.Event(instance, corev1.EventTypeNormal, EventReasonPVCCreated, "PVC created")
1818
}
1919

20-
func (r *TrustyAIServiceReconciler) eventLocalServiceMonitorCreated(instance *trustyaiopendatahubiov1alpha1.TrustyAIService) {
20+
func (r *TrustyAIServiceReconciler) eventLocalServiceMonitorCreated(instance *trustyaiopendatahubiov1.TrustyAIService) {
2121
r.EventRecorder.Event(instance, corev1.EventTypeNormal, EventReasonServiceMonitorCreated, "Local ServiceMonitor created")
2222
}

‎controllers/tas/finalizers.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ package tas
33
import (
44
"context"
55

6-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
6+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
77
"sigs.k8s.io/controller-runtime/pkg/log"
88
)
99

1010
// deleteExternalDependency removes the payload processor from the ModelMesh deployment
11-
func (r *TrustyAIServiceReconciler) deleteExternalDependency(crName string, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string, ctx context.Context) error {
11+
func (r *TrustyAIServiceReconciler) deleteExternalDependency(crName string, instance *trustyaiopendatahubiov1.TrustyAIService, namespace string, ctx context.Context) error {
1212
log.FromContext(ctx).Info("Deleting external dependencies")
1313
// Call handleInferenceServices with remove set to true
1414
_, err := r.handleInferenceServices(ctx, instance, namespace, modelMeshLabelKey, modelMeshLabelValue, payloadProcessorName, instance.Name, true)

‎controllers/tas/inference_services.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
"strings"
77

88
kservev1beta1 "github.com/kserve/kserve/pkg/apis/serving/v1beta1"
9-
trustyaiopendatahubiov1alpha1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1alpha1"
9+
trustyaiopendatahubiov1 "github.com/trustyai-explainability/trustyai-service-operator/api/tas/v1"
1010
"github.com/trustyai-explainability/trustyai-service-operator/controllers/utils"
1111
appsv1 "k8s.io/api/apps/v1"
1212
corev1 "k8s.io/api/core/v1"
@@ -40,7 +40,7 @@ func (r *TrustyAIServiceReconciler) GetDeploymentsByLabel(ctx context.Context, n
4040
return deployments.Items, nil
4141
}
4242

43-
func (r *TrustyAIServiceReconciler) patchEnvVarsForDeployments(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, deployments []appsv1.Deployment, envVarName string, url string, remove bool) (bool, error) {
43+
func (r *TrustyAIServiceReconciler) patchEnvVarsForDeployments(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService, deployments []appsv1.Deployment, envVarName string, url string, remove bool) (bool, error) {
4444
// Create volume and volume mount for this intance's TLS secrets
4545
certVolumes := TLSCertVolumes{}
4646
certVolumes.createFor(instance)
@@ -160,7 +160,7 @@ func (r *TrustyAIServiceReconciler) patchEnvVarsForDeployments(ctx context.Conte
160160
return true, nil
161161
}
162162

163-
func (r *TrustyAIServiceReconciler) patchEnvVarsByLabelForDeployments(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string, labelKey string, labelValue string, envVarName string, crName string, remove bool) (bool, error) {
163+
func (r *TrustyAIServiceReconciler) patchEnvVarsByLabelForDeployments(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService, namespace string, labelKey string, labelValue string, envVarName string, crName string, remove bool) (bool, error) {
164164
// Get all Deployments for the label
165165
deployments, err := r.GetDeploymentsByLabel(ctx, namespace, labelKey, labelValue)
166166
if err != nil {
@@ -213,7 +213,7 @@ func generateEnvVarValue(currentValue, newValue string, remove bool) string {
213213
return currentValue
214214
}
215215

216-
func (r *TrustyAIServiceReconciler) handleInferenceServices(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, namespace string, labelKey, labelValue, envVarName, crName string, remove bool) (bool, error) {
216+
func (r *TrustyAIServiceReconciler) handleInferenceServices(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService, namespace string, labelKey, labelValue, envVarName, crName string, remove bool) (bool, error) {
217217
var inferenceServices kservev1beta1.InferenceServiceList
218218

219219
if err := r.List(ctx, &inferenceServices, client.InNamespace(namespace)); err != nil {
@@ -274,7 +274,7 @@ func (r *TrustyAIServiceReconciler) handleInferenceServices(ctx context.Context,
274274
}
275275

276276
// patchKServe adds a TrustyAI service as an InferenceLogger to a KServe InferenceService
277-
func (r *TrustyAIServiceReconciler) patchKServe(ctx context.Context, instance *trustyaiopendatahubiov1alpha1.TrustyAIService, infService kservev1beta1.InferenceService, namespace string, crName string, remove bool, useHTTPS bool) error {
277+
func (r *TrustyAIServiceReconciler) patchKServe(ctx context.Context, instance *trustyaiopendatahubiov1.TrustyAIService, infService kservev1beta1.InferenceService, namespace string, crName string, remove bool, useHTTPS bool) error {
278278

279279
var url string
280280
if useHTTPS {

0 commit comments

Comments
 (0)