feat: change extensions from scripts to modules (#139)

Author: load1n9

Cargo.lock

@@ -7,7 +7,7 @@ authors = ["the Andromeda team"]
 edition = "2024"
 license = "Mozilla Public License 2.0"
 repository = "https://github.com/tryandromeda/andromeda"
-version = "0.1.0-draft35"
+version = "0.1.0-draft36"
 
 [workspace.dependencies]
 andromeda-core = { path = "core" }

Cargo.toml

@@ -6,7 +6,9 @@ use nova_vm::{
     ecmascript::{
         builtins::{Behaviour, BuiltinFunctionArgs, RegularFn, create_builtin_function},
         execution::Agent,
-        scripts_and_modules::script::{parse_script, script_evaluation},
+        scripts_and_modules::{
+            module::module_semantics::source_text_module_records::parse_module, script::HostDefined,
+        },
         types::{InternalMethods, IntoValue, Object, PropertyDescriptor, PropertyKey},
     },
     engine::context::{Bindable, GcScope},
@@ -57,32 +59,34 @@ impl Extension {
         andromeda_object: Object,
         gc: &mut GcScope<'_, '_>,
     ) {
-        for file in &self.files {
-            let source_text = nova_vm::ecmascript::types::String::from_str(agent, file, gc.nogc());
-            let script = match parse_script(
+        for (idx, file_source) in self.files.iter().enumerate() {
+            let specifier = format!("<ext:{}:{}>", self.name, idx);
+            let source_text =
+                nova_vm::ecmascript::types::String::from_str(agent, file_source, gc.nogc());
+
+            let module = match parse_module(
                 agent,
                 source_text,
                 agent.current_realm(gc.nogc()),
-                true,
-                None,
+                Some(std::rc::Rc::new(specifier.clone()) as HostDefined),
                 gc.nogc(),
             ) {
-                Ok(script) => script,
-                Err(diagnostics) => exit_with_parse_errors(diagnostics, "<runtime>", file),
+                Ok(module) => module,
+                Err(diagnostics) => exit_with_parse_errors(diagnostics, &specifier, file_source),
             };
-            let eval_result = script_evaluation(agent, script.unbind(), gc.reborrow()).unbind();
-            match eval_result {
-                Ok(_) => (),
-                Err(e) => {
-                    let error_value = e.value();
-                    let message = error_value
-                        .string_repr(agent, gc.reborrow())
-                        .as_str(agent)
-                        .unwrap_or("<non-string error>")
-                        .to_string();
-                    let err = AndromedaError::runtime_error(message);
-                    print_enhanced_error(&err);
-                }
+
+            let eval_result = agent
+                .run_parsed_module(module.unbind(), None, gc.reborrow())
+                .unbind();
+            if let Err(e) = eval_result {
+                let error_value = e.value();
+                let message = error_value
+                    .string_repr(agent, gc.reborrow())
+                    .as_str(agent)
+                    .unwrap_or("<non-string error>")
+                    .to_string();
+                let err = AndromedaError::runtime_error(message);
+                print_enhanced_error(&err);
             }
         }
         for op in &self.ops {

core/src/extension.rs

@@ -281,3 +281,5 @@ class BroadcastChannel {
     }, inspectOptions);
   }
 }
+
+globalThis.BroadcastChannel = BroadcastChannel;

runtime/src/ext/broadcast_channel/broadcast_channel.ts

@@ -52,3 +52,6 @@ function createImageBitmap(path: string): ImageBitmap {
   const height = __andromeda__.internal_image_bitmap_get_height(rid);
   return new ImageBitmap(rid, width, height);
 }
+
+globalThis.createImageBitmap = createImageBitmap;
+globalThis.ImageBitmap = ImageBitmap;

runtime/src/ext/canvas/image.ts

@@ -2,8 +2,6 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
-// deno-lint-ignore-file no-unused-vars
-
 /**
  * A OffscreenCanvas implementation
  */
@@ -419,3 +417,5 @@ class CanvasGradient {
     );
   }
 }
+
+globalThis.OffscreenCanvas = OffscreenCanvas;

runtime/src/ext/canvas/mod.ts

@@ -674,5 +674,5 @@ const andromedaConsole = {
   },
 };
 
-// Export the console object
+// // Export the console object
 globalThis.console = andromedaConsole;

runtime/src/ext/console/mod.ts

@@ -2,8 +2,6 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
-// deno-lint-ignore-file no-unused-vars
-
 // Web Crypto API implementation following W3C specification
 
 /**
@@ -416,3 +414,6 @@ const crypto = {
     return __andromeda__.internal_crypto_randomUUID();
   },
 };
+
+// @ts-ignore globalThis is not readonly
+globalThis.crypto = crypto;

runtime/src/ext/crypto/mod.ts

@@ -1,7 +1,6 @@
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at https://mozilla.org/MPL/2.0/.
-// deno-lint-ignore-file no-unused-vars
 
 /**
  * All plain number types for interfacing with foreign functions.
@@ -626,3 +625,14 @@ function dlopen<T extends ForeignLibraryInterface>(
 
   return new DynamicLibrary(libId, callableSymbols);
 }
+
+// @ts-ignore globalThis is not readonly
+globalThis.dlopen = dlopen;
+// @ts-ignore globalThis is not readonly
+globalThis.UnsafeCallback = UnsafeCallback;
+// @ts-ignore globalThis is not readonly
+globalThis.UnsafeFnPointer = UnsafeFnPointer;
+// @ts-ignore globalThis is not readonly
+globalThis.UnsafePointer = UnsafePointer;
+// @ts-ignore globalThis is not readonly
+globalThis.UnsafePointerView = UnsafePointerView;

runtime/src/ext/ffi/mod.ts

@@ -195,3 +195,6 @@ class Blob {
     return this.#blobId;
   }
 }
+
+// @ts-ignore globalThis is not readonly
+globalThis.Blob = Blob;