tests + cleanup

Author: Antoine de Chevigné

run/jobs/backfillOrbitMessageDeliveredLogs.js

@@ -10,6 +10,9 @@ module.exports = async (job) => {
     const data = job.data;
 
     const orbitConfig = await OrbitChainConfig.findByPk(data.orbitChainConfigId);
+    if (!orbitConfig)
+        throw new Error('OrbitChainConfig not found');
+
     const parentWorkspace = await orbitConfig.getParentWorkspace();
     const bridgeContract = orbitConfig.bridgeContract;
     let fromBlock = data.fromBlock;
@@ -39,21 +42,21 @@ module.exports = async (job) => {
     });
 
     const logs = await client.getFilterLogs({ filter });
+    const deposits = [];
     for (const log of logs) {
         if ([3, 7, 9, 12].includes(log.args.kind)) {
             logger.info(`Found deposit #${parseInt(log.args.messageIndex)}`)
-            await OrbitDeposit.bulkCreate([
-                {
-                    workspaceId: orbitConfig.workspaceId,
-                    l1Block: parseInt(log.blockNumber),
-                    l1TransactionHash: log.transactionHash,
-                    messageIndex: parseInt(log.args.messageIndex),
-                    timestamp: String(log.args.timestamp),
-                    sender: log.args.sender
-                }
-            ], { ignoreDuplicates: true });
+            deposits.push({
+                workspaceId: orbitConfig.workspaceId,
+                l1Block: parseInt(log.blockNumber),
+                l1TransactionHash: log.transactionHash,
+                messageIndex: parseInt(log.args.messageIndex),
+                timestamp: String(log.args.timestamp),
+                sender: log.args.sender
+            });
         }
     }
+    await OrbitDeposit.bulkCreate(deposits, { ignoreDuplicates: true });
 
     const newFromBlock = fromBlock - SCAN_RANGE;
     return enqueue('backfillOrbitMessageDeliveredLogs', `backfillOrbitMessageDeliveredLogs-${orbitConfig.id}-${newFromBlock}-${fromBlock - 2 * SCAN_RANGE}`, {

run/jobs/blockSync.js

@@ -50,8 +50,8 @@ module.exports = async job => {
     if (!workspace.explorer)
         return 'No active explorer for this workspace';
 
-    // if (!workspace.explorer.shouldSync)
-    //     return 'Sync is disabled';
+    if (!workspace.explorer.shouldSync)
+        return 'Sync is disabled';
 
     if (workspace.rpcHealthCheckEnabled && workspace.rpcHealthCheck && !workspace.rpcHealthCheck.isReachable)
         return 'RPC is not reachable';

run/jobs/checkOrbitMessageDeliveredLogs.js

@@ -16,6 +16,11 @@ module.exports = async () => {
     const newProcesses = [];
     const existingProcesses = [];
     for (const orbitConfig of orbitConfigs) {
+        // Additional safety check to ensure parentWorkspaceId is valid
+        if (!orbitConfig.parentWorkspaceId) {
+            continue;
+        }
+
         const pm2 = new PM2(getPm2Host(), getPm2Secret());
         const { data: existingProcess } = await pm2.find(`logListener-${orbitConfig.parentWorkspaceId}`);
 
@@ -24,7 +29,6 @@ module.exports = async () => {
             continue;
         }
 
-        console.log(`Listening address ${orbitConfig.bridgeContract} on ${orbitConfig.parentWorkspaceId}`);
         await pm2.startLogListener(`logListener-${orbitConfig.parentWorkspaceId}`,
             JSON.stringify({
                 parentWorkspaceId: orbitConfig.parentWorkspaceId,

run/tests/.cursor/rules/backend-tests.mdc

@@ -13,4 +13,5 @@ description: |
 - Assuming you're in the "run/" or "pm2-server" directory, run tests with `npm run test`. You can pass a file path as an argument to only run tests in this file.
 - All functions in run/lib/firebase.js are automatically mocked to a jest.fn(), you don't need to setup a mock again for those.
 - As a general rule, do not setup mocks for files that are under run/lib in a test file, they should have their own mocking file. You can create it if it doesn't exist. However, feel free to override the mocks using mockImplementation, mockResolvedValue, etc...based on individual tests. 
-- 500 are unexpected and thus shouldn't be tested, if you deem that a 500 scenario is likely to happen often enough so that it should be tested, fix the code so that it returns a 400, then test it.
+- 500 are unexpected and thus shouldn't be tested, if you deem that a 500 scenario is likely to happen often enough so that it should be tested, fix the code so that it returns a 400, then test it.
+- More generally, do not write tests for unhandled unexpected values, but try to handle it in the code and then write a test to make sure it's handled properly