Skip to content

Commit 99f6871

Browse files
authored
Merge pull request #3 from tryptz/claude/model-capability-improvement-ez4ups
fix: point CI and README at the real QuickJS repo, align CI NDK with build pin
2 parents 80a95bd + 38bb42a commit 99f6871

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
branches: [main]
66
pull_request:
77
branches: [main]
8+
workflow_dispatch:
89

910
jobs:
1011
lint:
@@ -31,16 +32,16 @@ jobs:
3132
distribution: temurin
3233
java-version: 17
3334

34-
- name: Set up NDK
35-
uses: nttld/setup-ndk@v1
36-
with:
37-
ndk-version: r27c
35+
# Must match ndkVersion / externalNativeBuild.cmake.version in
36+
# app/build.gradle.kts, otherwise AGP fails to resolve the NDK.
37+
- name: Install NDK and CMake
38+
run: echo y | sdkmanager "ndk;29.0.14206865" "cmake;3.22.1"
3839

3940
- name: Clone native dependencies
4041
run: |
4142
cd app/src/main/jni
4243
git clone --depth 1 https://github.com/ggml-org/llama.cpp.git llama_cpp
43-
git clone --depth 1 https://github.com/nicbarker/quickjs.git quickjs
44+
git clone --depth 1 https://github.com/bellard/quickjs.git quickjs
4445
4546
- uses: gradle/actions/setup-gradle@v4
4647
- name: Build debug APK

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,9 @@ cd app/src/main/jni
136136
# Clone llama.cpp
137137
git clone --depth 1 https://github.com/ggml-org/llama.cpp.git llama_cpp
138138

139-
# Clone QuickJS
140-
git clone --depth 1 https://github.com/nicbarker/quickjs.git quickjs
141-
# Or use bellard's: https://bellard.org/quickjs/
139+
# Clone QuickJS (official Bellard repo — the CMake build expects its
140+
# post-2024 layout: dtoa.c instead of libbf.c)
141+
git clone --depth 1 https://github.com/bellard/quickjs.git quickjs
142142
```
143143

144144
### Build

0 commit comments

Comments
 (0)