Skip to content

Commit 5794a26

Browse files
authored
Merge pull request #189 from tryretool/kenny/scale-jobs-runner
Option to scale jobsRunner and WF-backend resource from main
2 parents 7b3fdca + 97b471b commit 5794a26

File tree

5 files changed

+49
-5
lines changed

5 files changed

+49
-5
lines changed

charts/retool/Chart.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: retool
33
description: A Helm chart for Kubernetes
44
type: application
5-
version: 6.2.16
5+
version: 6.3.0
66
maintainers:
77
- name: Retool Engineering
88

charts/retool/templates/deployment_jobs.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,11 @@ spec:
179179
{{- end }}
180180
{{- end }}
181181
resources:
182+
{{- if .Values.jobRunner.resources }}
183+
{{ toYaml .Values.jobRunner.resources | indent 10 }}
184+
{{- else }}
182185
{{ toYaml .Values.resources | indent 10 }}
186+
{{- end }}
183187
{{- if regexMatch "^([0-9]+)\\.([0-9]+)\\.([0-9]+)" .Values.image.tag }}
184188
{{- if semverCompare ">=2.110.0-0" .Values.image.tag }}
185189
livenessProbe:

charts/retool/templates/deployment_workflows.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,11 @@ spec:
252252
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
253253
{{- end }}
254254
resources:
255+
{{- if .Values.workflows.backend.resources }}
256+
{{ toYaml .Values.workflows.backend.resources | indent 10 }}
257+
{{- else }}
255258
{{ toYaml .Values.resources | indent 10 }}
259+
{{- end }}
256260
volumeMounts:
257261
{{- range $configFile := (keys .Values.files) }}
258262
- name: {{ template "retool.name" $ }}

charts/retool/values.yaml

+20-2
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ extraVolumeMounts: []
238238

239239
extraVolumes: []
240240

241-
# These resource specifications apply to the main backend and workflows backend pods.
241+
# These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.
242242
resources:
243243
# If you have more than 1 replica, the minimum recommended resources configuration is as follows:
244244
# - cpu: 2048m
@@ -306,6 +306,15 @@ jobRunner:
306306
# will already launch a job runner pod
307307
# enabled: true
308308

309+
# If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods.
310+
# resources:
311+
# limits:
312+
# cpu: 4096m
313+
# memory: 8192Mi
314+
# requests:
315+
# cpu: 2048m
316+
# memory: 4096Mi
317+
309318
# Annotations for job runner pods
310319
annotations: {}
311320

@@ -346,6 +355,15 @@ workflows:
346355
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster
347356
replicaCount: 1
348357

358+
# If necessary, specify the resources to provision the workflows-backend pod separately from the main backend pods.
359+
# resources:
360+
# limits:
361+
# cpu: 4096m
362+
# memory: 8192Mi
363+
# requests:
364+
# cpu: 2048m
365+
# memory: 4096Mi
366+
349367
# Timeout for queries, in ms. This will set the timeout for workflows-related pods only
350368
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts
351369
# to .Values.config.dbConnectorTimeout
@@ -401,7 +419,7 @@ workflows:
401419

402420
# Resources for the workflow worker only - these are sane inputs that bias towards stability
403421
# Can adjust but may see OOM errors if memory too low for heavy workflow load
404-
# To make adjustments to workflows backend, use top level resources key.
422+
# To make adjustments to workflows backend, use workflows.backend.resources key.
405423
resources:
406424
limits:
407425
cpu: 2000m

values.yaml

+20-2
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ extraVolumeMounts: []
238238

239239
extraVolumes: []
240240

241-
# These resource specifications apply to the main backend and workflows backend pods.
241+
# These resource specifications will apply to the main backend, jobs-runner, dbconnector, and workflows-backend pods unless container specific resources are set.
242242
resources:
243243
# If you have more than 1 replica, the minimum recommended resources configuration is as follows:
244244
# - cpu: 2048m
@@ -306,6 +306,15 @@ jobRunner:
306306
# will already launch a job runner pod
307307
# enabled: true
308308

309+
# If necessary, specify the resources to provision the jobRunner pod separately from the main backend pods.
310+
# resources:
311+
# limits:
312+
# cpu: 4096m
313+
# memory: 8192Mi
314+
# requests:
315+
# cpu: 2048m
316+
# memory: 4096Mi
317+
309318
# Annotations for job runner pods
310319
annotations: {}
311320

@@ -346,6 +355,15 @@ workflows:
346355
# will launch 9 pods -- 4 workflow backend, 1 workflow workers, and 4 for temporal cluster
347356
replicaCount: 1
348357

358+
# If necessary, specify the resources to provision the workflows-backend pod separately from the main backend pods.
359+
# resources:
360+
# limits:
361+
# cpu: 4096m
362+
# memory: 8192Mi
363+
# requests:
364+
# cpu: 2048m
365+
# memory: 4096Mi
366+
349367
# Timeout for queries, in ms. This will set the timeout for workflows-related pods only
350368
# If this value is not set but config.dbConnectorTimeout is, we will set workflows pod timeouts
351369
# to .Values.config.dbConnectorTimeout
@@ -401,7 +419,7 @@ workflows:
401419

402420
# Resources for the workflow worker only - these are sane inputs that bias towards stability
403421
# Can adjust but may see OOM errors if memory too low for heavy workflow load
404-
# To make adjustments to workflows backend, use top level resources key.
422+
# To make adjustments to workflows backend, use workflows.backend.resources key.
405423
resources:
406424
limits:
407425
cpu: 2000m

0 commit comments

Comments
 (0)