Method call not detected as moved

[koppor]

Context: JabRef/jabref#13852

Task was to split up one long dialog into three tabs. Thus, functionality was moved around.

Example: In jabgui/src/main/java/org/jabref/gui/cleanup/CleanupSingleAction.java, there was a call

boolean confirmed = dialogService.showConfirmationDialogWithOptOutAndWait

This now appears in

jabgui/src/main/java/org/jabref/gui/cleanup/CleanupDialogViewModel.java

But this is not detected. Maybe too different?

Showing two windows:

http://127.0.0.1:6789/monaco-page/5 and http://127.0.0.1:6789/monaco-page/2 next to each other:

[tsantalis]

@koppor
I had already worked on a previous version of this PR.
It had some Split Class refactoring
org.jabref.gui.cleanup.CleanupPresetPanel split to [org.jabref.gui.cleanup.CleanupFileRelatedPanel, org.jabref.gui.cleanup.CleanupMultiFieldPanel]

But now it seems the PR changed again.

[tsantalis]

@koppor
If the code on the left is extracted and moved, there is no call on the right side to this extracted method.

The code seems to be inside method public void apply(CleanupTabSelection selectedTab) in CleanupDialogViewModel.java, but it is not clear how this method in being called now.

Do you have any hint to help me?

[tsantalis]

@koppor

I fixed what I thought was impossible to fix!