Skip to content

Don't log to the console unless specified. #201

Open
@saborrie

Description

@saborrie

It's not good practice for libraries to log directly to the console unless a consumer sets a verbosity setting to enable it.

E.g. this piece of code in dom-to-image.js:
(a non-fatal error of some stylesheets not working doesn't warrant an unsuppressible call to console.log)

try {
  util.asArray(sheet.cssRules || []).forEach(cssRules.push.bind(cssRules));
} catch (e) {
  console.log('Error while reading CSS rules from ' + sheet.href, e.toString());
}

There may be others places too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions