Use unique construct ids in the data integration stack (IT-4057) (Sage-Bionetworks-IT#87)

* Use unique construct ids in the data integration stack

* Fix consutrct prefixes

Author: tschaffter

openchallenges/data_integration_lambda.py

@@ -28,7 +28,7 @@ def __init__(self, scope: Construct, id: str) -> None:
     def _build_lambda_role(self) -> iam.Role:
         return iam.Role(
             self,
-            "LambdaRole",
+            f"{id}-LambdaRole",
             assumed_by=iam.ServicePrincipal("lambda.amazonaws.com"),
             managed_policies=[
                 iam.ManagedPolicy.from_aws_managed_policy_name(
@@ -51,7 +51,7 @@ def _build_lambda_function(self, role: iam.Role) -> lambda_.Function:
         """
         return lambda_.DockerImageFunction(
             self,
-            "LambdaFunction",
+            f"{id}-LambdaFunction",
             code=lambda_.DockerImageCode.from_image_asset(
                 # Directory relative to where you execute cdk deploy contains a
                 # Dockerfile with build instructions.

openchallenges/data_integration_stack.py

@@ -41,7 +41,7 @@ def __init__(
         """
         super().__init__(scope, id, **kwargs)
 
-        data_integration_lambda = DataIntegrationLambda(self, "data-integration-lambda")
+        data_integration_lambda = DataIntegrationLambda(self, f"{id}-lambda")
 
         target = scheduler_targets.LambdaInvoke(
             data_integration_lambda.lambda_function,
@@ -52,13 +52,13 @@ def __init__(
         # to this group the future)
         schedule_group = scheduler_alpha.Group(
             self,
-            "group",
-            group_name="schedule-group",
+            f"{id}-schedule-group",
+            group_name=f"{id}-schedule-group",
         )
 
         scheduler_alpha.Schedule(
             self,
-            "schedule",
+            f"{id}-schedule",
             schedule=props.schedule,
             target=target,
             group=schedule_group,