Fix empty footprinter models showing (#160)

MustafaMulla29 · web-flow · commit 4a5bde42acd8 · 2026-05-07T21:02:07.000+05:30
as fallback boxes in normal 3D
  renders
diff --git a/lib/converters/circuit-to-3d.ts b/lib/converters/circuit-to-3d.ts
@@ -520,8 +520,9 @@ export async function convertCircuitJsonTo3D(
       box.size = getBoundingBoxSize(box.mesh.boundingBox)
     }
 
-    // Only set color if mesh loading failed (fallback to simple box)
+    // Skip empty generated footprint models unless debug boxes are requested.
     if (!box.mesh) {
+      if (hasFootprinterModel && !showBoundingBoxes) continue
       box.color = componentColor
     }
 
diff --git a/tests/repro/__snapshots__/repro12-testpoint.snap.png b/tests/repro/__snapshots__/repro12-testpoint.snap.png
diff --git a/tests/repro/repro12-testpoint.test.tsx b/tests/repro/repro12-testpoint.test.tsx
@@ -28,7 +28,7 @@ test("repro12 testpoint 3d snapshot", async () => {
     textureResolution: 512,
   })
 
-  expect(scene.boxes).toHaveLength(7)
+  expect(scene.boxes).toHaveLength(1)
 
   const glb = await convertCircuitJsonToGltf(circuitJson, {
     format: "glb",

Original file line number	Diff line number	Diff line change
`@@ -520,8 +520,9 @@ export async function convertCircuitJsonTo3D(`
`520`	`520`	`box.size = getBoundingBoxSize(box.mesh.boundingBox)`
`521`	`521`	`}`
`522`	`522`
`523`		`- // Only set color if mesh loading failed (fallback to simple box)`
	`523`	`+ // Skip empty generated footprint models unless debug boxes are requested.`
`524`	`524`	`if (!box.mesh) {`
	`525`	`+ if (hasFootprinterModel && !showBoundingBoxes) continue`
`525`	`526`	`box.color = componentColor`
`526`	`527`	`}`
`527`	`528`