add the via route_type only once in the pcb_trace segment (#117)

Author: imrishabh18

lib/dsn-pcb/dsn-json-to-circuit-json/convert-dsn-session-to-circuit-json.ts

@@ -142,8 +142,10 @@ export function convertDsnSessionToCircuitJson(
         const fromLayer = connectingWires[0]?.layer || "top"
         const toLayer = connectingWires[1]?.layer || "bottom"
 
-        // Add via point to each trace that connects to it
-        sessionElements.forEach((element) => {
+        // Add via point to the first trace that connects to it (not all traces)
+        let viaAdded = false
+        for (const element of sessionElements) {
+          if (viaAdded) break
           if (element.type === "pcb_trace") {
             const trace = element as PcbTrace
             // Check all points in the route, not just the last one
@@ -158,11 +160,12 @@ export function convertDsnSessionToCircuitJson(
                   from_layer: fromLayer,
                   to_layer: toLayer,
                 })
+                viaAdded = true
                 break // Found the matching point, no need to continue checking
               }
             }
           }
-        })
+        }
 
         sessionElements.push({
           ...convertViaToPcbVia({

tests/repros/repro10-via.test.ts

@@ -36,12 +36,10 @@ test("Number of vias in the pcb_trace route should match the number of pcb_via e
     })
   })
 
-  // Each via point is counted twice (once for each layer)
-  routeViaPointsCount /= 2
-
   const outputPcbVias = circuitJsonFromSession.filter(
     (element) => element.type === "pcb_via",
   )
 
+  // Each via appears once in the route and once as a pcb_via element
   expect(routeViaPointsCount).toBe(outputPcbVias.length)
 })