Skip to content

Add route regionId and missing connectivity dependency#22

Closed
0hmX wants to merge 1 commit into
mainfrom
add-regionid-and-missing-dep
Closed

Add route regionId and missing connectivity dependency#22
0hmX wants to merge 1 commit into
mainfrom
add-regionid-and-missing-dep

Conversation

@0hmX

@0hmX 0hmX commented Jun 1, 2026

Copy link
Copy Markdown

Adds optional regionId support to the high-density route type and declares circuit-json-to-connectivity-map so @tscircuit/checks resolves during benchmark runs.\n\nDepends on high-density-a01 commit ac8f940, high-density-repair01 commit c80bd91, and high-density-repair02 commit 80cb5e7.\n\nCommit: e10d47f

@0hmX 0hmX requested a review from Abse2001 as a code owner June 1, 2026 06:00
@tscircuitbot

Copy link
Copy Markdown

Benchmark This PR

Run benchmarks by commenting on this PR:

/benchmark [benchmark.sh args...]
/benchmark [scenario-limit|all] --concurrency <n> --effort <n> --max-iterations <n>

Everything after /benchmark is forwarded directly to ./benchmark.sh.

Examples:

  • /benchmark -> run default DRC14 benchmark settings
  • /benchmark 10 -> run first 10 DRC14 samples
  • /benchmark all --concurrency 4 -> run all DRC14 samples with 4 workers
  • /benchmark --scenario-limit all --effort 2 -> run all samples with effort 2
  • /benchmark --scenario-limit 20 --max-iterations 100 -> run 20 samples with a max iteration override

Any PR whose title contains [BENCHMARK TEST] will automatically run the benchmark workflow on PR updates.

@Abse2001

Abse2001 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

/benchmark

@tscircuitbot

tscircuitbot commented Jun 1, 2026

Copy link
Copy Markdown

Benchmark Failed

Benchmark workflow ended with failure before completion.

Main Branch Results

Concurrency: 4
Effort: 1
Scenario limit used: 44

Metric Value
Samples 44
Succeeded 44
Failed 0
Improved 41
Clean 41
Initial DRC 76
Final DRC 3
DRC improvement 73
Total solve time 34.35s
Average solve time 781ms
Raw output
Running benchmark command: ./benchmark.sh
Starting DRC14 benchmark: samples=44 workers=4 effort=1
[sample] 4/44 circuit120 traces=70 drc=1->0 iterations=1 time=387.70ms
[sample] 1/44 circuit002 traces=43 drc=1->0 iterations=1 time=330.72ms
[sample] 2/44 circuit109 traces=63 drc=1->0 iterations=2 time=479.11ms
[sample] 6/44 circuit125 traces=37 drc=2->0 iterations=2 time=419.23ms
[sample] 3/44 circuit114 traces=65 drc=2->0 iterations=2 time=1160.97ms
[sample] 5/44 circuit123 traces=39 drc=1->0 iterations=2 time=512.44ms
[sample] 7/44 circuit143 traces=58 drc=1->0 iterations=1 time=710.81ms
[sample] 9/44 circuit158 traces=39 drc=1->0 iterations=1 time=413.02ms
[sample] 11/44 circuit184 traces=58 drc=1->0 iterations=1 time=396.31ms
[sample] 8/44 circuit151 traces=70 drc=3->0 iterations=1 time=966.93ms
[sample] 13/44 circuit187 traces=7 drc=1->0 iterations=1 time=34.90ms
[sample] 15/44 circuit197 traces=21 drc=0->0 iterations=1 time=71.49ms
[sample] 10/44 circuit178 traces=55 drc=1->1 iterations=2 time=1477.27ms
[sample] 12/44 circuit185 traces=49 drc=1->0 iterations=1 time=761.22ms
[sample] 17/44 circuit206 traces=36 drc=1->0 iterations=1 time=173.49ms
[sample] 16/44 circuit205 traces=43 drc=1->0 iterations=1 time=573.17ms
[sample] 18/44 circuit212 traces=50 drc=1->0 iterations=1 time=576.31ms
[sample] 14/44 circuit188 traces=51 drc=2->0 iterations=4 time=1438.12ms
[sample] 19/44 circuit216 traces=46 drc=2->0 iterations=1 time=845.96ms
[sample] 21/44 circuit222 traces=30 drc=1->1 iterations=3 time=614.06ms
[sample] 20/44 circuit219 traces=60 drc=2->0 iterations=4 time=897.76ms
[sample] 24/44 circuit230 traces=25 drc=1->0 iterations=1 time=65.03ms
[sample] 26/44 circuit232 traces=53 drc=2->0 iterations=1 time=681.26ms
[sample] 25/44 circuit231 traces=71 drc=3->0 iterations=1 time=969.84ms
[sample] 23/44 circuit225 traces=64 drc=3->0 iterations=1 time=1249.27ms
[sample] 29/44 circuit239 traces=43 drc=1->0 iterations=1 time=564.60ms
[sample] 28/44 circuit238 traces=62 drc=5->0 iterations=3 time=1062.33ms
[sample] 27/44 circuit237 traces=86 drc=3->0 iterations=1 time=1191.08ms
[sample] 30/44 circuit241 traces=47 drc=1->0 iterations=1 time=255.08ms
[sample] 32/44 circuit249 traces=28 drc=1->0 iterations=1 time=423.77ms
[sample] 33/44 circuit250 traces=63 drc=1->0 iterations=1 time=921.11ms
[sample] 31/44 circuit243 traces=56 drc=2->0 iterations=2 time=1312.60ms
[sample] 34/44 circuit253 traces=38 drc=1->0 iterations=1 time=191.64ms
[sample] 37/44 circuit268 traces=37 drc=2->0 iterations=1 time=196.47ms
[sample] 35/44 circuit255 traces=35 drc=1->0 iterations=1 time=451.49ms
[sample] 36/44 circuit261 traces=38 drc=1->0 iterations=1 time=248.36ms
[sample] 39/44 circuit276 traces=29 drc=1->0 iterations=2 time=338.85ms
[sample] 40/44 circuit285 traces=77 drc=1->0 iterations=2 time=512.67ms
[sample] 38/44 circuit270 traces=77 drc=3->0 iterations=4 time=1372.92ms
[sample] 41/44 circuit288 traces=55 drc=4->0 iterations=1 time=719.89ms
[sample] 22/44 circuit224 traces=67 drc=7->1 iterations=10 time=7436.65ms
[sample] 42/44 circuit292 traces=77 drc=1->0 iterations=1 time=574.67ms
[sample] 43/44 circuit293 traces=68 drc=1->0 iterations=1 time=169.19ms
[sample] 44/44 circuit294 traces=41 drc=3->0 iterations=3 time=196.17ms

Dataset DRC14 benchmark summary
+--------------------+------------+
| Metric             |      Value |
+--------------------+------------+
| Samples            |         44 |
| Succeeded          |         44 |
| Failed             |          0 |
| Improved           |         41 |
| Clean              |         41 |
| Initial DRC        |         76 |
| Final DRC          |          3 |
| DRC improvement    |         73 |
| Total solve time   | 34345.91ms |
| Average solve time |   780.59ms |
+--------------------+------------+

Samples with remaining DRC
+--------+------------+-------------+-----------+------------+-----------+
| Sample | ID         | Initial DRC | Final DRC | Iterations | Time      |
+--------+------------+-------------+-----------+------------+-----------+
| 10     | circuit178 | 1           | 1         | 2          | 1477.27ms |
| 21     | circuit222 | 1           | 1         | 3          | 614.06ms  |
| 22     | circuit224 | 7           | 1         | 10         | 7436.65ms |
+--------+------------+-------------+-----------+------------+-----------+
Wrote benchmark report to benchmark-result.json
PR Results

Summary table unavailable.

Raw output
(benchmark output unavailable)

Workflow: View run
Artifact: https://github.com/tscircuit/high-density-repair03/actions/runs/26767475684

@0hmX

0hmX commented Jun 1, 2026

Copy link
Copy Markdown
Author

I think this one is not needed

@0hmX 0hmX closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants