Match the fake with prod version (#1115)

* Match the fake with prod version

* format

Author: imrishabh18

bun-tests/fake-snippets-api/routes/order_quotes/create.test.ts

@@ -1,69 +1,33 @@
 import { getTestServer } from "bun-tests/fake-snippets-api/fixtures/get-test-server"
 import { test, expect } from "bun:test"
 
-test("create order_quote with only circuit_json (✅)", async () => {
-  const {
-    axios,
-    seed: { order },
-  } = await getTestServer()
-
-  const response = await axios.post("/api/order_quotes/create", {
-    vendor_name: "jlcpcb",
-    circuit_json: order.circuit_json,
-  })
+test("create order_quote with only package_release_id (✅)", async () => {
+  const { axios, jane_axios } = await getTestServer()
 
-  expect(response.status).toBe(200)
-  expect(response.data.order_quote_id).toBeDefined()
-})
+  const pkg = await jane_axios
+    .post("/api/packages/create", {
+      name: "jane/test-package",
+    })
+    .then((res) => res.data.package)
 
-test("create order_quote with only package_release_id (✅)", async () => {
-  const {
-    axios,
-    seed: { packageRelease },
-  } = await getTestServer()
+  const packageRelease = await jane_axios
+    .post("/api/package_releases/create", {
+      package_id: pkg.package_id,
+      version: "1.0.0",
+      is_latest: true,
+    })
+    .then((res) => res.data.package_release)
 
+  await jane_axios.post(`/api/package_files/create`, {
+    package_release_id: packageRelease.package_release_id,
+    file_path: "/dist/index.js",
+    content_text: "console.log('Hello, world!');",
+  })
   const response = await axios.post("/api/order_quotes/create", {
     vendor_name: "jlcpcb",
-    package_release_id: packageRelease!.package_release_id,
+    package_release_id: packageRelease.package_release_id,
   })
 
   expect(response.status).toBe(200)
   expect(response.data.order_quote_id).toBeDefined()
 })
-
-test("create order_quote with both circuit_json and package_release_id (✅)", async () => {
-  const {
-    axios,
-    seed: { order, packageRelease },
-  } = await getTestServer()
-
-  const response = await axios
-    .post("/api/order_quotes/create", {
-      vendor_name: "jlcpcb",
-      circuit_json: order.circuit_json,
-      package_release_id: packageRelease!.package_release_id,
-    })
-    .catch((error) => error) // Capture response even on error
-
-  // Expecting backend to fail with 400
-  expect(response?.status).toBe(400)
-  expect(response?.data.message).toContain(
-    "You must provide either circuit_json or package_release_id, but not both.",
-  )
-})
-
-test("create order_quote with neither circuit_json nor package_release_id (✅)", async () => {
-  const { axios } = await getTestServer()
-
-  const response = await axios
-    .post("/api/order_quotes/create", {
-      vendor_name: "jlcpcb",
-    })
-    .catch((error) => error) // Capture response even on error
-
-  // Expecting backend to fail with 400
-  expect(response?.status).toBe(400)
-  expect(response?.data.message).toContain(
-    "You must provide either circuit_json or package_release_id.",
-  )
-})

fake-snippets-api/routes/api/order_quotes/create.ts

@@ -4,29 +4,10 @@ import { z } from "zod"
 export default withRouteSpec({
   methods: ["POST"],
   auth: "session",
-  jsonBody: z
-    .object({
-      package_release_id: z.string().optional(),
-      circuit_json: z.any().optional(),
-      vendor_name: z.string(),
-    })
-    .superRefine((data, ctx) => {
-      if (data.circuit_json && data.package_release_id) {
-        ctx.addIssue({
-          code: z.ZodIssueCode.custom,
-          message:
-            "You must provide either circuit_json or package_release_id, but not both.",
-        })
-      }
-      if (!data.circuit_json && !data.package_release_id) {
-        ctx.addIssue({
-          code: z.ZodIssueCode.custom,
-          message:
-            "You must provide either circuit_json or package_release_id.",
-        })
-      }
-    }),
-
+  jsonBody: z.object({
+    package_release_id: z.string(),
+    vendor_name: z.literal("jlcpcb"),
+  }),
   jsonResponse: z.object({
     order_quote_id: z.string().optional(),
     error: z
@@ -37,22 +18,34 @@ export default withRouteSpec({
       .optional(),
   }),
 })(async (req, ctx) => {
-  const { package_release_id, vendor_name, circuit_json } = req.jsonBody
+  const { package_release_id, vendor_name } = req.jsonBody
+
+  // check package release exists
+  const packageRelease = ctx.db.getPackageReleaseById(package_release_id)
+  if (!packageRelease) {
+    return ctx.json(
+      {
+        error: {
+          error_code: "package_release_not_found",
+          message: "Package release not found",
+        },
+      },
+      { status: 404 },
+    )
+  }
 
-  if (package_release_id) {
-    // check package release exists
-    const packageRelease = ctx.db.getPackageReleaseById(package_release_id)
-    if (!packageRelease) {
-      return ctx.json(
-        {
-          error: {
-            error_code: "package_release_not_found",
-            message: "Package release not found",
-          },
+  const packageReleaseFiles =
+    ctx.db.getPackageFilesByReleaseId(package_release_id)
+  if (packageReleaseFiles.length === 0) {
+    return ctx.json(
+      {
+        error: {
+          error_code: "package_release_files_not_found",
+          message: "Package release files not found",
         },
-        { status: 404 },
-      )
-    }
+      },
+      { status: 404 },
+    )
   }
 
   const orderQuoteId = ctx.db.addOrderQuote({

fake-snippets-api/routes/api/order_quotes/get.ts

@@ -9,21 +9,18 @@ export default withRouteSpec({
     order_quote_id: z.string(),
   }),
   jsonResponse: z.object({
-    order_quote: orderQuoteSchema.optional(),
-    error: z.string().optional(),
+    order_quote: orderQuoteSchema,
   }),
 })(async (req, ctx) => {
   const { order_quote_id } = req.commonParams
 
   const orderQuote = ctx.db.getOrderQuoteById(order_quote_id)
 
   if (!orderQuote) {
-    return ctx.json(
-      {
-        error: "Order quote not found",
-      },
-      { status: 404 },
-    )
+    return ctx.error(404, {
+      error_code: "order_quote_not_found",
+      message: "Order quote not found",
+    })
   }
 
   return ctx.json({