Support editing the subdomain to point to the latest release using the tag (#2796)

* Support for tag

* fake data

* find the is_latest

Author: imrishabh18

fake-snippets-api/lib/db/seed.ts

@@ -2381,6 +2381,12 @@ exports.TestComponent = TestComponent;
     transpilation_error: null,
   })
 
+  db.addPackageDomain({
+    points_to: "package_release",
+    package_release_id: glbModelReleaseId,
+    fully_qualified_domain_name: "custom-3d-model.tscircuit.app",
+  })
+
   // Update the package to link to the release
   db.updatePackage(glbModelPackage.package_id, {
     latest_package_release_id: glbModelReleaseId,

fake-snippets-api/routes/api/package_domains/update.ts

@@ -10,6 +10,18 @@ export default withRouteSpec({
     package_domain_id: z.string(),
     default_main_component_path: z.string().nullable().optional(),
     fully_qualified_domain_name: z.string().nullable().optional(),
+    points_to: z
+      .enum([
+        "package_release",
+        "package_build",
+        "package_release_with_tag",
+        "package",
+      ])
+      .optional(),
+    package_release_id: z.string().optional(),
+    package_build_id: z.string().optional(),
+    package_id: z.string().optional(),
+    tag: z.string().optional(),
   }),
   jsonResponse: z.object({
     ok: z.boolean(),
@@ -20,6 +32,11 @@ export default withRouteSpec({
     package_domain_id,
     default_main_component_path,
     fully_qualified_domain_name,
+    points_to,
+    package_release_id,
+    package_build_id,
+    package_id,
+    tag,
   } = req.jsonBody
 
   const existingDomain = ctx.db.getPackageDomainById(package_domain_id)
@@ -51,6 +68,70 @@ export default withRouteSpec({
     }
   }
 
+  // Validate the points_to constraint if points_to is being updated
+  if (points_to !== undefined) {
+    if (points_to === "package_release") {
+      if (!package_release_id) {
+        return ctx.error(400, {
+          error_code: "missing_package_release_id",
+          message:
+            "package_release_id is required when points_to is 'package_release'",
+        })
+      }
+      if (package_build_id || tag || package_id) {
+        return ctx.error(400, {
+          error_code: "invalid_params",
+          message:
+            "package_build_id, tag, and package_id must not be provided when points_to is 'package_release'",
+        })
+      }
+    } else if (points_to === "package_build") {
+      if (!package_build_id) {
+        return ctx.error(400, {
+          error_code: "missing_package_build_id",
+          message:
+            "package_build_id is required when points_to is 'package_build'",
+        })
+      }
+      if (package_release_id || tag || package_id) {
+        return ctx.error(400, {
+          error_code: "invalid_params",
+          message:
+            "package_release_id, tag, and package_id must not be provided when points_to is 'package_build'",
+        })
+      }
+    } else if (points_to === "package_release_with_tag") {
+      if (!package_release_id || !tag) {
+        return ctx.error(400, {
+          error_code: "missing_params",
+          message:
+            "package_release_id and tag are required when points_to is 'package_release_with_tag'",
+        })
+      }
+      if (package_build_id || package_id) {
+        return ctx.error(400, {
+          error_code: "invalid_params",
+          message:
+            "package_build_id and package_id must not be provided when points_to is 'package_release_with_tag'",
+        })
+      }
+    } else if (points_to === "package") {
+      if (!package_id) {
+        return ctx.error(400, {
+          error_code: "missing_package_id",
+          message: "package_id is required when points_to is 'package'",
+        })
+      }
+      if (package_release_id || package_build_id || tag) {
+        return ctx.error(400, {
+          error_code: "invalid_params",
+          message:
+            "package_release_id, package_build_id, and tag must not be provided when points_to is 'package'",
+        })
+      }
+    }
+  }
+
   const updateValues: Record<string, unknown> = {}
 
   if (default_main_component_path !== undefined) {
@@ -61,6 +142,15 @@ export default withRouteSpec({
     updateValues.fully_qualified_domain_name = fully_qualified_domain_name
   }
 
+  if (points_to !== undefined) {
+    updateValues.points_to = points_to
+    // Clear all pointer fields and set the appropriate ones
+    updateValues.package_release_id = package_release_id ?? null
+    updateValues.package_build_id = package_build_id ?? null
+    updateValues.package_id = package_id ?? null
+    updateValues.tag = tag ?? null
+  }
+
   if (Object.keys(updateValues).length === 0) {
     return ctx.json({
       ok: true,

src/components/dialogs/edit-subdomain-dialog.tsx

@@ -37,19 +37,31 @@ export const EditSubdomainDialog = ({
   packageId,
   currentPointsTo,
   currentPackageReleaseId,
+  currentTag,
 }: {
   open: boolean
   onOpenChange: (open: boolean) => void
   packageDomainId: string
   currentFqdn: string
   targetInfo?: { badgeLabel: string; description: string } | null
   packageId?: string | null
-  currentPointsTo?: "package" | "package_release" | string | null
+  currentPointsTo?:
+    | "package"
+    | "package_release"
+    | "package_release_with_tag"
+    | string
+    | null
   currentPackageReleaseId?: string | null
+  currentTag?: string | null
 }) => {
   const [subdomain, setSubdomain] = useState(extractSubdomain(currentFqdn))
+  const isCurrentlyLatest =
+    currentPointsTo === "package" ||
+    (currentPointsTo === "package_release_with_tag" && currentTag === "latest")
   const [targetType, setTargetType] = useState<"latest" | "release">(
-    currentPointsTo === "package_release" ? "release" : "latest",
+    isCurrentlyLatest || currentPointsTo !== "package_release"
+      ? "latest"
+      : "release",
   )
   const [selectedReleaseId, setSelectedReleaseId] = useState(
     currentPackageReleaseId || "",
@@ -59,16 +71,23 @@ export const EditSubdomainDialog = ({
   const { data: releases = [] } = usePackageReleasesByPackageId(
     packageId ?? null,
   )
+  const latestRelease = releases.find((r) => r.is_latest) ?? releases[0]
 
   useEffect(() => {
     if (open) {
       setSubdomain(extractSubdomain(currentFqdn))
+      const isLatest =
+        currentPointsTo === "package" ||
+        (currentPointsTo === "package_release_with_tag" &&
+          currentTag === "latest")
       setTargetType(
-        currentPointsTo === "package_release" ? "release" : "latest",
+        !isLatest && currentPointsTo === "package_release"
+          ? "release"
+          : "latest",
       )
       setSelectedReleaseId(currentPackageReleaseId || "")
     }
-  }, [open, currentFqdn, currentPointsTo, currentPackageReleaseId])
+  }, [open, currentFqdn, currentPointsTo, currentPackageReleaseId, currentTag])
 
   const releaseOptions = useMemo(
     () =>
@@ -91,13 +110,18 @@ export const EditSubdomainDialog = ({
   const domainChanged = newFqdn !== currentFqdn
   const targetChanged =
     targetType === "latest"
-      ? currentPointsTo !== "package"
+      ? !(
+          currentPointsTo === "package_release_with_tag" &&
+          currentTag === "latest"
+        )
       : currentPointsTo !== "package_release" ||
         currentPackageReleaseId !== selectedReleaseId
 
   const hasChanged = domainChanged || targetChanged
   const isDomainValid = normalizedSubdomain.length > 0
-  const isTargetValid = targetType === "latest" || Boolean(selectedReleaseId)
+  const isTargetValid =
+    (targetType === "latest" && Boolean(latestRelease)) ||
+    (targetType === "release" && Boolean(selectedReleaseId))
 
   const handleSave = () => {
     if (!isDomainValid || !isTargetValid || !hasChanged) return
@@ -108,9 +132,9 @@ export const EditSubdomainDialog = ({
         fully_qualified_domain_name: newFqdn,
         ...(targetType === "latest"
           ? {
-              points_to: "package" as const,
-              package_id: packageId || null,
-              package_release_id: null,
+              points_to: "package_release_with_tag" as const,
+              tag: "latest",
+              package_release_id: latestRelease?.package_release_id ?? null,
             }
           : {
               points_to: "package_release" as const,

src/components/package-settings/PackageDomainsList.tsx

@@ -172,6 +172,7 @@ export function PackageDomainsList({
           packageId={packageId}
           currentPointsTo={editingDomain.points_to}
           currentPackageReleaseId={editingDomain.package_release_id}
+          currentTag={editingDomain.tag}
         />
       )}
 

src/components/preview/ReleaseDeploymentDetails.tsx

@@ -459,6 +459,7 @@ export function ReleaseDeploymentDetails({
           packageId={pkg.package_id}
           currentPointsTo={editingDomain.points_to}
           currentPackageReleaseId={editingDomain.package_release_id}
+          currentTag={editingDomain.tag}
         />
       )}
     </div>

src/hooks/use-package-domains.ts

@@ -156,9 +156,15 @@ export const useUpdatePackageDomain = () => {
     mutationFn: async (params: {
       package_domain_id: string
       fully_qualified_domain_name?: string | null
-      points_to?: "package_release" | "package"
+      points_to?:
+        | "package_release"
+        | "package_build"
+        | "package_release_with_tag"
+        | "package"
       package_release_id?: string | null
+      package_build_id?: string | null
       package_id?: string | null
+      tag?: string | null
     }) => {
       const { data } = await axios.post("/package_domains/update", params)
       return data.package_domain as PublicPackageDomain