Modify /get endpoint to have include_logs as params, remove the eval dependency (#1208)

Author: imrishabh18

bun-tests/fake-snippets-api/fixtures/get-circuit-json.ts

@@ -116,3 +116,41 @@ test("POST /api/package_releases/get - should return circuit_json_build_error if
   expect(responseBody.ok).toBe(true)
   expect(responseBody.package_release.circuit_json_build_error).toBe(null)
 })
+
+test("POST /api/package_releases/get?include_logs=true - should return include_logs if it exists", async () => {
+  const { axios } = await getTestServer()
+
+  // First create a package with valid name format
+  const packageResponse = await axios.post("/api/packages/create", {
+    name: "@test/package-4",
+    description: "Another test package",
+  })
+  expect(packageResponse.status).toBe(200)
+  const createdPackage = packageResponse.data.package
+
+  // Create a package release with a circuit_json_build_error
+  const releaseResponse = await axios.post("/api/package_releases/create", {
+    package_id: createdPackage.package_id,
+    version: "1.0.0",
+    is_latest: true,
+  })
+  expect(releaseResponse.status).toBe(200)
+  const createdRelease = releaseResponse.data.package_release
+
+  // Get the release
+  const getResponse = await axios.post(
+    "/api/package_releases/get",
+    {
+      package_release_id: createdRelease.package_release_id,
+    },
+    {
+      params: { include_logs: true },
+    },
+  )
+  expect(getResponse.status).toBe(200)
+
+  const responseBody = getResponse.data
+  expect(responseBody.ok).toBe(true)
+  expect(responseBody.package_release.transpilation_logs).toEqual([])
+  expect(responseBody.package_release.circuit_json_build_logs).toEqual([])
+})

bun-tests/fake-snippets-api/routes/package_releases/get.test.ts

@@ -1,6 +1,5 @@
 import { getTestServer } from "bun-tests/fake-snippets-api/fixtures/get-test-server"
 import { expect, test } from "bun:test"
-import { generateCircuitJson } from "bun-tests/fake-snippets-api/fixtures/get-circuit-json"
 import md5 from "md5"
 test("get schematic svg of a package", async () => {
   const { axios, db } = await getTestServer()
@@ -18,16 +17,20 @@ test("get schematic svg of a package", async () => {
     is_latest: true,
   })
 
-  const circuit_json = await generateCircuitJson({
-    code: `
-import { A555Timer } from "@tsci/seveibar.a555timer"
-
-export default () => (
-  <board width="10mm" height="10mm">
-    <A555Timer name="U1" />
-  </board>
-)`.trim(),
-  })
+  const circuit_json = [
+    {
+      type: "pcb_board",
+      pcb_board_id: "pcb_board_0",
+      center: {
+        x: 0,
+        y: 0,
+      },
+      thickness: 1.4,
+      num_layers: 4,
+      width: 30,
+      height: 30,
+    },
+  ]
   // create a package file
   const pkg_file = await axios.post("/api/package_files/create", {
     package_release_id: pkg_release.data.package_release.package_release_id,

bun-tests/fake-snippets-api/routes/packages/images.test.ts

@@ -2,12 +2,23 @@ import * as ZT from "fake-snippets-api/lib/db/schema"
 
 export const publicMapPackageRelease = (
   internal_package_release: ZT.PackageRelease,
+  options: {
+    include_logs?: boolean
+  } = {
+    include_logs: false,
+  },
 ): ZT.PackageRelease => {
   return {
     ...internal_package_release,
     created_at: internal_package_release.created_at,
     circuit_json_build_error_last_updated_at:
       internal_package_release.circuit_json_build_error_last_updated_at,
     circuit_json_build_error: internal_package_release.circuit_json_build_error,
+    transpilation_logs: options.include_logs
+      ? internal_package_release.transpilation_logs
+      : [],
+    circuit_json_build_logs: options.include_logs
+      ? internal_package_release.circuit_json_build_logs
+      : [],
   }
 }

bun.lock

@@ -6,6 +6,9 @@ import { z } from "zod"
 export default withRouteSpec({
   methods: ["POST"],
   auth: "none",
+  commonParams: z.object({
+    include_logs: z.boolean().optional().default(false),
+  }),
   jsonBody: z.object({
     package_release_id: z.string().optional(),
     package_name_with_version: z.string().optional(),
@@ -115,6 +118,8 @@ export default withRouteSpec({
 
   return ctx.json({
     ok: true,
-    package_release: publicMapPackageRelease(foundRelease),
+    package_release: publicMapPackageRelease(foundRelease, {
+      include_logs: req.commonParams?.include_logs,
+    }),
   })
 })

fake-snippets-api/lib/public-mapping/public-map-package-release.ts

@@ -70,7 +70,6 @@
     "@radix-ui/react-toggle": "^1.1.0",
     "@radix-ui/react-toggle-group": "^1.1.0",
     "@radix-ui/react-tooltip": "^1.1.2",
-    "@tscircuit/eval": "^0.0.198",
     "@tscircuit/footprinter": "^0.0.169",
     "@tscircuit/layout": "^0.0.29",
     "@tscircuit/math-utils": "^0.0.10",