Potential solution for #111

Author: ThenTech

.gitattributes

@@ -0,0 +1 @@
+* eol=lf

.gitignore

@@ -1,4 +1,5 @@
 nob
 nob.old
 nob.exe
-build/
+build/
+**/*.obj

nob.h

@@ -99,7 +99,9 @@
 #ifndef NOB_H_
 #define NOB_H_
 #ifdef _WIN32
-#define _CRT_SECURE_NO_WARNINGS (1)
+#   ifndef _CRT_SECURE_NO_WARNINGS
+#       define _CRT_SECURE_NO_WARNINGS (1)
+#   endif
 #endif
 
 #ifndef NOBDEF
@@ -840,6 +842,26 @@ NOBDEF void nob__go_rebuild_urself(int argc, char **argv, const char *source_pat
     if (rebuild_is_needed < 0) exit(1); // error
     if (!rebuild_is_needed) {           // no rebuild is needed
         NOB_FREE(source_paths.items);
+        
+#ifdef NOB_EXPERIMENTAL_DELETE_OLD
+#   ifdef _WIN32
+        if (argc <= 0) return;
+        
+        // Check if our parent nob wants to be deleted
+        char *argument = nob_shift(argv, argc);
+        if (strcmp("--nob-delete-old", argument) == 0) {
+            // Wait a bit so the old nob exits
+            // Better would be to WaitForSingleObject on the handle of the old nob, but we cannot pass its handle?
+            Sleep(10);
+            argument = nob_shift(argv, argc);
+            nob_delete_file(argument);
+        } else {
+            // Restore the arguments
+            argc++; argv--;
+        }
+#   endif
+#endif // NOB_EXPERIMENTAL_DELETE_OLD
+
         return;
     }
 
@@ -855,13 +877,26 @@ NOBDEF void nob__go_rebuild_urself(int argc, char **argv, const char *source_pat
         exit(1);
     }
 #ifdef NOB_EXPERIMENTAL_DELETE_OLD
+#   ifndef _WIN32
     // TODO: this is an experimental behavior behind a compilation flag.
     // Once it is confirmed that it does not cause much problems on both POSIX and Windows
     // we may turn it on by default.
     nob_delete_file(old_binary_path);
+#   endif
 #endif // NOB_EXPERIMENTAL_DELETE_OLD
 
     nob_cmd_append(&cmd, binary_path);
+    
+#ifdef NOB_EXPERIMENTAL_DELETE_OLD
+#   ifdef _WIN32
+    // On Windows, tell the new nob to delete us, always pass as the second argument
+    // so we can consume it before any user defined arguments.
+    nob_cmd_append(&cmd, "--nob-delete-old", old_binary_path);
+    Nob_Procs procs = {0}; // Small leak until we exit the current nob
+    opt.async = &procs;
+#   endif
+#endif // NOB_EXPERIMENTAL_DELETE_OLD
+
     nob_da_append_many(&cmd, argv, argc);
     if (!nob_cmd_run_opt(&cmd, opt)) exit(1);
     exit(0);
@@ -1860,7 +1895,7 @@ NOBDEF bool nob_rename(const char *old_path, const char *new_path)
 {
     nob_log(NOB_INFO, "renaming %s -> %s", old_path, new_path);
 #ifdef _WIN32
-    if (!MoveFileEx(old_path, new_path, MOVEFILE_REPLACE_EXISTING)) {
+    if (!MoveFileEx(old_path, new_path, MOVEFILE_REPLACE_EXISTING | MOVEFILE_WRITE_THROUGH)) {
         nob_log(NOB_ERROR, "could not rename %s to %s: %s", old_path, new_path, nob_win32_error_message(GetLastError()));
         return false;
     }