-
Notifications
You must be signed in to change notification settings - Fork 262
Description
Since #90 was resolved (thanks again!), I can import earned badges into a backpack like Badgr's. I noticed that each badge shows up as coming from a different issuer, while the badges I earned are all from Python for Everyone.
It looks like the Badge Issuer URI is indeed unique, because it includes the assertion ID (the encoded badge information):
Line 105 in e991a25
| $badge_issuer = $CFG->wwwroot . "/badges/badge-issuer.php?id=". $encrypted; |
and in
Line 126 in e991a25
| $badge_issuer = $CFG->wwwroot . "/badges/badge-issuer.php?id=". $encrypted; |
I then realised that the line
Line 104 in e991a25
| $badge_url = $CFG->wwwroot . "/badges/badge-info.php?id=". $encrypted; |
makes each badge class, i.e. the type of badge, unique as well – which makes comparing badges by their URIs impossible.
Would it be possible to define a single badge issuer URI per installation and one badge class URI for each defined badge in lessons.json? I think it is likely that one installation is supported by a singe issuer and it would reduce some of the code complexity as well.