oauth-mcp-proxy/validation_test.go at main · tuannvm/oauth-mcp-proxy · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
package oauth

import (
	"strings"
	"testing"
)

func TestValidateIssuerURL(t *testing.T) {
	tests := []struct {
		name      string
		issuer    string
		expectErr bool
		errMsg    string
	}{
		{
			name:      "Valid HTTPS issuer",
			issuer:    "https://accounts.example.com",
			expectErr: false,
		},
		{
			name:      "Valid HTTPS issuer with path",
			issuer:    "https://accounts.example.com/oidc/",
			expectErr: false,
		},
		{
			name:      "Valid HTTP localhost",
			issuer:    "http://localhost:8080",
			expectErr: false,
		},
		{
			name:      "Valid HTTP 127.0.0.1",
			issuer:    "http://127.0.0.1:9000",
			expectErr: false,
		},
		{
			name:      "Empty issuer",
			issuer:    "",
			expectErr: true,
			errMsg:    "cannot be empty",
		},
		{
			name:      "Invalid URL format",
			issuer:    "not-a-valid-url",
			expectErr: true,
			errMsg:    "must use http or https",
		},
		{
			name:      "Non-HTTPS non-localhost",
			issuer:    "http://example.com",
			expectErr: true,
			errMsg:    "must use HTTPS",
		},
		{
			name:      "Invalid scheme",
			issuer:    "ftp://example.com",
			expectErr: true,
			errMsg:    "must use http or https",
		},
		{
			name:      "Missing host",
			issuer:    "https://",
			expectErr: true,
			errMsg:    "must have a host",
		},
		{
			name:      "Raw IP address",
			issuer:    "https://192.168.1.1",
			expectErr: true,
			errMsg:    "should not be a raw IP",
		},
		{
			name:      "Path without trailing slash",
			issuer:    "https://example.com/oidc",
			expectErr: false,
		},
		{
			name:      "Suspicious pattern with dots",
			issuer:    "https://..evil.com",
			expectErr: true,
			errMsg:    "invalid patterns",
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := ValidateIssuerURL(tt.issuer)
			if tt.expectErr {
				if err == nil {
					t.Errorf("Expected error but got none")
				} else if tt.errMsg != "" && !strings.Contains(err.Error(), tt.errMsg) {
					t.Errorf("Expected error containing %q, got %q", tt.errMsg, err.Error())
				}
			} else {
				if err != nil {
					t.Errorf("Unexpected error: %v", err)
				}
			}
		})
	}
}

func TestValidateRedirectURI(t *testing.T) {
	tests := []struct {
		name        string
		redirectURI string
		expectErr   bool
		errMsg      string
	}{
		{
			name:        "Valid HTTPS redirect",
			redirectURI: "https://client.example.com/callback",
			expectErr:   false,
		},
		{
			name:        "Valid HTTP localhost",
			redirectURI: "http://localhost:3000/oauth/callback",
			expectErr:   false,
		},
		{
			name:        "Valid HTTP 127.0.0.1",
			redirectURI: "http://127.0.0.1:8080/callback",
			expectErr:   false,
		},
		{
			name:        "Empty redirect URI",
			redirectURI: "",
			expectErr:   true,
			errMsg:      "cannot be empty",
		},
		{
			name:        "Invalid URL format",
			redirectURI: "not-a-url",
			expectErr:   true,
			errMsg:      "must use http or https",
		},
		{
			name:        "Non-HTTPS non-localhost",
			redirectURI: "http://example.com/callback",
			expectErr:   true,
			errMsg:      "must use HTTPS",
		},
		{
			name:        "Contains fragment",
			redirectURI: "https://example.com/callback#fragment",
			expectErr:   true,
			errMsg:      "must not contain a fragment",
		},
		{
			name:        "Suspicious hostname pattern",
			redirectURI: "https://..evil.com/callback",
			expectErr:   true,
			errMsg:      "invalid patterns",
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := ValidateRedirectURI(tt.redirectURI)
			if tt.expectErr {
				if err == nil {
					t.Errorf("Expected error but got none")
				} else if tt.errMsg != "" && !strings.Contains(err.Error(), tt.errMsg) {
					t.Errorf("Expected error containing %q, got %q", tt.errMsg, err.Error())
				}
			} else {
				if err != nil {
					t.Errorf("Unexpected error: %v", err)
				}
			}
		})
	}
}