Remove dead code, fix out-of-bounds bug in SET BPM handlers

- Remove unused SliceManager::createDefaultSlice()
- Remove unused WaveformCache::getVisibleStart/getVisibleLen, localize members
- Remove unused muteHead/muteTail variables in VoicePool bungee processing
- Fix potential out-of-bounds array access in SET BPM popup callbacks
- Make bars[] arrays const, getPreviewVoiceIndex() static

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: tucktuckg00se

project/src/audio/LazyChopEngine.h

@@ -11,7 +11,7 @@ class LazyChopEngine
     void stop (VoicePool& voicePool, SliceManager& sliceMgr);
     void onNote (int note, VoicePool& voicePool, SliceManager& sliceMgr);
 
-    int getPreviewVoiceIndex() const { return VoicePool::kMaxVoices - 1; }
+    static int getPreviewVoiceIndex() { return VoicePool::kMaxVoices - 1; }
 
 private:
     void startPreview (VoicePool& voicePool, int fromPos);

project/src/audio/SliceManager.cpp

@@ -101,20 +101,6 @@ void SliceManager::clearAll()
     rebuildMidiMap();
 }
 
-void SliceManager::createDefaultSlice (int sampleLen)
-{
-    if (sampleLen <= 0)
-        return;
-
-    // Reset all slices
-    numSlices = 0;
-    for (auto& s : slices)
-        s.active = false;
-
-    createSlice (0, sampleLen);
-    selectedSlice = 0;
-}
-
 void SliceManager::rebuildMidiMap()
 {
     midiMap.fill (-1);

project/src/audio/SliceManager.h

@@ -12,7 +12,6 @@ class SliceManager
     int  createSlice (int start, int end);
     void deleteSlice (int idx);
     void clearAll();
-    void createDefaultSlice (int sampleLen);
     void rebuildMidiMap();
     int  midiNoteToSlice (int note) const;
 

project/src/audio/VoicePool.cpp

@@ -331,12 +331,6 @@ static void fillBungeeBlock (Voice& v, const SampleData& sample)
     for (int i = 0; i < numFrames; ++i)
     {
         double pos = inputChunk.begin + i;
-        int muteHead = 0, muteTail = 0;
-
-        if (pos < v.startSample)
-            muteHead = std::max (muteHead, (int)(v.startSample - inputChunk.begin));
-        if (pos >= v.endSample)
-            muteTail = std::max (muteTail, (int)(inputChunk.end - v.endSample));
 
         float sL = 0.0f, sR = 0.0f;
         if (pos >= v.startSample && pos < v.endSample)

project/src/ui/HeaderBar.cpp

@@ -475,8 +475,8 @@ void HeaderBar::showSetBpmPopup (bool forSampleDefault)
 
     menu.showMenuAsync (juce::PopupMenu::Options().withTargetComponent (this),
         [this, forSampleDefault] (int result) {
-            if (result <= 0) return;
-            float bars[] = { 0.0f, 16.0f, 8.0f, 4.0f, 2.0f, 1.0f, 0.5f, 0.25f, 0.125f, 0.0625f };
+            if (result <= 0 || result > 9) return;
+            const float bars[] = { 0.0f, 16.0f, 8.0f, 4.0f, 2.0f, 1.0f, 0.5f, 0.25f, 0.125f, 0.0625f };
 
             // Determine start/end from selected slice or full sample
             int startS = 0;

project/src/ui/SliceControlBar.cpp

@@ -700,8 +700,8 @@ void SliceControlBar::showSetBpmPopup()
 
     menu.showMenuAsync (juce::PopupMenu::Options().withTargetComponent (this),
         [this] (int result) {
-            if (result <= 0) return;
-            float bars[] = { 0.0f, 16.0f, 8.0f, 4.0f, 2.0f, 1.0f, 0.5f, 0.25f, 0.125f, 0.0625f };
+            if (result <= 0 || result > 9) return;
+            const float bars[] = { 0.0f, 16.0f, 8.0f, 4.0f, 2.0f, 1.0f, 0.5f, 0.25f, 0.125f, 0.0625f };
 
             IntersectProcessor::Command cmd;
             cmd.type = IntersectProcessor::CmdStretch;

project/src/ui/WaveformCache.cpp

@@ -11,8 +11,8 @@ void WaveformCache::rebuild (const juce::AudioBuffer<float>& buffer, int numFram
         return;
     }
 
-    visibleLen = (int) (numFrames / zoom);
-    visibleStart = (int) (scroll * (numFrames - visibleLen));
+    int visibleLen = (int) (numFrames / zoom);
+    int visibleStart = (int) (scroll * (numFrames - visibleLen));
     visibleStart = std::max (0, std::min (visibleStart, numFrames - visibleLen));
 
     peaks.resize ((size_t) widthPixels);

project/src/ui/WaveformCache.h

@@ -13,11 +13,6 @@ class WaveformCache
     const std::vector<Peak>& getPeaks() const { return peaks; }
     int getNumPeaks() const { return (int) peaks.size(); }
 
-    int getVisibleStart() const { return visibleStart; }
-    int getVisibleLen() const { return visibleLen; }
-
 private:
     std::vector<Peak> peaks;
-    int visibleStart = 0;
-    int visibleLen   = 0;
 };