v0.8.2: Fix null pointer crash on sample load, remove unused theme colours

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: tucktuckg00se

README.md

@@ -103,30 +103,6 @@ To create a custom theme:
 4. Place the file in the themes folder listed above
 5. Restart the plugin — your theme will appear in the theme selector (right-click the header bar)
 
-**Theme properties:**
-
-| Key | Purpose |
-|-----|---------|
-| `background` | Window background |
-| `waveformBg` | Waveform area background |
-| `darkBar` | Slice control bar / action panel background |
-| `header` | Header bar background |
-| `foreground` | Primary text colour |
-| `gridLine` | Waveform grid lines |
-| `separator` | Horizontal separator lines |
-| `waveform` | Waveform draw colour |
-| `sliceRegion` | Slice region fill |
-| `sliceRegionSelected` | Selected slice region fill |
-| `selectionOverlay` | Selected slice translucent overlay |
-| `accent` | Accent colour (labels, highlights) |
-| `lockActive` | Locked/overridden parameter indicator |
-| `lockInactive` | Unlocked/inherited parameter indicator |
-| `button` | Button background |
-| `buttonHover` | Button hover background |
-| `slice1`–`slice16` | Slice colour palette (assigned to new slices in order) |
-
-Any missing key falls back to the dark theme default. Lines starting with `#` are comments.
-
 ## Install
 
 Download the latest release zip for your platform from the [Releases](https://github.com/tucktuckg00se/INTERSECT/releases) page and extract it.

src/audio/SampleData.cpp

@@ -77,6 +77,8 @@ float SampleData::getInterpolatedSample (double pos, int channel) const
         return 0.0f;
 
     auto* data = buffer.getReadPointer (channel);
+    if (data == nullptr)
+        return 0.0f;
     return data[ipos] + (data[ipos + 1] - data[ipos]) * frac;
 }
 
@@ -94,9 +96,15 @@ void SampleData::buildMipmaps()
         return;
     }
 
+    if (buffer.getNumChannels() < 1)
+        return;
+
     const float* dataL = buffer.getReadPointer (0);
     const float* dataR = buffer.getNumChannels() > 1 ? buffer.getReadPointer (1) : dataL;
 
+    if (dataL == nullptr)
+        return;
+
     static constexpr int kBlockSizes[kNumMipmapLevels] = { 64, 512, 4096 };
 
     for (int level = 0; level < kNumMipmapLevels; ++level)

src/ui/ThemeData.h

@@ -11,8 +11,6 @@ struct ThemeData
     juce::Colour foreground;
     juce::Colour header;
     juce::Colour waveform;
-    juce::Colour sliceRegion;
-    juce::Colour sliceRegionSelected;
     juce::Colour selectionOverlay;
     juce::Colour lockActive;
     juce::Colour lockInactive;
@@ -34,8 +32,6 @@ struct ThemeData
         t.foreground    = juce::Colour (0xFFCCD0D8);
         t.header    = juce::Colour (0xFF0D0D14);
         t.waveform = juce::Colour::fromFloatRGBA (0.70f, 0.78f, 0.85f, 1.0f);
-        t.sliceRegion     = juce::Colour (0xFF2A2A35);
-        t.sliceRegionSelected  = juce::Colour (0xFF3A3A50);
         t.selectionOverlay = juce::Colour::fromFloatRGBA (0.25f, 0.35f, 0.55f, 1.0f);
         t.lockActive      = juce::Colour::fromFloatRGBA (0.90f, 0.35f, 0.22f, 1.0f);
         t.lockInactive       = juce::Colour::fromFloatRGBA (0.30f, 0.30f, 0.34f, 1.0f);
@@ -73,8 +69,6 @@ struct ThemeData
         t.foreground    = juce::Colour (0xFF1A1A2E);
         t.header    = juce::Colour (0xFFE0E0EC);
         t.waveform = juce::Colour (0xFF2A4060);
-        t.sliceRegion     = juce::Colour (0xFFD0D0DD);
-        t.sliceRegionSelected  = juce::Colour (0xFFB8B8CC);
         t.selectionOverlay = juce::Colour (0xFF8090B8);
         t.lockActive      = juce::Colour (0xFFCC4422);
         t.lockInactive       = juce::Colour (0xFF9999A8);
@@ -136,8 +130,6 @@ struct ThemeData
             else if (key == "foreground")    t.foreground = parseHex (val);
             else if (key == "header")    t.header = parseHex (val);
             else if (key == "waveform") t.waveform = parseHex (val);
-            else if (key == "sliceRegion")     t.sliceRegion = parseHex (val);
-            else if (key == "sliceRegionSelected")  t.sliceRegionSelected = parseHex (val);
             else if (key == "selectionOverlay") t.selectionOverlay = parseHex (val);
             else if (key == "lockActive")      t.lockActive = parseHex (val);
             else if (key == "lockInactive")       t.lockInactive = parseHex (val);
@@ -171,8 +163,6 @@ struct ThemeData
         s << "foreground: " << colourToHex (foreground) << "\n";
         s << "header: " << colourToHex (header) << "\n";
         s << "waveform: " << colourToHex (waveform) << "\n";
-        s << "sliceRegion: " << colourToHex (sliceRegion) << "\n";
-        s << "sliceRegionSelected: " << colourToHex (sliceRegionSelected) << "\n";
         s << "selectionOverlay: " << colourToHex (selectionOverlay) << "\n";
         s << "lockActive: " << colourToHex (lockActive) << "\n";
         s << "lockInactive: " << colourToHex (lockInactive) << "\n";

src/ui/WaveformCache.cpp

@@ -19,9 +19,21 @@ void WaveformCache::rebuild (const juce::AudioBuffer<float>& buffer,
     peaks.resize ((size_t) widthPixels);
     float samplesPerPixel = (float) visibleLen / (float) widthPixels;
 
+    if (buffer.getNumChannels() < 1)
+    {
+        peaks.clear();
+        return;
+    }
+
     const float* dataL = buffer.getReadPointer (0);
     const float* dataR = buffer.getNumChannels() > 1 ? buffer.getReadPointer (1) : dataL;
 
+    if (dataL == nullptr)
+    {
+        peaks.clear();
+        return;
+    }
+
     if (samplesPerPixel < 1.0f)
     {
         // Sub-sample zoom: interpolate at exact fractional positions

themes/dark.intersectstyle

@@ -25,8 +25,6 @@ separator: 33333f           # horizontal separator lines
 
 # Waveform & slices
 waveform: b2c6d8            # waveform draw colour
-sliceRegion: 2a2a35         # slice region fill
-sliceRegionSelected: 3a3a50 # selected slice region fill
 selectionOverlay: 3f598c    # selected slice translucent overlay
 
 # Controls

themes/light.intersectstyle

@@ -25,8 +25,6 @@ separator: c0c0cc           # horizontal separator lines
 
 # Waveform & slices
 waveform: 2a4060            # waveform draw colour
-sliceRegion: d0d0dd         # slice region fill
-sliceRegionSelected: b8b8cc # selected slice region fill
 selectionOverlay: 8090b8    # selected slice translucent overlay
 
 # Controls