fix: encapsulate added_traces

Author: hwalinga

source/active_learning/algorithms/ldot.cpp

@@ -98,10 +98,10 @@ void ldot_algorithm::proc_counter_record(inputdata& id, const sul_response& rec,
 
 bool ldot_algorithm::add_trace(inputdata& id, const sul_response& r) {
     int pk = r.GET_ID();
-    if (my_sul->added_traces.contains(pk)) {
+    if (my_sul->contains_uid(pk)) {
         return false;
     }
-    my_sul->added_traces.insert(pk);
+    my_sul->insert_uid(pk);
 
     LOG_S(1) << "pk:" << r.GET_ID() << " " << r.GET_INT() << " " << r.GET_INT_VEC();
 

source/active_learning/oracle/sqldb_sul_random_oracle.cpp

@@ -31,7 +31,7 @@ sqldb_sul_random_oracle::equivalence_query(state_merger* merger) {
         std::vector<int> possible_ids;
 
         for (int pk = 0; pk <= max_pk; pk++) {
-            if (!my_sqldb_sul->added_traces.contains(pk))
+            if (!my_sqldb_sul->contains_uid(pk))
                 possible_ids.push_back(pk);
         }
         std::shuffle(possible_ids.begin(), possible_ids.end(), RNG);

source/active_learning/system_under_learning/sqldb_sul.h

@@ -23,6 +23,9 @@ class sqldb_sul : public sul_base {
     psql::db& my_sqldb;
     std::unordered_set<int> added_traces;
 
+    std::pair<std::unordered_set<int>::iterator, bool> insert_uid(int x) { return added_traces.insert(x); };
+    bool contains_uid(int x) { return added_traces.contains(x); };
+
     explicit sqldb_sul(psql::db& db) : my_sqldb(db){};
 
     void pre(inputdata& id) override;