Skip to content

Commit 7948f0d

Browse files
committed
Merge branch 'hotfix/fix-doc'
2 parents dfd28d6 + 5483a3d commit 7948f0d

File tree

2 files changed

+47
-14
lines changed

2 files changed

+47
-14
lines changed

README.md

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ Under macOS, it's super easy, we suggest using [Homebrew](http://brew.sh/):
4747
Under Linux (at least Ubuntu), CGAL has to be compiled because apt-get doesn't give you a version with Eigen.
4848
Thus, in a nutshell,
4949

50-
1. download CGAL code
51-
1. install Eigen: `$ sudo apt-get install libeigen3-dev`
52-
1. compile CGAL by first activating the Eigen option in the CMake: `$ cmake . -DWITH_Eigen3=ON` or use [cmake-gui](https://cmake.org/runningcmake/) and activate it (option is called `WITH_Eigen3`)
53-
1. `export CGAL_DIR=/path/to/CGAL-4.1x` which will tell your shell to use that version of CGAL (thus more version of CGAL can be installed on the same computer; see that [handy manual](https://github.com/CGAL/cgal/wiki/Branch-Build)
50+
1. download [latest CGAL code](https://github.com/CGAL/cgal/releases)
51+
1. install Eigen library: `$ sudo apt-get install libeigen3-dev`
52+
1. compile CGAL by first activating the Eigen option in the CMake (`$ cmake . -DWITH_Eigen3=ON`), or use [cmake-gui](https://cmake.org/runningcmake/) and activate it (option is called `WITH_Eigen3`)
53+
1. `export CGAL_DIR=/path/to/CGAL-4.1x` which will tell your shell to use that version of CGAL (thus more version of CGAL can be installed on the same computer; see that [handy manual](https://github.com/CGAL/cgal/wiki/Branch-Build))
5454

5555
To compile and run val3dity (from the val3dity folder):
5656

@@ -62,7 +62,13 @@ To compile and run val3dity (from the val3dity folder):
6262

6363
The summary of the validation is reported, and you should see that `cube.json` contains one valid primitive.
6464

65-
To see all the options:
65+
To verify that everything went fine during the compilation, run the unit tests (from the root folder of val3dity; must use Python3):
66+
67+
$ python3 -m pytest --runfull
68+
69+
You shouldn't get any errors
70+
71+
Finally, to see all the options possible:
6672

6773
$ ./val3dity --help
6874

docs/install.rst

Lines changed: 36 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,31 @@ macOS & Linux
88

99
We provide the source code that you need to compile with CMake.
1010

11-
To compile val3dity yourself, first install the following free libraries:
1211

13-
1. `CGAL <http://www.cgal.org>`_
14-
2. `GEOS <http://trac.osgeo.org/geos/)>`_
15-
3. `CMake <http://www.cmake.org>`_
12+
To compile val3dity yourself, you first need to install the following free libraries:
1613

17-
Under Mac we suggest using `Homebrew <http://brew.sh/>`_:
14+
1. `CGAL v4.10+ <http://www.cgal.org>`_ (<v4.10 will compile and run, but wrong results for one test (error 405))
15+
2. *watch out*: CGAL needs to be compiled with the `Eigen library <http://eigen.tuxfamily.org>`_
16+
3. `GEOS <http://trac.osgeo.org/geos/>`_
17+
4. `CMake <http://www.cmake.org>`_
18+
19+
Under macOS, it's super easy, we suggest using `Homebrew <http://brew.sh/>`_:
1820

1921
.. code-block:: bash
2022
21-
$ brew install cmake
22-
$ brew install cgal
23-
$ brew install geos
23+
$ brew install cgal --with-eigen
24+
$ brew install cmake
25+
$ brew install geos
26+
27+
Under Linux (at least Ubuntu), CGAL has to be compiled because apt-get doesn't give you a version with Eigen.
28+
Thus, in a nutshell,
2429

25-
Afterwards navigate to the folder with val3dity and run:
30+
1. download `latest CGAL code <https://github.com/CGAL/cgal/releases>`_
31+
2. install Eigen library: ``$ sudo apt-get install libeigen3-dev``
32+
3. compile CGAL by first activating the Eigen option in the CMake (``$ cmake . -DWITH_Eigen3=ON``), or use `cmake-gui <https://cmake.org/runningcmake/>`_ and activate it (option is called ``WITH_Eigen3``)
33+
4. ``export CGAL_DIR=/path/to/CGAL-4.1x`` which will tell your shell to use that version of CGAL (thus more version of CGAL can be installed on the same computer; see that `handy manual <https://github.com/CGAL/cgal/wiki/Branch-Build>`_)
34+
35+
To compile and run val3dity (from the val3dity folder):
2636

2737
.. code-block:: bash
2838
@@ -32,6 +42,23 @@ Afterwards navigate to the folder with val3dity and run:
3242
$ make
3343
$ ./val3dity ../data/cityjson/cube.json
3444
45+
The summary of the validation is reported, and you should see that `cube.json` contains one valid primitive.
46+
47+
To verify that everything went fine during the compilation, run the unit tests (from the root folder of val3dity; must use Python3):
48+
49+
.. code-block:: bash
50+
51+
$ python3 -m pytest --runfull
52+
53+
You shouldn't get any errors
54+
55+
56+
Finally, to see all the options possible:
57+
58+
.. code-block:: bash
59+
60+
$ ./val3dity --help
61+
3562
3663
Windows
3764
-------

0 commit comments

Comments
 (0)