Skip to content
This repository was archived by the owner on Mar 29, 2022. It is now read-only.
This repository was archived by the owner on Mar 29, 2022. It is now read-only.

Context Manager for Python Bindings #127

@corepointer

Description

@corepointer

I would prefer some other way to shutdown the server than shutdown. Fist of all a check is missing since we only start a subprocess if no SystemDS instance is running yet, secondly if we need a explicit shutdown it makes sense to also have an explicit start. As I have already suggested in my PR it would make sense to use a ContextManager (See https://book.pythontips.com/en/latest/context_managers.html). We should make sure that we are happy with our decision since it will likely stay for longer, I hoped that we find a way to automatically shutdown the java server process on exit of the python program, but a ContextManager would also be a good idea.

Originally posted by @kev-inn in #125 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions