Run Validator & ExpreInterpreter also on Initializers in Architectural State

[PhilippvK]

Branch: develop2 (Ref: 700e16a)

Input (1):

    architectural_state {
        register unsigned<XLEN> RES_ADDR = -1;
    }

Expected Error(s) (1):

• Implicit signed -> unsigned conversion?
• Implicit extend/truncate (depending on XLEN)?

Output Diff (1):

-cp.code() += "((RV64IMACFD*)cpu)->RES_ADDR = -1ULL;\n";  // correct, expected
+cp.code() += "((RV64IMACFD*)cpu)->RES_ADDR = -1LL;\n";   // technically correct, but assuming that RES_ADDR is unsigned

Input (2):

    architectural_state {
        register unsigned<XLEN> RES_ADDR = (unsigned<XLEN>)(signed<XLEN>)(-1);
    }

Error (2):

• NotImplementedError: No visit method implemented for type list in ExprInterpreterVisitor
  => Should the Expression Interpreter also work on the initialization statement inside the architectural state? I guess yes?

Output Diff (2): /

[PhilippvK]

@jokap11 Any thoughts?

[jokap11]

Yeah I think the Validator should work on the InitList aswell.
I think you are missing here just a function for the IniitializerListContext:
https://github.com/tum-ei-eda/M2-ISA-R/blob/develop2/m2isar/frontends/coredsl2/behavior_model_builder.py#L186
Is the validator really integrated into the AST Creator?

[PhilippvK]

Is the validator really integrated into the AST Creator?

Nope, it just came to my mind that the validator currently only runs on the behavior.

The issue above is just a lack of handling constant initializers which aren’t just literals. The expression intereter is used here to extract the actual constant value of the expression.