Skip to content

Feature Request: Add ExecAction to config(map) #35

Description

@kgunjikar

As a part of injection for sidecars I want to be able to call a preStop hook , so we can cleanup before exit.

ConfigMap Change.

imagePullPolicy: IfNotPresent
lifecycle:
preStop:
exec: ["/bin/bash", "-c", "/opt/bin/prestop"]

E1104 19:09:48.504599 1 main.go:132] error reconciling configmaps: error getting ConfigMaps from API: error parsing ConfigMap sidecar-test item test1 into injection config: e rror unmarshaling JSON: json: cannot unmarshal array into Go struct field Handler.exec of type v1.ExecAction

I guess we will have to add to InjectionConfig structure

Version Deets

  • Kubernetes Version: 1.15.3
  • k8s-sidecar-injector Version: Top of Tree.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions