refactor(runner-providers): centralize shared runner contracts (github-aws-runners#5248)

## Description

- Define the provider-neutral `RunnerType`, `RunnerInfo`,
`ListRunnerFilters`, and `CreateRunnerResult` contracts in
runner-provider core.
- Use one `RunnerInfo` shape across control-plane and EC2, with `id`,
`githubRunnerId`, and required `owner` and `type` fields.
- Keep EC2-specific inputs and the EC2 status-filter extension in
`runners.d.ts`.
- Consolidate control-plane type re-exports in `scale-runners/types.ts`
and remove the redundant scale-up and scale-down provider type shims.
- Update the existing tests in place without adding or removing test
cases.

### Compatibility note

This PR intentionally normalizes the exported `listEC2Runners` result
fields from `instanceId`/`runnerId` to `id`/`githubRunnerId` and removes
the legacy core type aliases. This differs from the compatibility
approach initially described in github-aws-runners#5247 and is included explicitly for
review.

## Test Plan

- `cd lambdas && NX_DAEMON=false yarn test` (all 8 projects passed)
- Control-plane suite: 14 test files / 326 tests passed
- Runner-provider suite: 10 test files / 270 tests passed
- Focused scale-down contract, EC2 listing, and pool tests passed after
the final type tightening
- ESLint and Prettier passed for control-plane and runner-providers
- Exact test-title inventory: 276 before and after, with no additions or
removals
- `git diff --check`

Local TypeScript build validation remains blocked by the installed
`@aws-sdk/client-ec2` declarations missing exports used throughout the
existing EC2 sources; the same environment issue affects untouched code.

## Related Issues

Closes github-aws-runners#5247

Stacked on github-aws-runners#5246

Author: edersonbrilhante

.github/workflows/codeql.yml

@@ -4,7 +4,6 @@ on:
   push:
     branches: [ "main", "develop", "v1" ]
   pull_request:
-    branches: [ "main", "develop", "v1" ]
     paths-ignore:
       - '**/*.md'
   schedule:

.github/workflows/lambda.yml

@@ -2,8 +2,6 @@ name: Build lambdas
 
 on:
   pull_request:
-    branches:
-      - main
     paths:
       - 'lambdas/**'
       - '.github/workflows/lambda.yml'

.github/workflows/ovs.yml

@@ -1,7 +1,6 @@
 name: OSV-Scanner
 on:
   pull_request:
-    branches: [main]
   merge_group:
     branches: [main]
 

lambdas/functions/control-plane/src/pool/pool.test.ts

@@ -64,25 +64,25 @@ const MINIMUM_TIME_RUNNING = 15;
 
 const ec2InstancesRegistered = [
   {
-    instanceId: 'i-1-idle',
+    id: 'i-1-idle',
     launchTime: new Date(),
     type: 'Org',
     owner: ORG,
   },
   {
-    instanceId: 'i-2-busy',
+    id: 'i-2-busy',
     launchTime: new Date(),
     type: 'Org',
     owner: ORG,
   },
   {
-    instanceId: 'i-3-offline',
+    id: 'i-3-offline',
     launchTime: new Date(),
     type: 'Org',
     owner: ORG,
   },
   {
-    instanceId: 'i-4-idle-older-than-minimum-time-running',
+    id: 'i-4-idle-older-than-minimum-time-running',
     launchTime: moment(new Date())
       .subtract(MINIMUM_TIME_RUNNING + 3, 'minutes')
       .toDate(),
@@ -258,15 +258,15 @@ describe('Test simple pool.', () => {
       mockListRunners.mockImplementation(async () => [
         ...ec2InstancesRegistered,
         {
-          instanceId: 'i-4-still-booting',
+          id: 'i-4-still-booting',
           launchTime: moment(new Date())
             .subtract(MINIMUM_TIME_RUNNING - 3, 'minutes')
             .toDate(),
           type: 'Org',
           owner: ORG,
         },
         {
-          instanceId: 'i-5-orphan',
+          id: 'i-5-orphan',
           launchTime: moment(new Date())
             .subtract(MINIMUM_TIME_RUNNING + 3, 'minutes')
             .toDate(),
@@ -289,15 +289,15 @@ describe('Test simple pool.', () => {
       mockListRunners.mockImplementation(async () => [
         ...ec2InstancesRegistered,
         {
-          instanceId: 'i-4-still-booting',
+          id: 'i-4-still-booting',
           launchTime: moment(new Date())
             .subtract(MINIMUM_TIME_RUNNING - 3, 'minutes')
             .toDate(),
           type: 'Org',
           owner: ORG,
         },
         {
-          instanceId: 'i-5-orphan',
+          id: 'i-5-orphan',
           launchTime: moment(new Date())
             .subtract(MINIMUM_TIME_RUNNING + 3, 'minutes')
             .toDate(),
@@ -386,13 +386,13 @@ describe('Test simple pool.', () => {
       mockListRunners.mockImplementation(async () => [
         ...ec2InstancesRegistered,
         {
-          instanceId: 'i-5-idle',
+          id: 'i-5-idle',
           launchTime: new Date(),
           type: 'Org',
           owner: ORG,
         },
         {
-          instanceId: 'i-6-idle',
+          id: 'i-6-idle',
           launchTime: new Date(),
           type: 'Org',
           owner: ORG,

lambdas/functions/control-plane/src/scale-runners/scale-down-contract.test.ts

@@ -5,7 +5,7 @@ import { providerTypes } from '../test/runner-provider-contracts/provider-types'
 import { defineScaleDownContractTests } from '../test/runner-provider-contracts/scale-down';
 import { controlPlaneProviderRegistry } from '../control-plane-providers';
 import { scaleDown } from './scale-down';
-import type { ScaleDownRunnerProvider } from './scale-down-provider';
+import type { ScaleDownRunnerProvider } from './types';
 
 const mockedResolveCapability = vi.spyOn(controlPlaneProviderRegistry, 'capability');
 

lambdas/functions/control-plane/src/scale-runners/scale-down-provider.ts

@@ -7,7 +7,7 @@ import { controlPlaneProviderRegistry } from '../control-plane-providers';
 import * as ghAuth from '../github/auth';
 import { githubCache } from './cache';
 import { newestFirstStrategy, oldestFirstStrategy, scaleDown } from './scale-down';
-import type { RunnerInfo, ScaleDownRunnerProvider } from './scale-down-provider';
+import type { RunnerInfo, RunnerType, ScaleDownRunnerProvider } from './types';
 
 vi.mock('../github/auth', () => ({
   createGithubAppAuth: vi.fn(),
@@ -72,25 +72,25 @@ describe('When runners are sorted', () => {
       id: '1',
       launchTime: moment(new Date()).subtract(1, 'minute').toDate(),
       owner: 'owner',
-      type: 'type',
+      type: 'Org',
     },
     {
       id: '3',
       launchTime: moment(new Date()).subtract(3, 'minute').toDate(),
       owner: 'owner',
-      type: 'type',
+      type: 'Org',
     },
     {
       id: '2',
       launchTime: moment(new Date()).subtract(2, 'minute').toDate(),
       owner: 'owner',
-      type: 'type',
+      type: 'Org',
     },
     {
       id: '0',
       launchTime: moment(new Date()).subtract(0, 'minute').toDate(),
       owner: 'owner',
-      type: 'type',
+      type: 'Org',
     },
   ];
 
@@ -117,13 +117,13 @@ describe('When runners are sorted', () => {
       id: '4',
       launchTime: same,
       owner: 'owner',
-      type: 'type',
+      type: 'Org',
     });
     runnersTest.push({
       id: '5',
       launchTime: same,
       owner: 'owner',
-      type: 'type',
+      type: 'Org',
     });
     runnersTest.sort(oldestFirstStrategy);
     expect(runnersTest[3].launchTime).not.toEqual(same);
@@ -142,19 +142,19 @@ describe('When runners are sorted', () => {
         id: '0',
         launchTime: undefined,
         owner: 'owner',
-        type: 'type',
+        type: 'Org',
       },
       {
         id: '1',
         launchTime: moment(new Date()).subtract(3, 'minute').toDate(),
         owner: 'owner',
-        type: 'type',
+        type: 'Org',
       },
       {
         id: '0',
         launchTime: undefined,
         owner: 'owner',
-        type: 'type',
+        type: 'Org',
       },
     ];
     runnersTest.sort(oldestFirstStrategy);
@@ -266,7 +266,6 @@ describe('Scale down runners', () => {
       }
     });
 
-    type RunnerType = 'Repo' | 'Org';
     const runnerTypes: RunnerType[] = ['Org', 'Repo'];
     describe.each(runnerTypes)('For %s runners.', (type) => {
       it(`Should terminate runner without idle config ${type} runners.`, async () => {
@@ -729,7 +728,7 @@ function mockGitHubRunners(runners: RunnerTestItem[]) {
 
 function createRunnerTestData(
   name: string,
-  type: 'Org' | 'Repo',
+  type: RunnerType,
   minutesLaunchedAgo: number,
   registered: boolean,
   orphan: boolean,

lambdas/functions/control-plane/src/scale-runners/scale-down.test.ts

@@ -11,7 +11,7 @@ import { GhRunners, githubCache } from './cache';
 import { ScalingDownConfigList, getEvictionStrategy, getIdleRunnerCount } from './scale-down-config';
 import { metricGitHubAppRateLimit } from '../github/rate-limit';
 import { getGitHubEnterpriseApiUrl } from './github-runner';
-import type { RunnerInfo, RunnerList, ScaleDownRunnerProvider } from './scale-down-provider';
+import type { RunnerInfo, ScaleDownRunnerProvider } from './types';
 
 const logger = createChildLogger('scale-down');
 
@@ -93,7 +93,7 @@ async function getGitHubRunnerBusyState(client: Octokit, runner: RunnerInfo, run
 }
 
 async function listGitHubRunners(runner: RunnerInfo): Promise<GhRunners> {
-  const key = runner.owner as string;
+  const key = runner.owner;
   const cachedRunners = githubCache.runners.get(key);
   if (cachedRunners) {
     logger.debug(`[listGithubRunners] Cache hit for ${key}`);
@@ -278,11 +278,10 @@ async function unMarkOrphan(id: string, runnerProvider: ScaleDownRunnerProvider)
   }
 }
 
-async function lastChanceCheckOrphanRunner(runner: RunnerList): Promise<boolean> {
-  const registeredRunner = runner as RunnerInfo;
-  const client = await getOrCreateOctokit(registeredRunner);
+async function lastChanceCheckOrphanRunner(runner: RunnerInfo): Promise<boolean> {
+  const client = await getOrCreateOctokit(runner);
   const runnerId = parseInt(runner.githubRunnerId || '0');
-  const state = await getGitHubSelfHostedRunnerState(client, registeredRunner, runnerId);
+  const state = await getGitHubSelfHostedRunnerState(client, runner, runnerId);
   let isOrphan = false;
 
   if (state === null) {
@@ -343,10 +342,10 @@ async function listRunners(environment: string, runnerProvider: ScaleDownRunnerP
   return await runnerProvider.list(environment);
 }
 
-function filterRunners(runners: RunnerList[]): RunnerInfo[] {
+function filterRunners(runners: RunnerInfo[]): RunnerInfo[] {
   // Managed runners are launched with owner and type tags together. Exclude incomplete records because both
   // values are required to select the GitHub owner and runner API used during scale-down.
-  return runners.filter((runner) => runner.owner && runner.type && !runner.orphan) as RunnerInfo[];
+  return runners.filter((runner) => runner.owner && runner.type && !runner.orphan);
 }
 
 export async function scaleDown(): Promise<void> {

lambdas/functions/control-plane/src/scale-runners/scale-down.ts

@@ -7,8 +7,7 @@ import * as ghAuth from '../github/auth';
 import { controlPlaneProviderRegistry } from '../control-plane-providers';
 import * as githubRunner from './github-runner';
 import { scaleUp } from './scale-up';
-import type { ScaleUpRunnerProvider } from './scale-up-provider';
-import type { ActionRequestMessageSQS } from './types';
+import type { ActionRequestMessageSQS, ScaleUpRunnerProvider } from './types';
 
 vi.mock('../github/auth', () => ({
   createGithubAppAuth: vi.fn(),