Skip to content

Global as dependency is broken #130

@EJBroeders

Description

@EJBroeders

In the latest version of Polymer-Redux (1.0.5) there is a dependency on the npm 'global' package, version ^4.3.1. That package cannot be served through the latest version of polymer-cli, because it uses the Node module export style, which isn't picked up by Polymer 3.

The fix is quite easy, remove the dependencies and remove the imports. I think that since this package will always run within the browser context those global variables (the window and console vars) are always present in the environment. Therefore there is no reason to import them from another package to make certain that they exist.

Do you concur or is there something that we're missing? If not, then we'll send a PR later this week :-)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions