feat: add monitoring_subscription column to aws_cloudfront_distribution (#2695)

Co-authored-by: Zhang Dajiang <zhang_dajiang@tech.gov.sg>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

aws-test/tests/aws_cloudfront_distribution/test-get-expected.json

@@ -5,6 +5,11 @@
     "domain_name": "{{ output.domain_name.value }}",
     "e_tag": "{{ output.etag.value }}",
     "id": "{{ output.resource_id.value }}",
+    "monitoring_subscription": {
+      "RealtimeMetricsSubscriptionConfig": {
+        "RealtimeMetricsSubscriptionStatus": "Enabled"
+      }
+    },
     "price_class": "PriceClass_200",
     "status": "Deployed",
     "tags": {

aws-test/tests/aws_cloudfront_distribution/test-get-query.sql

@@ -1,3 +1,3 @@
-select id, akas, tags, status, domain_name, default_root_object, e_tag, price_class
+select id, akas, tags, status, domain_name, default_root_object, e_tag, price_class, monitoring_subscription
 from aws.aws_cloudfront_distribution
 where id = '{{ output.resource_id.value }}';

aws-test/tests/aws_cloudfront_distribution/variables.tf

@@ -101,6 +101,16 @@ resource "aws_cloudfront_distribution" "named_test_resource" {
   }
 }
 
+resource "aws_cloudfront_monitoring_subscription" "test" {
+  distribution_id = aws_cloudfront_distribution.named_test_resource.id
+
+  monitoring_subscription {
+    realtime_metrics_subscription_config {
+      realtime_metrics_subscription_status = "Enabled"
+    }
+  }
+}
+
 output "resource_aka" {
   value = aws_cloudfront_distribution.named_test_resource.arn
 }

aws/table_aws_cloudfront_distribution.go

@@ -38,6 +38,13 @@ func tableAwsCloudFrontDistribution(_ context.Context) *plugin.Table {
 				Func: getCloudFrontDistributionTags,
 				Tags: map[string]string{"service": "cloudfront", "action": "ListTagsForResource"},
 			},
+			{
+				Func: getCloudFrontDistributionMonitoringSubscription,
+				Tags: map[string]string{"service": "cloudfront", "action": "GetMonitoringSubscription"},
+				IgnoreConfig: &plugin.IgnoreConfig{
+					ShouldIgnoreErrorFunc: shouldIgnoreErrors([]string{"NoSuchMonitoringSubscription"}),
+				},
+			},
 		},
 		Columns: awsRegionalColumns([]*plugin.Column{
 			{
@@ -215,6 +222,13 @@ func tableAwsCloudFrontDistribution(_ context.Context) *plugin.Table {
 				Type:        proto.ColumnType_JSON,
 				Transform:   transform.FromField("ViewerCertificate", "Distribution.DistributionConfig.ViewerCertificate"),
 			},
+			{
+				Name:        "monitoring_subscription",
+				Description: "The monitoring subscription for the CloudFront distribution.",
+				Type:        proto.ColumnType_JSON,
+				Hydrate:     getCloudFrontDistributionMonitoringSubscription,
+				Transform:   transform.FromValue(),
+			},
 
 			// Standard columns for all tables
 			{
@@ -356,6 +370,45 @@ func getCloudFrontDistributionTags(ctx context.Context, d *plugin.QueryData, h *
 	return op, nil
 }
 
+func getCloudFrontDistributionMonitoringSubscription(ctx context.Context, d *plugin.QueryData, h *plugin.HydrateData) (interface{}, error) {
+	// Get client
+	svc, err := CloudFrontClient(ctx, d)
+	if err != nil {
+		plugin.Logger(ctx).Error("aws_cloudfront_distribution.getCloudFrontDistributionMonitoringSubscription", "client_error", err)
+		return nil, err
+	}
+
+	var distributionID string
+	if h.Item != nil {
+		switch item := h.Item.(type) {
+		case types.DistributionSummary:
+			distributionID = *item.Id
+		case cloudfront.GetDistributionOutput:
+			distributionID = *item.Distribution.Id
+		}
+	} else {
+		distributionID = d.EqualsQuals["id"].GetStringValue()
+	}
+
+	if strings.TrimSpace(distributionID) == "" {
+		return nil, nil
+	}
+
+	// Build the params
+	params := &cloudfront.GetMonitoringSubscriptionInput{
+		DistributionId: &distributionID,
+	}
+
+	// Get call
+	op, err := svc.GetMonitoringSubscription(ctx, params)
+	if err != nil {
+		plugin.Logger(ctx).Error("aws_cloudfront_distribution.getCloudFrontDistributionMonitoringSubscription", "api_error", err)
+		return nil, err
+	}
+
+	return op.MonitoringSubscription, nil
+}
+
 //// TRANSFORM FUNCTIONS
 
 func cloudFrontDistributionTagListToTurbotTags(ctx context.Context, d *transform.TransformData) (interface{}, error) {