fix lifecycle prefix (#26)

mjreed-wbd · jritsema · commit 2b772a3790fb · 2019-03-22T14:49:00.000-04:00
* fix lifecycle prefix

* makes expiration days variable
diff --git a/env/dev/lb.tf b/env/dev/lb.tf
@@ -32,6 +32,10 @@ variable "health_check_matcher" {
   default = "200"
 }
 
+variable "lb_access_logs_expiration_days" {
+  default = "3"
+}
+
 resource "aws_alb" "main" {
   name = "${var.app}-${var.environment}"
 
@@ -81,10 +85,10 @@ resource "aws_s3_bucket" "lb_access_logs" {
     id                                     = "cleanup"
     enabled                                = true
     abort_incomplete_multipart_upload_days = 1
-    prefix                                 = "/"
+    prefix                                 = ""
 
     expiration {
-      days = 3
+      days = "${var.lb_access_logs_expiration_days}"
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,10 @@ variable "health_check_matcher" {`
`32`	`32`	`default = "200"`
`33`	`33`	`}`
`34`	`34`
	`35`	`+variable "lb_access_logs_expiration_days" {`
	`36`	`+ default = "3"`
	`37`	`+}`
	`38`	`+`
`35`	`39`	`resource "aws_alb" "main" {`
`36`	`40`	`name = "${var.app}-${var.environment}"`
`37`	`41`
`@@ -81,10 +85,10 @@ resource "aws_s3_bucket" "lb_access_logs" {`
`81`	`85`	`id = "cleanup"`
`82`	`86`	`enabled = true`
`83`	`87`	`abort_incomplete_multipart_upload_days = 1`
`84`		`- prefix = "/"`
	`88`	`+ prefix = ""`
`85`	`89`
`86`	`90`	`expiration {`
`87`		`- days = 3`
	`91`	`+ days = "${var.lb_access_logs_expiration_days}"`
`88`	`92`	`}`
`89`	`93`	`}`
`90`	`94`